[PR #1018] [CLOSED] Add C++ builder pattern #1957

New issue

Closed

opened 2026-10-29 21:31:41 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:31:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1018
Author: @JasonZhang517
Created: 11/4/2025
Status: ❌ Closed

Base: main ← Head: builder_cpp

📝 Commits (10+)

47add82 add C++ builder for client
9c644f0 Merge branch 'main' into builder_cpp
58650f8 changed builder to const
4fbe66a reformat the code
2fb2b7e 1. fixed names and return value types 2. added tests for the builder
a9aa54c reformat the codes
58766bc style: clang-format-16 for pybind_client.h
8010e07 revert create in setup_internal function
a6a7dc3 1. revert deprecated 2. integrate builder test to client builder tests.
ff674c5 fixed naming bugs

📊 Changes

4 files changed (+167 additions, -1 deletions)

View changed files

📝 mooncake-store/include/client.h (+30 -0)
📝 mooncake-store/src/client.cpp (+75 -0)
📝 mooncake-store/src/pybind_client.cpp (+0 -1)
📝 mooncake-store/tests/client_integration_test.cpp (+62 -0)

📄 Description

Corresponding to https://github.com/kvcache-ai/Mooncake/issues/978
Based on existing create method:
static std::optional<std::shared_ptr> Create(
const std::string& local_hostname,
const std::string& metadata_connstring, const std::string& protocol,
const std::optionalstd::string& device_names = std::nullopt,
const std::string& master_server_entry = kDefaultMasterAddress,
const std::shared_ptr& transfer_engine = nullptr);

Added builder functions with std::move to reduce copy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1018 **Author:** [@JasonZhang517](https://github.com/JasonZhang517) **Created:** 11/4/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `builder_cpp` --- ### 📝 Commits (10+) - [`47add82`](https://github.com/kvcache-ai/Mooncake/commit/47add822ab010685a64c985bf92fabb34e7f96e6) add C++ builder for client - [`9c644f0`](https://github.com/kvcache-ai/Mooncake/commit/9c644f005150ae49ff81888508b4c36931467589) Merge branch 'main' into builder_cpp - [`58650f8`](https://github.com/kvcache-ai/Mooncake/commit/58650f84503b7d6e6ec535e5fcd4f978530f9c59) changed builder to const - [`4fbe66a`](https://github.com/kvcache-ai/Mooncake/commit/4fbe66acad2734fb46630e84a363c4bd26cf91cd) reformat the code - [`2fb2b7e`](https://github.com/kvcache-ai/Mooncake/commit/2fb2b7e4c7efb5fa5140ed2e3b76c65a188cd38a) 1. fixed names and return value types 2. added tests for the builder - [`a9aa54c`](https://github.com/kvcache-ai/Mooncake/commit/a9aa54c70ec33bf44bef3a808313f81a12928206) reformat the codes - [`58766bc`](https://github.com/kvcache-ai/Mooncake/commit/58766bcfdbbd6e647f1a9c18bfaed20975cd3e33) style: clang-format-16 for pybind_client.h - [`8010e07`](https://github.com/kvcache-ai/Mooncake/commit/8010e075d814f03adcbd5a6a445e916341ca1767) revert create in setup_internal function - [`a6a7dc3`](https://github.com/kvcache-ai/Mooncake/commit/a6a7dc3725578ff105874a62912d548c838b1318) 1. revert deprecated 2. integrate builder test to client builder tests. - [`ff674c5`](https://github.com/kvcache-ai/Mooncake/commit/ff674c545d1dc15599bba9f1adc5c42a288cb0ee) fixed naming bugs ### 📊 Changes **4 files changed** (+167 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/client.h` (+30 -0) 📝 `mooncake-store/src/client.cpp` (+75 -0) 📝 `mooncake-store/src/pybind_client.cpp` (+0 -1) 📝 `mooncake-store/tests/client_integration_test.cpp` (+62 -0) </details> ### 📄 Description Corresponding to https://github.com/kvcache-ai/Mooncake/issues/978 Based on existing create method: static std::optional<std::shared_ptr<Client>> Create( const std::string& local_hostname, const std::string& metadata_connstring, const std::string& protocol, const std::optional<std::string>& device_names = std::nullopt, const std::string& master_server_entry = kDefaultMasterAddress, const std::shared_ptr<TransferEngine>& transfer_engine = nullptr); Added builder functions with std::move to reduce copy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:31:41 +00:00