[PR #1075] [MERGED] [Bug] fixed bug of master not using glog actually

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#1997

bsakaguchi commented

2026-10-29 21:31:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1075
Author: @SpecterCipher
Created: 11/18/2025
Status: ✅ Merged
Merged: 12/1/2025
Merged by: @stmatengss

Base: main ← Head: dev/SpecterCipher

📝 Commits (1)

66e1530 [Bug] fixed bug of master not using glog actually

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 mooncake-store/src/master.cpp (+6 -0)

📄 Description

Description

Before modification, when the mooncake master started, it would issue a warning: "Logging before InitGoogleLogging() is written to STDERR". After modification, logs are printed in the glog format, defaulting to the /tmp directory with filenames starting with mooncake_master. Custom log configuration can be achieved by setting the corresponding glog flags during startup.

Type of Change

Types
- [√ ] Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1075 **Author:** [@SpecterCipher](https://github.com/SpecterCipher) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 12/1/2025 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `dev/SpecterCipher` --- ### 📝 Commits (1) - [`66e1530`](https://github.com/kvcache-ai/Mooncake/commit/66e15302da9dfd80fbc245da7b7c4b5c199bc433) [Bug] fixed bug of master not using glog actually ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/src/master.cpp` (+6 -0) </details> ### 📄 Description ## Description Before modification, when the mooncake master started, it would issue a warning: "Logging before InitGoogleLogging() is written to STDERR". After modification, logs are printed in the glog format, defaulting to the /tmp directory with filenames starting with mooncake_master. Custom log configuration can be achieved by setting the corresponding glog flags during startup. ## Type of Change * Types - [√ ] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1075] [MERGED] [Bug] fixed bug of master not using glog actually #1997