[PR #1081] [MERGED] [Store] Add support for static labels (host IP/cluster name) in client metrics by iflytek #2000

New issue

Closed

opened 2026-10-29 21:32:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:32:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1081
Author: @cocktail828
Created: 11/19/2025
Status: ✅ Merged
Merged: 11/29/2025
Merged by: @stmatengss

Base: main ← Head: enhance_metric

📝 Commits (10+)

35a8790 [Store] enhance client metric
df8baec [Store] enhance client metric - fix typos
923a7e3 [Store] remove unnecessary move operations and improve performance
5c2ccbd [Store] Uses MC_STORE_CLUSTER_ID to identify the LLM cluster
f9a524f [Store] fix test case errors
c5a6713 Merge branch 'kvcache-ai:main' into enhance_metric
362ba33 [Store] support passing metric labels
42aeb20 [Store] fix typos
27560a4 Merge branch 'main' into enhance_metric
c565270 [Store] merge main and remove needless env

📊 Changes

8 files changed (+626 additions, -33 deletions)

View changed files

📝 doc/en/mooncake-store.md (+7 -0)
📝 doc/zh/mooncake-store.md (+7 -0)
📝 mooncake-store/include/client_metric.h (+55 -23)
📝 mooncake-store/include/client_service.h (+4 -2)
➕ mooncake-store/include/hybrid_metric.h (+447 -0)
📝 mooncake-store/src/client_metric.cpp (+8 -4)
📝 mooncake-store/src/client_service.cpp (+6 -4)
📝 mooncake-store/tests/client_metrics_test.cpp (+92 -0)

📄 Description

Description

Current client metrics lack necessary context information. In actual troubleshooting, key details like host IP and cluster name can effectively improve problem-solving efficiency, which are essential supplements for production-grade instrumentation.

Changes in This PR

Add support for static labels in client metrics, including core fields such as host IP and cluster name.
Keep the original metric logic unchanged—only attach static labels without any non-breaking changes.
Label values follow existing configuration standards, requiring no additional manual setup and adapting to the current deployment workflow.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1081 **Author:** [@cocktail828](https://github.com/cocktail828) **Created:** 11/19/2025 **Status:** ✅ Merged **Merged:** 11/29/2025 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `enhance_metric` --- ### 📝 Commits (10+) - [`35a8790`](https://github.com/kvcache-ai/Mooncake/commit/35a8790f17a4f325727ffc974f3c7b859fffad0c) [Store] enhance client metric - [`df8baec`](https://github.com/kvcache-ai/Mooncake/commit/df8baec25cf7c4c8c4a8c16e4d8f4242c70d45fb) [Store] enhance client metric - fix typos - [`923a7e3`](https://github.com/kvcache-ai/Mooncake/commit/923a7e3ac31ff819fa0357d2bfb5f3c39d5fa483) [Store] remove unnecessary move operations and improve performance - [`5c2ccbd`](https://github.com/kvcache-ai/Mooncake/commit/5c2ccbd4143cf67414de6c67150c2ad47f0036ba) [Store] Uses MC_STORE_CLUSTER_ID to identify the LLM cluster - [`f9a524f`](https://github.com/kvcache-ai/Mooncake/commit/f9a524fc0d5f757776474364ab4bbadef1df9064) [Store] fix test case errors - [`c5a6713`](https://github.com/kvcache-ai/Mooncake/commit/c5a6713bfd341b9479ed49d74d65ff9a71e099de) Merge branch 'kvcache-ai:main' into enhance_metric - [`362ba33`](https://github.com/kvcache-ai/Mooncake/commit/362ba33b5677faea353c63db0983430e4b447518) [Store] support passing metric labels - [`42aeb20`](https://github.com/kvcache-ai/Mooncake/commit/42aeb20df98492f7fe7671c34113d9cfd6abc292) [Store] fix typos - [`27560a4`](https://github.com/kvcache-ai/Mooncake/commit/27560a4c565defcf67109a3bba82196ee625ce1f) Merge branch 'main' into enhance_metric - [`c565270`](https://github.com/kvcache-ai/Mooncake/commit/c56527021b4636610e2477d2adefc75284851e4b) [Store] merge main and remove needless env ### 📊 Changes **8 files changed** (+626 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `doc/en/mooncake-store.md` (+7 -0) 📝 `doc/zh/mooncake-store.md` (+7 -0) 📝 `mooncake-store/include/client_metric.h` (+55 -23) 📝 `mooncake-store/include/client_service.h` (+4 -2) ➕ `mooncake-store/include/hybrid_metric.h` (+447 -0) 📝 `mooncake-store/src/client_metric.cpp` (+8 -4) 📝 `mooncake-store/src/client_service.cpp` (+6 -4) 📝 `mooncake-store/tests/client_metrics_test.cpp` (+92 -0) </details> ### 📄 Description ## Description Current client metrics lack necessary context information. In actual troubleshooting, key details like host IP and cluster name can effectively improve problem-solving efficiency, which are essential supplements for production-grade instrumentation. ## Changes in This PR - Add support for static labels in client metrics, including core fields such as host IP and cluster name. - Keep the original metric logic unchanged—only attach static labels without any non-breaking changes. - Label values follow existing configuration standards, requiring no additional manual setup and adapting to the current deployment workflow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:32:01 +00:00