[PR #1114] [MERGED] change cmake

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2020

bsakaguchi commented

2026-10-29 21:32:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1114
Author: @ascend-direct-dev
Created: 11/25/2025
Status: ✅ Merged
Merged: 12/2/2025
Merged by: @alogfans

Base: main ← Head: main

📝 Commits (1)

743f169 change cmake for ascend

📊 Changes

9 files changed (+111 additions, -34 deletions)

View changed files

📝 mooncake-common/common.cmake (+14 -4)
📝 mooncake-integration/CMakeLists.txt (+36 -11)
📝 mooncake-transfer-engine/example/CMakeLists.txt (+1 -1)
📝 mooncake-transfer-engine/include/transport/ascend_transport/ascend_direct_transport/ascend_direct_transport.h (+1 -2)
📝 mooncake-transfer-engine/src/CMakeLists.txt (+1 -13)
📝 mooncake-transfer-engine/src/transport/CMakeLists.txt (+3 -1)
📝 mooncake-transfer-engine/src/transport/ascend_transport/CMakeLists.txt (+19 -1)
📝 mooncake-transfer-engine/src/transport/ascend_transport/ascend_direct_transport/ascend_direct_transport.cpp (+17 -1)
📝 scripts/build_wheel.sh (+19 -0)

📄 Description

Description

In ascend platform, BUILD_SHARED_LIBS need to be set, to solve bug like https://github.com/kvcache-ai/Mooncake/issues/1008

Type of Change

Types
- Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1114 **Author:** [@ascend-direct-dev](https://github.com/ascend-direct-dev) **Created:** 11/25/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@alogfans](https://github.com/alogfans) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`743f169`](https://github.com/kvcache-ai/Mooncake/commit/743f1699cda9dd4f3b3e7ac912989b06a8f8b3c9) change cmake for ascend ### 📊 Changes **9 files changed** (+111 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-common/common.cmake` (+14 -4) 📝 `mooncake-integration/CMakeLists.txt` (+36 -11) 📝 `mooncake-transfer-engine/example/CMakeLists.txt` (+1 -1) 📝 `mooncake-transfer-engine/include/transport/ascend_transport/ascend_direct_transport/ascend_direct_transport.h` (+1 -2) 📝 `mooncake-transfer-engine/src/CMakeLists.txt` (+1 -13) 📝 `mooncake-transfer-engine/src/transport/CMakeLists.txt` (+3 -1) 📝 `mooncake-transfer-engine/src/transport/ascend_transport/CMakeLists.txt` (+19 -1) 📝 `mooncake-transfer-engine/src/transport/ascend_transport/ascend_direct_transport/ascend_direct_transport.cpp` (+17 -1) 📝 `scripts/build_wheel.sh` (+19 -0) </details> ### 📄 Description ## Description In ascend platform, BUILD_SHARED_LIBS need to be set, to solve bug like https://github.com/kvcache-ai/Mooncake/issues/1008 ## Type of Change * Types - [ ] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested?  ## Checklist - [ ] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1114] [MERGED] change cmake #2020