[PR #1146] [MERGED] feat[Store]: Refine shm mmap logic and add reconnection for Dummy Client after the Real restarted

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2038

bsakaguchi commented

2026-10-29 21:32:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1146
Author: @YiXR
Created: 12/1/2025
Status: ✅ Merged
Merged: 12/2/2025
Merged by: @ykwd

Base: main ← Head: xinyi-client

📝 Commits (2)

b7c934c [Store Using memfd_create + UNIX socket for shm mmap
a02d70f [Store] Add reconnection for dummy client if real client is restarted

📊 Changes

7 files changed (+418 additions, -110 deletions)

View changed files

📝 mooncake-integration/store/store_py.cpp (+4 -2)
📝 mooncake-store/include/dummy_client.h (+14 -6)
📝 mooncake-store/include/pyclient.h (+14 -2)
📝 mooncake-store/include/real_client.h (+18 -8)
📝 mooncake-store/src/dummy_client.cpp (+195 -65)
📝 mooncake-store/src/real_client.cpp (+172 -26)
📝 mooncake-store/src/real_client_main.cpp (+1 -1)

📄 Description

Description

Releated to https://github.com/kvcache-ai/Mooncake/pull/1084
Now Dummy Client can reconnect to Real Client after the Real Client restarted.

Type of Change

Types
- Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1146 **Author:** [@YiXR](https://github.com/YiXR) **Created:** 12/1/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@ykwd](https://github.com/ykwd) **Base:** `main` ← **Head:** `xinyi-client` --- ### 📝 Commits (2) - [`b7c934c`](https://github.com/kvcache-ai/Mooncake/commit/b7c934ccb2a8eb115485c3da7161ef5154672c05) [Store Using memfd_create + UNIX socket for shm mmap - [`a02d70f`](https://github.com/kvcache-ai/Mooncake/commit/a02d70ff4cea77609f8ba9ae265cb1d03c98e6b6) [Store] Add reconnection for dummy client if real client is restarted ### 📊 Changes **7 files changed** (+418 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-integration/store/store_py.cpp` (+4 -2) 📝 `mooncake-store/include/dummy_client.h` (+14 -6) 📝 `mooncake-store/include/pyclient.h` (+14 -2) 📝 `mooncake-store/include/real_client.h` (+18 -8) 📝 `mooncake-store/src/dummy_client.cpp` (+195 -65) 📝 `mooncake-store/src/real_client.cpp` (+172 -26) 📝 `mooncake-store/src/real_client_main.cpp` (+1 -1) </details> ### 📄 Description ## Description Releated to https://github.com/kvcache-ai/Mooncake/pull/1084 Now Dummy Client can reconnect to Real Client after the Real Client restarted. <img width="1564" height="692" alt="image" src="https://github.com/user-attachments/assets/b329a752-4ba4-4ae0-8eb9-57cc172d14a4" /> ## Type of Change * Types - [ ] Bug fix - [x] New feature - [ ] Transfer Engine - [x] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested?  ## Checklist - [x] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1146] [MERGED] feat[Store]: Refine shm mmap logic and add reconnection for Dummy Client after the Real restarted #2038