kvcache-ai/Mooncake

Fork

You've already forked Mooncake

mirror of https://github.com/kvcache-ai/Mooncake.git synced 2026-11-05 01:17:55 +00:00

Code Issues 368 Projects Packages Wiki Activity

[PR #1174] [CLOSED] [Store] refactor: config loading and CLI parsing by iflytek #2052

New issue

Closed

opened 2026-10-29 21:32:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:32:24 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1174
Author: @cocktail828
Created: 12/6/2025
Status: ❌ Closed

Base: main ← Head: refactor_config

📝 Commits (3)

b6d2cc2 [Store] refactor: config loading and CLI parsing
e18b634 [Store] fix typos and issues raised by the AI assistant.
e240c6d [Store] fix ci errors

📊 Changes

23 files changed (+12721 additions, -1116 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 mooncake-store/CMakeLists.txt (+1 -0)
➕ mooncake-store/include/CLI11/CLI11.hpp (+12045 -0)
➕ mooncake-store/include/cli.h (+65 -0)
📝 mooncake-store/include/client_metric.h (+0 -6)
➖ mooncake-store/include/config_helper.h (+0 -98)
📝 mooncake-store/include/ha_helper.h (+2 -2)
📝 mooncake-store/include/master_config.h (+192 -448)
📝 mooncake-store/include/master_service.h (+1 -1)
📝 mooncake-store/include/rpc_service.h (+1 -1)
📝 mooncake-store/include/utils.h (+23 -1)
📝 mooncake-store/src/ha_helper.cpp (+7 -6)
📝 mooncake-store/src/master.cpp (+137 -432)
📝 mooncake-store/src/master_metric_manager.cpp (+2 -2)
📝 mooncake-store/src/master_service.cpp (+9 -5)
📝 mooncake-store/src/rpc_service.cpp (+3 -4)
📝 mooncake-store/tests/CMakeLists.txt (+2 -0)
➕ mooncake-store/tests/conf/master.conf (+4 -0)
📝 mooncake-store/tests/master_metrics_test.cpp (+3 -3)
📝 mooncake-store/tests/master_service_ssd_test.cpp (+4 -3)

...and 3 more files

📄 Description

Description

The current command-line parsing uses gflags, which doesn't support hot updates and has limited extensibility. Additionally, the various config structure definitions and initialization code are verbose and difficult to read. Furthermore, logging has never supported persistence and always prints to screen, making it unsuitable for production environments.

This PR replaces gflags with CLI11, which allows configuration and command-line parsing to be handled together while flexibly supporting parameter deprecation mechanisms. It also makes configuration hot-reloading possible with minimal overhead - no need to write redundant code for parsing configuration files, just re-call the Parser interface. Priority mechanisms are also supported (Command Line > Configuration File > Default Values).

Additionally, duplicate code related to Master config has been refactored and streamlined. This modification significantly simplifies master-related code.

Type of Change

Types
- Refactor
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Added comprehensive unit tests for configuration loading and command-line parsing scenarios
Verified existing integration tests continue to pass
Manual testing on Linux to confirm proper config resolution when executing from different working directories
Confirmed backward compatibility with existing command-line usage patterns

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1174 **Author:** [@cocktail828](https://github.com/cocktail828) **Created:** 12/6/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `refactor_config` --- ### 📝 Commits (3) - [`b6d2cc2`](https://github.com/kvcache-ai/Mooncake/commit/b6d2cc226c6b51a5225ba1e004e25706ed2e3f86) [Store] refactor: config loading and CLI parsing - [`e18b634`](https://github.com/kvcache-ai/Mooncake/commit/e18b63499f31ac17872fdc2856ea3563a289deb2) [Store] fix typos and issues raised by the AI assistant. - [`e240c6d`](https://github.com/kvcache-ai/Mooncake/commit/e240c6de1c0f501db869507b517a78c71c642ccd) [Store] fix ci errors ### 📊 Changes **23 files changed** (+12721 additions, -1116 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `mooncake-store/CMakeLists.txt` (+1 -0) ➕ `mooncake-store/include/CLI11/CLI11.hpp` (+12045 -0) ➕ `mooncake-store/include/cli.h` (+65 -0) 📝 `mooncake-store/include/client_metric.h` (+0 -6) ➖ `mooncake-store/include/config_helper.h` (+0 -98) 📝 `mooncake-store/include/ha_helper.h` (+2 -2) 📝 `mooncake-store/include/master_config.h` (+192 -448) 📝 `mooncake-store/include/master_service.h` (+1 -1) 📝 `mooncake-store/include/rpc_service.h` (+1 -1) 📝 `mooncake-store/include/utils.h` (+23 -1) 📝 `mooncake-store/src/ha_helper.cpp` (+7 -6) 📝 `mooncake-store/src/master.cpp` (+137 -432) 📝 `mooncake-store/src/master_metric_manager.cpp` (+2 -2) 📝 `mooncake-store/src/master_service.cpp` (+9 -5) 📝 `mooncake-store/src/rpc_service.cpp` (+3 -4) 📝 `mooncake-store/tests/CMakeLists.txt` (+2 -0) ➕ `mooncake-store/tests/conf/master.conf` (+4 -0) 📝 `mooncake-store/tests/master_metrics_test.cpp` (+3 -3) 📝 `mooncake-store/tests/master_service_ssd_test.cpp` (+4 -3) _...and 3 more files_ </details> ### 📄 Description ## Description The current command-line parsing uses gflags, which doesn't support hot updates and has limited extensibility. Additionally, the various config structure definitions and initialization code are verbose and difficult to read. Furthermore, logging has never supported persistence and always prints to screen, making it unsuitable for production environments. This PR replaces gflags with CLI11, which allows configuration and command-line parsing to be handled together while flexibly supporting parameter deprecation mechanisms. It also makes configuration hot-reloading possible with minimal overhead - no need to write redundant code for parsing configuration files, just re-call the Parser interface. Priority mechanisms are also supported (Command Line > Configuration File > Default Values). Additionally, duplicate code related to Master config has been refactored and streamlined. This modification significantly simplifies master-related code. ## Type of Change * Types - [x] Refactor - [ ] Transfer Engine - [x] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested? - Added comprehensive unit tests for configuration loading and command-line parsing scenarios - Verified existing integration tests continue to pass - Manual testing on Linux to confirm proper config resolution when executing from different working directories - Confirmed backward compatibility with existing command-line usage patterns ## Checklist - [x] I have performed a self-review of my own code. - [x] I have updated the documentation. - [x] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:32:24 +00:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

te-coro

staryxchen-tent-capability-research

feature/musa-ep-jit

zxpdemonio/fix-tent-bootstrap-admission

add-store-rs-tone-tests

scatter-rdma-completion-pr2

P2P-Mooncake-Store

release/v0.3.14

feat/tent-rdma-adaptive-adapter

fix/ep-local-counter-gpu-scope

codex/kvcs-oplog-eviction

give-me-a-star

cruz/mooncake-kvcs-lowlevel-pr1-20261008

ylt-handshake-limits

ci/rocm-e2e-tent

sima/docs-pypi-downloads

fix-ci/hicache-mooncake-metadata-loopback

sima/cuda-driver-loading

sima/ci-performance-gate

fix/tent-rdma-unknown-topology-rail-pairing

ci/tent-e2e-dual-job

mc-patch-1

codex/p2p-merge-prerequisites

sima/store-hca-numa-placement

codex/p2p-merge-cli

codex/p2p-merge-ipv6

copilot/fix-ctests-job-failure

czh/pg-device-collectives-pr6

dependabot/cargo/mooncake-store-rs/pyo3-0.29.0

czh/pg-device-collectives-pr5

codex/segment-pool-master-cutover

sima/nightly-ci-recovery

ci/tent-params

stmatengss-patch-1

dependabot/cargo/mooncake-store-rs/rand-0.8.8

dependabot/cargo/mooncake-store-rs/opentelemetry_sdk-0.32.1

dependabot/cargo/mooncake-store-rs/xxhash-rust-0.8.16

codex/migrate-store-rest-service

fix/tone-wheel-arch-selection

czh/pg-device-collectives-pr4

czh/pg-device-collectives-pr3

ketong/fix_moe_tc

copilot/fix-test-wheel-ubuntu-job

fix/ci-wheel-torch-pg-pin

codex/migrate-structured-object-storage

codex/migrate-allocator-python

codex/migrate-vllm-python

codex/migrate-shared-segment

ci/fix_sgl_eval_install

codex/segment-pool-nof-placement-cleanup

feat/pip-native-release

copilot/bugfix-ha-standby-promotion

copilot/mooncake-store-transport-settings

copilot/fix-tensor-support-issues

copilot/optimize-rl-direction

copilot/mooncake-storeagentic-workflow

copilot/fix-client-reconnect-timeout

copilot/mooncake-error-debugging

copilot/mooncake-ipv6-support

feat/nccl-host-python-api

dependabot/go_modules/mooncake-p2p-store/src/p2pstore/google.golang.org/grpc-1.82.1

copilot/migrate-and-move-operations

copilot/migrate-and-move-operations-again

refactor/centralize-env-vars

idhanani/mooncake-retain-groups

copilot/codeownerreviewer

copilot/give-feedback-on-issue-2123

copilot/create-issue-rfc

copilot/break-cuda-monopoly-logic

copilot/compare-cudamemcpy-cu12-cu13

copilot/report-ci-error-issue

copilot/research-commit-history-analysis

copilot/explain-mooncake-store-service

copilot/analyze-project-functionality

copilot/sub-pr-1680

copilot/review-pr-1680

copilot/sub-pr-1597

copilot/fix-github-actions-job-failure

copilot/move-test-sglang-integration-job

v0.3.14

v0.3.14-pre-4

v0.3.14-pre-3

v0.3.14-pre-2

v0.3.14-pre

v0.3.14-rc1

v0.3.13.post1

v0.3.13-rc2

v0.3.13-rc1

v0.3.13

v0.3.12.post1

v0.3.12

v0.3.11-rc1

v0.3.11.post1

v0.3.11

v0.3.10.post2

v0.3.10.post1

v0.3.10

v0.3.9

v0.3.8.post1

v0.3.8

v0.3.7.post2

v0.3.7.post1

v0.3.7

v0.3.6.post1

v0.3.6

v0.3.5

v0.3.4.post2

v0.3.4.post1

v0.3.4

v0.3.3.post2

v0.3.3.post1

v0.3.3

v0.3.2.post1

v0.3.2

v0.3.1

v0.3.0

v0.3.0-beta

v0.3.0-alpha

v0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2052

Reference in a new issue

Repository

kvcache-ai/Mooncake

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns