[PR #1199] [MERGED] [Store] add safe tensor API

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2066

bsakaguchi commented

2026-10-29 21:32:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1199
Author: @stmatengss
Created: 12/11/2025
Status: ✅ Merged
Merged: 2/26/2026
Merged by: @stmatengss

Base: main ← Head: add_kvcache_saver

📝 Commits (10+)

d9761b1 [Store] add safe tensor API
e8f79e1 Merge branch 'main' into add_kvcache_saver
76c2a21 Apply suggestions from code review
def82a1 Merge branch 'main' into add_kvcache_saver
f2300b5 lint
fd00add refactor
4a7ed37 add test
2ffb6de fix
545c035 fix
89a0602 Apply suggestions from code review

📊 Changes

4 files changed (+456 additions, -1 deletions)

View changed files

📝 .github/workflows/ci.yml (+7 -0)
📝 mooncake-integration/store/store_py.cpp (+109 -0)
➕ mooncake-wheel/tests/test_safetensor_functions.py (+338 -0)
📝 scripts/run_tests.sh (+2 -1)

📄 Description

Description

This PR can enable loading/saving model weights / kvcache from files in safetensor format.

TODO:

add unit test
add documents

Type of Change

Types
- Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1199 **Author:** [@stmatengss](https://github.com/stmatengss) **Created:** 12/11/2025 **Status:** ✅ Merged **Merged:** 2/26/2026 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `add_kvcache_saver` --- ### 📝 Commits (10+) - [`d9761b1`](https://github.com/kvcache-ai/Mooncake/commit/d9761b1cc92518d178ea0dbad5b650cf2b665ff8) [Store] add safe tensor API - [`e8f79e1`](https://github.com/kvcache-ai/Mooncake/commit/e8f79e1347a68d31decfde32c4865d316460f561) Merge branch 'main' into add_kvcache_saver - [`76c2a21`](https://github.com/kvcache-ai/Mooncake/commit/76c2a215b1b7fe1bd5c88371b0d0d1ef51e08541) Apply suggestions from code review - [`def82a1`](https://github.com/kvcache-ai/Mooncake/commit/def82a1cea5f20e4b0d1e5d4e998f0988c4311aa) Merge branch 'main' into add_kvcache_saver - [`f2300b5`](https://github.com/kvcache-ai/Mooncake/commit/f2300b5830271bd9c2746aa8c52b220f2f780e16) lint - [`fd00add`](https://github.com/kvcache-ai/Mooncake/commit/fd00add0c7e7a3d77fb1fc0b2cf8e6fd0ec18233) refactor - [`4a7ed37`](https://github.com/kvcache-ai/Mooncake/commit/4a7ed37de8a74b3153983705e9104f1cd9111e07) add test - [`2ffb6de`](https://github.com/kvcache-ai/Mooncake/commit/2ffb6de33b0e8bb6565e993bc69e555c11ce7ee4) fix - [`545c035`](https://github.com/kvcache-ai/Mooncake/commit/545c0358665b8fb8ff0cef5e1e56b815247e20ef) fix - [`89a0602`](https://github.com/kvcache-ai/Mooncake/commit/89a0602cdd923bc016a2890de3eff54e016e7d21) Apply suggestions from code review ### 📊 Changes **4 files changed** (+456 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+7 -0) 📝 `mooncake-integration/store/store_py.cpp` (+109 -0) ➕ `mooncake-wheel/tests/test_safetensor_functions.py` (+338 -0) 📝 `scripts/run_tests.sh` (+2 -1) </details> ### 📄 Description ## Description This PR can enable loading/saving model weights / kvcache from files in safetensor format. TODO: - [x] add unit test - [ ] add documents ## Type of Change * Types - [ ] Bug fix - [ ] New feature - [ ] Transfer Engine - [x] Mooncake Store - [ ] Mooncake EP - [x] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested?  ## Checklist - [x] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1199] [MERGED] [Store] add safe tensor API #2066