[PR #1215] [CLOSED] Reset static singleton MasterMetricManager after Leader Re-election

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2079

bsakaguchi commented

2026-10-29 21:32:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1215
Author: @SpecterCipher
Created: 12/15/2025
Status: ❌ Closed

Base: main ← Head: dev/SpecterCipher

📝 Commits (4)

📊 Changes

3 files changed (+137 additions, -153 deletions)

View changed files

📝 mooncake-store/include/master_metric_manager.h (+116 -0)
📝 mooncake-store/src/ha_helper.cpp (+3 -0)
📝 mooncake-store/src/master_metric_manager.cpp (+18 -153)

📄 Description

Description

Type of Change

Types
- [ √] Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1215 **Author:** [@SpecterCipher](https://github.com/SpecterCipher) **Created:** 12/15/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/SpecterCipher` --- ### 📝 Commits (4) - [`49c9fb9`](https://github.com/kvcache-ai/Mooncake/commit/49c9fb9cf106d6a633fadaccd384be8c1aa0bf29) Fix #1186 - [`9185d02`](https://github.com/kvcache-ai/Mooncake/commit/9185d02f2c31074ad6833d48400760101e2a9b2e) Fix #1186 - [`0db1daf`](https://github.com/kvcache-ai/Mooncake/commit/0db1daf63fbd05e188b7d8cb1714b6282567fc27) Fix #1186 - [`a19d335`](https://github.com/kvcache-ai/Mooncake/commit/a19d3354f0758dffbeda4ceca3bacc6fa37f5471) Fix #1186 ### 📊 Changes **3 files changed** (+137 additions, -153 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/master_metric_manager.h` (+116 -0) 📝 `mooncake-store/src/ha_helper.cpp` (+3 -0) 📝 `mooncake-store/src/master_metric_manager.cpp` (+18 -153) </details> ### 📄 Description ## Description  ## Type of Change * Types - [ √] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested?  ## Checklist - [ ] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1215] [CLOSED] Reset static singleton MasterMetricManager after Leader Re-election #2079