kvcache-ai/Mooncake

Fork

You've already forked Mooncake

mirror of https://github.com/kvcache-ai/Mooncake.git synced 2026-11-05 01:17:55 +00:00

Code Issues 368 Projects Packages Wiki Activity

[PR #1219] [CLOSED] [Store] Delete useless meta from http metadata server #2083

New issue

Closed

opened 2026-10-29 21:32:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:32:39 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1219
Author: @stmatengss
Created: 12/16/2025
Status: ❌ Closed

Base: main ← Head: refactor_metadata_server

📝 Commits (10+)

b56dbf2 [Store] Delete useless meta from http metadata server
0bc7cce update
3a42c5b update
158bc76 Merge branch 'main' into refactor_metadata_server
cddaafc update
2a2b0a2 Merge branch 'main' into refactor_metadata_server
cea4970 Merge branch 'main' into refactor_metadata_server
ce80efa [Store] Optimize HTTP metadata server health checks (#1484)
283ccd7 [Store] Format code with clang-format-20 (#1489)
abb53d4 [Store] Remove trailing whitespace in rpc_service.cpp (#1490)

📊 Changes

6 files changed (+170 additions, -40 deletions)

View changed files

📝 mooncake-store/include/http_metadata_server.h (+21 -0)
📝 mooncake-store/include/master_config.h (+10 -0)
📝 mooncake-store/include/rpc_service.h (+2 -0)
📝 mooncake-store/src/http_metadata_server.cpp (+107 -0)
📝 mooncake-store/src/master.cpp (+19 -40)
📝 mooncake-store/src/rpc_service.cpp (+11 -0)

📄 Description

Description

Adds periodic health monitoring to the HTTP metadata server to automatically clean up stale segment metadata. The HTTP metadata server is initialized after the WrappedMasterService is created, allowing it to query segment status and remove metadata for segments that no longer exist.

Key changes:

Added GetAllSegments() method to WrappedMasterService to expose segment information for health checks
Moved HTTP metadata server initialization to after WrappedMasterService creation in the non-HA path, passing the shared_ptr<WrappedMasterService> directly for health monitoring
Implemented a health monitoring thread in HttpMetadataServer that periodically (every 10 minutes) checks segments and cleans up metadata for segments that no longer exist
Added HTTP metadata server configuration fields (enable_http_metadata_server, http_metadata_server_port, http_metadata_server_host) to MasterServiceSupervisorConfig
Resolved merge conflicts with main branch: removed legacy ha_helper files (replaced by new HA backend abstraction), integrated with new shared_ptr-based WrappedMasterService, and preserved new NoF segment methods

Module

Mooncake Store (mooncake-store)

Type of Change

Bug fix
New feature
Refactor
Breaking change
Documentation update
Other

How Has This Been Tested?

Verified code compiles and passes clang-format-20 formatting checks.

Checklist

I have performed a self-review of my own code.
I have formatted my own code using ./scripts/code_format.sh before submitting.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1219 **Author:** [@stmatengss](https://github.com/stmatengss) **Created:** 12/16/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `refactor_metadata_server` --- ### 📝 Commits (10+) - [`b56dbf2`](https://github.com/kvcache-ai/Mooncake/commit/b56dbf2dc995ea71747141951366d133d126a2e6) [Store] Delete useless meta from http metadata server - [`0bc7cce`](https://github.com/kvcache-ai/Mooncake/commit/0bc7cce4bba1b54bd6c009da22deb7341037e4e7) update - [`3a42c5b`](https://github.com/kvcache-ai/Mooncake/commit/3a42c5b8220c66e2c0daa12726bef367c490ab23) update - [`158bc76`](https://github.com/kvcache-ai/Mooncake/commit/158bc763a76dae9224a0c508083a0d9d86c6a6e6) Merge branch 'main' into refactor_metadata_server - [`cddaafc`](https://github.com/kvcache-ai/Mooncake/commit/cddaafce459b470aa4b66d00f73442fe757e1f86) update - [`2a2b0a2`](https://github.com/kvcache-ai/Mooncake/commit/2a2b0a25a4f8626181575a6a69b3feb91deabc83) Merge branch 'main' into refactor_metadata_server - [`cea4970`](https://github.com/kvcache-ai/Mooncake/commit/cea4970142921a47b66651ca83894794f395abab) Merge branch 'main' into refactor_metadata_server - [`ce80efa`](https://github.com/kvcache-ai/Mooncake/commit/ce80efaa5a147efe9b8aafc3369f9aeea8c80b5a) [Store] Optimize HTTP metadata server health checks (#1484) - [`283ccd7`](https://github.com/kvcache-ai/Mooncake/commit/283ccd73bd31801447b2ad92b40cf32e9ec4c69c) [Store] Format code with clang-format-20 (#1489) - [`abb53d4`](https://github.com/kvcache-ai/Mooncake/commit/abb53d4e7b757bc569c43f30d23c53d1a20c763a) [Store] Remove trailing whitespace in rpc_service.cpp (#1490) ### 📊 Changes **6 files changed** (+170 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/include/http_metadata_server.h` (+21 -0) 📝 `mooncake-store/include/master_config.h` (+10 -0) 📝 `mooncake-store/include/rpc_service.h` (+2 -0) 📝 `mooncake-store/src/http_metadata_server.cpp` (+107 -0) 📝 `mooncake-store/src/master.cpp` (+19 -40) 📝 `mooncake-store/src/rpc_service.cpp` (+11 -0) </details> ### 📄 Description ## Description Adds periodic health monitoring to the HTTP metadata server to automatically clean up stale segment metadata. The HTTP metadata server is initialized after the `WrappedMasterService` is created, allowing it to query segment status and remove metadata for segments that no longer exist. **Key changes:** - Added `GetAllSegments()` method to `WrappedMasterService` to expose segment information for health checks - Moved HTTP metadata server initialization to after `WrappedMasterService` creation in the non-HA path, passing the `shared_ptr<WrappedMasterService>` directly for health monitoring - Implemented a health monitoring thread in `HttpMetadataServer` that periodically (every 10 minutes) checks segments and cleans up metadata for segments that no longer exist - Added HTTP metadata server configuration fields (`enable_http_metadata_server`, `http_metadata_server_port`, `http_metadata_server_host`) to `MasterServiceSupervisorConfig` - Resolved merge conflicts with main branch: removed legacy `ha_helper` files (replaced by new HA backend abstraction), integrated with new `shared_ptr`-based `WrappedMasterService`, and preserved new NoF segment methods ## Module - [x] Mooncake Store (`mooncake-store`) ## Type of Change - [ ] Bug fix - [x] New feature - [ ] Refactor - [ ] Breaking change - [ ] Documentation update - [ ] Other ## How Has This Been Tested? Verified code compiles and passes `clang-format-20` formatting checks. ## Checklist - [x] I have performed a self-review of my own code. - [x] I have formatted my own code using `./scripts/code_format.sh` before submitting. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:32:39 +00:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

te-coro

staryxchen-tent-capability-research

feature/musa-ep-jit

zxpdemonio/fix-tent-bootstrap-admission

add-store-rs-tone-tests

scatter-rdma-completion-pr2

P2P-Mooncake-Store

release/v0.3.14

feat/tent-rdma-adaptive-adapter

fix/ep-local-counter-gpu-scope

codex/kvcs-oplog-eviction

give-me-a-star

cruz/mooncake-kvcs-lowlevel-pr1-20261008

ylt-handshake-limits

ci/rocm-e2e-tent

sima/docs-pypi-downloads

fix-ci/hicache-mooncake-metadata-loopback

sima/cuda-driver-loading

sima/ci-performance-gate

fix/tent-rdma-unknown-topology-rail-pairing

ci/tent-e2e-dual-job

mc-patch-1

codex/p2p-merge-prerequisites

sima/store-hca-numa-placement

codex/p2p-merge-cli

codex/p2p-merge-ipv6

copilot/fix-ctests-job-failure

czh/pg-device-collectives-pr6

dependabot/cargo/mooncake-store-rs/pyo3-0.29.0

czh/pg-device-collectives-pr5

codex/segment-pool-master-cutover

sima/nightly-ci-recovery

ci/tent-params

stmatengss-patch-1

dependabot/cargo/mooncake-store-rs/rand-0.8.8

dependabot/cargo/mooncake-store-rs/opentelemetry_sdk-0.32.1

dependabot/cargo/mooncake-store-rs/xxhash-rust-0.8.16

codex/migrate-store-rest-service

fix/tone-wheel-arch-selection

czh/pg-device-collectives-pr4

czh/pg-device-collectives-pr3

ketong/fix_moe_tc

copilot/fix-test-wheel-ubuntu-job

fix/ci-wheel-torch-pg-pin

codex/migrate-structured-object-storage

codex/migrate-allocator-python

codex/migrate-vllm-python

codex/migrate-shared-segment

ci/fix_sgl_eval_install

codex/segment-pool-nof-placement-cleanup

feat/pip-native-release

copilot/bugfix-ha-standby-promotion

copilot/mooncake-store-transport-settings

copilot/fix-tensor-support-issues

copilot/optimize-rl-direction

copilot/mooncake-storeagentic-workflow

copilot/fix-client-reconnect-timeout

copilot/mooncake-error-debugging

copilot/mooncake-ipv6-support

feat/nccl-host-python-api

dependabot/go_modules/mooncake-p2p-store/src/p2pstore/google.golang.org/grpc-1.82.1

copilot/migrate-and-move-operations

copilot/migrate-and-move-operations-again

refactor/centralize-env-vars

idhanani/mooncake-retain-groups

copilot/codeownerreviewer

copilot/give-feedback-on-issue-2123

copilot/create-issue-rfc

copilot/break-cuda-monopoly-logic

copilot/compare-cudamemcpy-cu12-cu13

copilot/report-ci-error-issue

copilot/research-commit-history-analysis

copilot/explain-mooncake-store-service

copilot/analyze-project-functionality

copilot/sub-pr-1680

copilot/review-pr-1680

copilot/sub-pr-1597

copilot/fix-github-actions-job-failure

copilot/move-test-sglang-integration-job

v0.3.14

v0.3.14-pre-4

v0.3.14-pre-3

v0.3.14-pre-2

v0.3.14-pre

v0.3.14-rc1

v0.3.13.post1

v0.3.13-rc2

v0.3.13-rc1

v0.3.13

v0.3.12.post1

v0.3.12

v0.3.11-rc1

v0.3.11.post1

v0.3.11

v0.3.10.post2

v0.3.10.post1

v0.3.10

v0.3.9

v0.3.8.post1

v0.3.8

v0.3.7.post2

v0.3.7.post1

v0.3.7

v0.3.6.post1

v0.3.6

v0.3.5

v0.3.4.post2

v0.3.4.post1

v0.3.4

v0.3.3.post2

v0.3.3.post1

v0.3.3

v0.3.2.post1

v0.3.2

v0.3.1

v0.3.0

v0.3.0-beta

v0.3.0-alpha

v0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2083

Reference in a new issue

Repository

kvcache-ai/Mooncake

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns