[PR #1233] [MERGED] [Store] Decouple master from transfer_engine dependencies

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2091

bsakaguchi commented

2026-10-29 21:32:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1233
Author: @00fish0
Created: 12/18/2025
Status: ✅ Merged
Merged: 12/22/2025
Merged by: @stmatengss

Base: main ← Head: fix/decouple-master-transfer-engine-deps

📝 Commits (2)

a06008e [Store] Decouple master from transfer_engine dependencies
54242f5 Update mooncake-store/src/CMakeLists.txt

📊 Changes

3 files changed (+24 additions, -5 deletions)

View changed files

📝 mooncake-store/src/CMakeLists.txt (+15 -4)
📝 mooncake-store/tests/CMakeLists.txt (+3 -1)
📝 mooncake-store/tests/e2e/CMakeLists.txt (+6 -0)

📄 Description

Description

Fixes #992

Change transfer_engine linkage from PUBLIC to PRIVATE in mooncake_store library to prevent propagating its dependencies (e.g., Ascend, CUDA) to targets that don't need it. The master service only handles metadata management and doesn't perform data transfers, so it shouldn't require transfer engine dependencies.

Changes:

Set transfer_engine as PRIVATE dependency in mooncake_store
Explicitly link transfer_engine for mooncake_client binary
Add transfer_engine to all test targets that use client functionality
Add transfer_engine to e2e test targets

Benefits:

Reduces master binary size
Eliminates unnecessary Ascend/CUDA dependencies for master

Type of Change

Types
- Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1233 **Author:** [@00fish0](https://github.com/00fish0) **Created:** 12/18/2025 **Status:** ✅ Merged **Merged:** 12/22/2025 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `fix/decouple-master-transfer-engine-deps` --- ### 📝 Commits (2) - [`a06008e`](https://github.com/kvcache-ai/Mooncake/commit/a06008e77a9dbf36dd4fc2cff657c39504914277) [Store] Decouple master from transfer_engine dependencies - [`54242f5`](https://github.com/kvcache-ai/Mooncake/commit/54242f5fd50da3b11672232dd866fdfd9e4759d8) Update mooncake-store/src/CMakeLists.txt ### 📊 Changes **3 files changed** (+24 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-store/src/CMakeLists.txt` (+15 -4) 📝 `mooncake-store/tests/CMakeLists.txt` (+3 -1) 📝 `mooncake-store/tests/e2e/CMakeLists.txt` (+6 -0) </details> ### 📄 Description ## Description Fixes #992 Change transfer_engine linkage from PUBLIC to PRIVATE in mooncake_store library to prevent propagating its dependencies (e.g., Ascend, CUDA) to targets that don't need it. The master service only handles metadata management and doesn't perform data transfers, so it shouldn't require transfer engine dependencies. Changes: - Set transfer_engine as PRIVATE dependency in mooncake_store - Explicitly link transfer_engine for mooncake_client binary - Add transfer_engine to all test targets that use client functionality - Add transfer_engine to e2e test targets Benefits: - Reduces master binary size - Eliminates unnecessary Ascend/CUDA dependencies for master ## Type of Change * Types - [x] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested? ## Checklist - [x] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1233] [MERGED] [Store] Decouple master from transfer_engine dependencies #2091