[PR #1235] [CLOSED] Warning fix 1218

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2093

bsakaguchi commented

2026-10-29 21:32:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1235
Author: @JasonZhang517
Created: 12/18/2025
Status: ❌ Closed

Base: main ← Head: warning_fix_1218

📝 Commits (2)

d2ea3de matched pybind11 type in RpcCommunicator, fixed compile warnings
277f9c6 update pybind11 namespace

📊 Changes

3 files changed (+20 additions, -18 deletions)

View changed files

📝 mooncake-transfer-engine/include/transport/rpc_communicator/rpc_communicator.h (+1 -1)
📝 mooncake-transfer-engine/src/transport/rpc_communicator/rpc_communicator.cpp (+18 -16)
📝 mooncake-transfer-engine/src/transport/rpc_communicator/rpc_interface.cpp (+1 -1)

📄 Description

Description

Now in the CI process there is a warning about rpc_communicator, fixed the visibility issues.
update the pybind11 namespace to py.

Type of Change

Types
- [ x ] Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1235 **Author:** [@JasonZhang517](https://github.com/JasonZhang517) **Created:** 12/18/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `warning_fix_1218` --- ### 📝 Commits (2) - [`d2ea3de`](https://github.com/kvcache-ai/Mooncake/commit/d2ea3de20d6c592733c926bdcedc520c6a5c87c5) matched pybind11 type in RpcCommunicator, fixed compile warnings - [`277f9c6`](https://github.com/kvcache-ai/Mooncake/commit/277f9c6d8c477acf6e733d9666c206172aae7039) update pybind11 namespace ### 📊 Changes **3 files changed** (+20 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/include/transport/rpc_communicator/rpc_communicator.h` (+1 -1) 📝 `mooncake-transfer-engine/src/transport/rpc_communicator/rpc_communicator.cpp` (+18 -16) 📝 `mooncake-transfer-engine/src/transport/rpc_communicator/rpc_interface.cpp` (+1 -1) </details> ### 📄 Description ## Description 1. Now in the CI process there is a warning about rpc_communicator, fixed the visibility issues. 2. update the pybind11 namespace to py.  ## Type of Change * Types - [ x ] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested?  ## Checklist - [ ] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1235] [CLOSED] Warning fix 1218 #2093