[PR #1250] [CLOSED] [TE] Refactor TransferEngine into Impl + forwarding wrapper

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kvcache-ai/Mooncake#2106

bsakaguchi commented

2026-10-29 21:32:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1250
Author: @alogfans
Created: 12/22/2025
Status: ❌ Closed

Base: main ← Head: seperate-te-api-with-impl

📝 Commits (3)

46362a5 [TE] Refactor TransferEngine into Impl + forwarding wrapper
b12ac23 Merge branch 'main' into seperate-te-api-with-impl
09e6c9f Revert merge

📊 Changes

5 files changed (+1035 additions, -951 deletions)

View changed files

📝 mooncake-transfer-engine/include/transfer_engine.h (+43 -270)
➕ mooncake-transfer-engine/include/transfer_engine_impl.h (+272 -0)
📝 mooncake-transfer-engine/include/transport/transport.h (+1 -0)
📝 mooncake-transfer-engine/src/transfer_engine.cpp (+97 -681)
➕ mooncake-transfer-engine/src/transfer_engine_impl.cpp (+622 -0)

📄 Description

Description

Separate interface and implementation of Mooncake TE, therefore TENT has better backward compatibility.

Type of Change

Types
- Bug fix
- New feature
  - Transfer Engine
  - Mooncake Store
  - Mooncake EP
  - Integration
  - P2P Store
  - Python Wheel
- Breaking change
- CI/CD
- Documentation update
- Other

How Has This Been Tested?

Checklist

I have performed a self-review of my own code.
I have updated the documentation.
I have added tests to prove my changes are effective.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1250 **Author:** [@alogfans](https://github.com/alogfans) **Created:** 12/22/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `seperate-te-api-with-impl` --- ### 📝 Commits (3) - [`46362a5`](https://github.com/kvcache-ai/Mooncake/commit/46362a52ce469b1ba8005e06f93273446353a4e7) [TE] Refactor TransferEngine into Impl + forwarding wrapper - [`b12ac23`](https://github.com/kvcache-ai/Mooncake/commit/b12ac23aaa8a4bbb9eeed0c19f1923b05b19b826) Merge branch 'main' into seperate-te-api-with-impl - [`09e6c9f`](https://github.com/kvcache-ai/Mooncake/commit/09e6c9f98e0214ef555c295bd24400d86dad53a9) Revert merge ### 📊 Changes **5 files changed** (+1035 additions, -951 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/include/transfer_engine.h` (+43 -270) ➕ `mooncake-transfer-engine/include/transfer_engine_impl.h` (+272 -0) 📝 `mooncake-transfer-engine/include/transport/transport.h` (+1 -0) 📝 `mooncake-transfer-engine/src/transfer_engine.cpp` (+97 -681) ➕ `mooncake-transfer-engine/src/transfer_engine_impl.cpp` (+622 -0) </details> ### 📄 Description ## Description Separate interface and implementation of Mooncake TE, therefore TENT has better backward compatibility. ## Type of Change * Types - [ ] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested?  ## Checklist - [ ] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1250] [CLOSED] [TE] Refactor TransferEngine into Impl + forwarding wrapper #2106