[PR #1272] [MERGED] [store] add error checking for get_tensor_into #2124

Closed
opened 2026-10-29 21:32:57 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1272
Author: @zxpdemonio
Created: 12/24/2025
Status: ✅ Merged
Merged: 12/29/2025
Merged by: @stmatengss

Base: main ← Head: cruz/fix_get_tensor_into


📝 Commits (4)

  • 6118a51 [store] add error checking for get_tensor_into
  • 4242029 check whether total_length is bigger than metadata size
  • f0a1664 fix build error and warning
  • 3cae37f empty commit

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 mooncake-integration/store/store_py.cpp (+11 -2)

📄 Description

Description

Type of Change

  • Types
    • Bug fix
    • New feature
      • Transfer Engine
      • Mooncake Store
      • Mooncake EP
      • Integration
      • P2P Store
      • Python Wheel
    • Breaking change
    • CI/CD
    • Documentation update
    • Other

How Has This Been Tested?

Checklist

  • I have performed a self-review of my own code.
  • I have updated the documentation.
  • I have added tests to prove my changes are effective.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1272 **Author:** [@zxpdemonio](https://github.com/zxpdemonio) **Created:** 12/24/2025 **Status:** ✅ Merged **Merged:** 12/29/2025 **Merged by:** [@stmatengss](https://github.com/stmatengss) **Base:** `main` ← **Head:** `cruz/fix_get_tensor_into` --- ### 📝 Commits (4) - [`6118a51`](https://github.com/kvcache-ai/Mooncake/commit/6118a51a3c39dc6a0a235c7add17797c652629f1) [store] add error checking for get_tensor_into - [`4242029`](https://github.com/kvcache-ai/Mooncake/commit/4242029d2b4ee5b37de27cbb966d0cbdb1e13c9f) check whether total_length is bigger than metadata size - [`f0a1664`](https://github.com/kvcache-ai/Mooncake/commit/f0a1664717f514a6ca9f69d2d7116d2e7754f03f) fix build error and warning - [`3cae37f`](https://github.com/kvcache-ai/Mooncake/commit/3cae37f742d2cd0f365ca654f34475d94093c189) empty commit ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-integration/store/store_py.cpp` (+11 -2) </details> ### 📄 Description ## Description <!-- A clear and concise description of the changes. Link to any relevant issues. --> ## Type of Change * Types - [ ] Bug fix - [ ] New feature - [ ] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested? <!-- Please describe the tests you've run to verify your changes. --> ## Checklist - [ ] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-29 21:32:57 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kvcache-ai/Mooncake#2124
No description provided.