[PR #1282] [MERGED] Update yalantinglibs dependency to use direct archive download #2130

Closed
opened 2026-10-29 21:33:02 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1282
Author: @Copilot
Created: 12/25/2025
Status: ✅ Merged
Merged: 12/29/2025
Merged by: @alogfans

Base: main ← Head: copilot/add-yalanting-dependency


📝 Commits (3)

  • 76f46b9 Initial plan
  • 7b396cc Update dependencies.sh to download yalantinglibs from release archive
  • 3093470 Refactor yalantinglibs version as configurable variable

📊 Changes

1 file changed (+20 additions, -13 deletions)

View changed files

📝 dependencies.sh (+20 -13)

📄 Description

Description

Replace git clone with direct ZIP download for yalantinglibs v0.5.6 from GitHub releases. Reduces installation time and eliminates git dependency for this step.

Changes:

  • Download from https://github.com/alibaba/yalantinglibs/archive/refs/tags/0.5.6.zip instead of cloning repository
  • Add unzip to system packages
  • Extract YALANTINGLIBS_VERSION to configuration variable for maintainability
  • Remove git checkout step (no longer needed)

Type of Change

  • Types
    • Bug fix
    • New feature
      • Transfer Engine
      • Mooncake Store
      • Mooncake EP
      • Integration
      • P2P Store
      • Python Wheel
    • Breaking change
    • CI/CD
    • Documentation update
    • Other

How Has This Been Tested?

  • Verified bash syntax with bash -n dependencies.sh
  • Validated download URL accessibility with wget --spider
  • Confirmed ZIP extraction produces correct directory structure (yalantinglibs-0.5.6)

Checklist

  • I have performed a self-review of my own code.
  • I have updated the documentation.
  • I have added tests to prove my changes are effective.
Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature Request]: Yalanting Dependency</issue_title>
<issue_description>### Describe your feature request

For dependencies.sh, direct download yalantinglibs from https://github.com/alibaba/yalantinglibs/archive/refs/tags/0.5.6.zip, and install it

Before submitting a new issue...

  • Make sure you already searched for relevant issues and read the documentation</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1282 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 12/25/2025 **Status:** ✅ Merged **Merged:** 12/29/2025 **Merged by:** [@alogfans](https://github.com/alogfans) **Base:** `main` ← **Head:** `copilot/add-yalanting-dependency` --- ### 📝 Commits (3) - [`76f46b9`](https://github.com/kvcache-ai/Mooncake/commit/76f46b9f758f4359cc666d46a178d47946f7bc93) Initial plan - [`7b396cc`](https://github.com/kvcache-ai/Mooncake/commit/7b396cceb2511c610ce76502ee753d0472fd42de) Update dependencies.sh to download yalantinglibs from release archive - [`3093470`](https://github.com/kvcache-ai/Mooncake/commit/3093470f5d198f3bc636641f8fd77fd0932df0aa) Refactor yalantinglibs version as configurable variable ### 📊 Changes **1 file changed** (+20 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `dependencies.sh` (+20 -13) </details> ### 📄 Description ## Description Replace git clone with direct ZIP download for yalantinglibs v0.5.6 from GitHub releases. Reduces installation time and eliminates git dependency for this step. **Changes:** - Download from `https://github.com/alibaba/yalantinglibs/archive/refs/tags/0.5.6.zip` instead of cloning repository - Add `unzip` to system packages - Extract YALANTINGLIBS_VERSION to configuration variable for maintainability - Remove git checkout step (no longer needed) ## Type of Change * Types - [ ] Bug fix - [x] New feature - [x] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [x] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested? - Verified bash syntax with `bash -n dependencies.sh` - Validated download URL accessibility with `wget --spider` - Confirmed ZIP extraction produces correct directory structure (`yalantinglibs-0.5.6`) ## Checklist - [x] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[Feature Request]: Yalanting Dependency</issue_title> > <issue_description>### Describe your feature request > > For dependencies.sh, direct download yalantinglibs from `https://github.com/alibaba/yalantinglibs/archive/refs/tags/0.5.6.zip`, and install it > > ### Before submitting a new issue... > > - [ ] Make sure you already searched for relevant issues and read the [documentation](https://kvcache-ai.github.io/Mooncake/)</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes kvcache-ai/Mooncake#1281 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/kvcache-ai/Mooncake/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-29 21:33:02 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kvcache-ai/Mooncake#2130
No description provided.