[PR #1317] [CLOSED] feat: Add Python package version verification #2157

New issue

Closed

opened 2026-10-29 21:33:12 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 21:33:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1317
Author: @LiYiMing-lg
Created: 1/1/2026
Status: ❌ Closed

Base: main ← Head: fix/979-version-verification-clean

📝 Commits (10+)

b00e7f3 feat: add Python package version verification - Implement version mismatch prevention - Validate client-master version compatibility - Closes #979
96c0811 refactor: implement single source of truth for versioning - Add packaging library for semantic version parsing - Dynamic version reading in setup.py from init.py - Improved version compatibility check (major version match) - Ensure English documentation consistency
2912f1c refactor: implement single source of truth for versioning - Add packaging library for semantic version parsing - Dynamic version reading in setup.py from init.py - Improved version compatibility check (major version match) - Ensure English documentation consistency
722d2e2 resolve all merge conflicts - implement version verification
1048893 Merge branch 'main' into fix/979-version-verification-clean
3af064e fix: implement semantic version compatibility check - Use packaging.version.parse for version comparison - Compare major versions only - Add fallback to exact match on parsing errors
98373ad Merge branch 'fix/979-version-verification-clean' of https://github.com/LiYiMing-lg/Mooncake into fix/979-version-verification-clean
e979a26 fix: add graceful fallback when torch is not available - Build non-CUDA version if torch import fails - Improve CI compatibility
a2382f5 fix: make packaging dependency optional - Use lazy import in check_version_compatibility - Add version-check extra dependency
f708230 fix: clean setup.py - remove CUDA logic, keep only version verification

📊 Changes

3 files changed (+80 additions, -0 deletions)

View changed files

📝 mooncake-wheel/mooncake/__init__.py (+39 -0)
📝 mooncake-wheel/mooncake/mooncake_config.py (+13 -0)
📝 mooncake-wheel/setup.py (+28 -0)

📄 Description

Description

Implementation of Python package version verification mechanism as requested in #979.

Changes

Added version verification between mooncake client and master
Prevent invalid RPC arg errors from version mismatches
Ensure matching package versions before establishing connections

Closes #979

Checklist

Version verification mechanism implemented
Prevents version mismatch errors
Clean implementation (no mixed modifications)

Notes

Clean re-submission focusing only on #979 requirements.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1317 **Author:** [@LiYiMing-lg](https://github.com/LiYiMing-lg) **Created:** 1/1/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/979-version-verification-clean` --- ### 📝 Commits (10+) - [`b00e7f3`](https://github.com/kvcache-ai/Mooncake/commit/b00e7f3d29ad5233c5a07dad88444be59a36dab7) feat: add Python package version verification - Implement version mismatch prevention - Validate client-master version compatibility - Closes #979 - [`96c0811`](https://github.com/kvcache-ai/Mooncake/commit/96c08119bb4b2191a0e046af929bc43739a462ca) refactor: implement single source of truth for versioning - Add packaging library for semantic version parsing - Dynamic version reading in setup.py from __init__.py - Improved version compatibility check (major version match) - Ensure English documentation consistency - [`2912f1c`](https://github.com/kvcache-ai/Mooncake/commit/2912f1c72c177a09c4c3d328f7152f8da772e123) refactor: implement single source of truth for versioning - Add packaging library for semantic version parsing - Dynamic version reading in setup.py from __init__.py - Improved version compatibility check (major version match) - Ensure English documentation consistency - [`722d2e2`](https://github.com/kvcache-ai/Mooncake/commit/722d2e27f348ba645ecf9fe4600c0087fc6dc258) resolve all merge conflicts - implement version verification - [`1048893`](https://github.com/kvcache-ai/Mooncake/commit/104889388221befc8a95df318edd88450d78acdc) Merge branch 'main' into fix/979-version-verification-clean - [`3af064e`](https://github.com/kvcache-ai/Mooncake/commit/3af064e70175d2cf2168271d5fb497bd15ecb500) fix: implement semantic version compatibility check - Use packaging.version.parse for version comparison - Compare major versions only - Add fallback to exact match on parsing errors - [`98373ad`](https://github.com/kvcache-ai/Mooncake/commit/98373adc7abf390cd73fc57a549c07f3e728294a) Merge branch 'fix/979-version-verification-clean' of https://github.com/LiYiMing-lg/Mooncake into fix/979-version-verification-clean - [`e979a26`](https://github.com/kvcache-ai/Mooncake/commit/e979a269194e7644d8cef397d12f5d25be137db1) fix: add graceful fallback when torch is not available - Build non-CUDA version if torch import fails - Improve CI compatibility - [`a2382f5`](https://github.com/kvcache-ai/Mooncake/commit/a2382f5c99daf6023e94c16caf95a850b3432e9c) fix: make packaging dependency optional - Use lazy import in check_version_compatibility - Add version-check extra dependency - [`f708230`](https://github.com/kvcache-ai/Mooncake/commit/f7082302c467bc76dd9245c404dcfba10defb435) fix: clean setup.py - remove CUDA logic, keep only version verification ### 📊 Changes **3 files changed** (+80 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-wheel/mooncake/__init__.py` (+39 -0) 📝 `mooncake-wheel/mooncake/mooncake_config.py` (+13 -0) 📝 `mooncake-wheel/setup.py` (+28 -0) </details> ### 📄 Description ## Description Implementation of Python package version verification mechanism as requested in #979. ## Changes - Added version verification between mooncake client and master - Prevent invalid RPC arg errors from version mismatches - Ensure matching package versions before establishing connections ## Related Issues Closes #979 ## Checklist - Version verification mechanism implemented - Prevents version mismatch errors - Clean implementation (no mixed modifications) ## Notes Clean re-submission focusing only on #979 requirements. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 21:33:12 +00:00