[PR #1342] [MERGED] [TE] Revert nvlink_transport.cpp to previous version #2176

Closed
opened 2026-10-29 21:33:21 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/Mooncake/pull/1342
Author: @TTThanos
Created: 1/8/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @alogfans

Base: main ← Head: Feature/restore_nvlinkTransport


📝 Commits (1)

  • f81397b [TE] Revert nvlink_transport.cpp to previous version

📊 Changes

1 file changed (+3 additions, -53 deletions)

View changed files

📝 mooncake-transfer-engine/src/transport/nvlink_transport/nvlink_transport.cpp (+3 -53)

📄 Description

Description

Type of Change

  • Types
    • Bug fix
    • New feature
      • Transfer Engine
      • Mooncake Store
      • Mooncake EP
      • Integration
      • P2P Store
      • Python Wheel
    • Breaking change
    • CI/CD
    • Documentation update
    • Other

How Has This Been Tested?

To exclude the possibily of previous change leading to GB200 nvlink problem, we revert the nvlink_transport.cpp to old one w/o detect_Memory() method and fallback mechanism.

Checklist

  • I have performed a self-review of my own code.
  • I have updated the documentation.
  • I have added tests to prove my changes are effective.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/Mooncake/pull/1342 **Author:** [@TTThanos](https://github.com/TTThanos) **Created:** 1/8/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@alogfans](https://github.com/alogfans) **Base:** `main` ← **Head:** `Feature/restore_nvlinkTransport` --- ### 📝 Commits (1) - [`f81397b`](https://github.com/kvcache-ai/Mooncake/commit/f81397ba160d455d6e97c479e82a43a2b0fd98c4) [TE] Revert nvlink_transport.cpp to previous version ### 📊 Changes **1 file changed** (+3 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `mooncake-transfer-engine/src/transport/nvlink_transport/nvlink_transport.cpp` (+3 -53) </details> ### 📄 Description ## Description <!-- A clear and concise description of the changes. Link to any relevant issues. --> ## Type of Change * Types - [x] Bug fix - [ ] New feature - [x] Transfer Engine - [ ] Mooncake Store - [ ] Mooncake EP - [ ] Integration - [ ] P2P Store - [ ] Python Wheel - [ ] Breaking change - [ ] CI/CD - [ ] Documentation update - [ ] Other ## How Has This Been Tested? To exclude the possibily of previous change leading to GB200 nvlink problem, we revert the nvlink_transport.cpp to old one w/o detect_Memory() method and fallback mechanism. ## Checklist - [ ] I have performed a self-review of my own code. - [ ] I have updated the documentation. - [ ] I have added tests to prove my changes are effective. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-29 21:33:21 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kvcache-ai/Mooncake#2176
No description provided.