[GH-ISSUE #770] [Question] Should we send notify until data is transfered? #240

Closed
opened 2026-10-29 21:11:23 +00:00 by bsakaguchi · 1 comment
Owner

Originally created by @orrorcol on GitHub (Aug 21, 2025).
Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/770

https://github.com/kvcache-ai/Mooncake/blame/fb26af7613d4251c9c006c9ff7eef5ff4e18ed65/mooncake-transfer-engine/src/transfer_engine_c.cpp#L143-L156

I think submitTransferWithNotify should be used here.

Originally created by @orrorcol on GitHub (Aug 21, 2025). Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/770 https://github.com/kvcache-ai/Mooncake/blame/fb26af7613d4251c9c006c9ff7eef5ff4e18ed65/mooncake-transfer-engine/src/transfer_engine_c.cpp#L143-L156 I think `submitTransferWithNotify` should be used here.
bsakaguchi 2026-10-29 21:11:23 +00:00
  • closed this issue
  • added the
    question
    label
Author
Owner

@alogfans commented on GitHub (Aug 25, 2025):

The current version has already fixed it -- a submitTransferWithNotify call only add one to-do record, and the message will be sent only after completing a transfer task. github.com/kvcache-ai/Mooncake@9acf12080f/mooncake-transfer-engine/include/transfer_engine.h (L127-L141)

<!-- gh-comment-id:3218583416 --> @alogfans commented on GitHub (Aug 25, 2025): The current version has already fixed it -- a submitTransferWithNotify call only add one to-do record, and the message will be sent only after completing a transfer task. https://github.com/kvcache-ai/Mooncake/blob/9acf12080f0bf8efdef52321423ba3e4b192c998/mooncake-transfer-engine/include/transfer_engine.h#L127-L141
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kvcache-ai/Mooncake#240
No description provided.