mirror of
https://github.com/kvcache-ai/Mooncake.git
synced 2026-11-05 01:17:55 +00:00
[GH-ISSUE #770] [Question] Should we send notify until data is transfered? #240
Labels
No labels
ascend
auto-closed
bug
bug
CI/Build
Common
documentation
enhancement
feature request
good first issue
help wanted
high priority
MetaX
nightly-failure
pull-request
PyTorch Backend
question
RFC
Roadmap
stale
Store
Tests
Transfer Engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
kvcache-ai/Mooncake#240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @orrorcol on GitHub (Aug 21, 2025).
Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/770
https://github.com/kvcache-ai/Mooncake/blame/fb26af7613d4251c9c006c9ff7eef5ff4e18ed65/mooncake-transfer-engine/src/transfer_engine_c.cpp#L143-L156
I think
submitTransferWithNotifyshould be used here.@alogfans commented on GitHub (Aug 25, 2025):
The current version has already fixed it -- a submitTransferWithNotify call only add one to-do record, and the message will be sent only after completing a transfer task.
github.com/kvcache-ai/Mooncake@9acf12080f/mooncake-transfer-engine/include/transfer_engine.h (L127-L141)