[GH-ISSUE #3115] [CODEOWNERS] No entry for mooncake-p2p-store #799

New issue

Open

opened 2026-10-29 21:19:41 +00:00 by bsakaguchi · 3 comments

bsakaguchi commented

2026-10-29 21:19:41 +00:00

Owner

Originally created by @jfeng18 on GitHub (Jul 25, 2026).
Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/3115

Description

.github/CODEOWNERS currently has no entry for mooncake-p2p-store/, so PRs touching only that directory get no reviewer auto-assigned and can sit unnoticed.

Example: #2375 (Go bugfix, only touches mooncake-p2p-store/) has been open since Jun 8 with green CI but never had a reviewer requested — every other directory in that PR-batch got auto-assignment via CODEOWNERS.

Suggestion

Add an entry such as:

/mooncake-p2p-store <owners>

Leaving the owner choice to the maintainers — happy to send the one-line PR once owners are decided.

Originally created by @jfeng18 on GitHub (Jul 25, 2026). Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/3115 ## Description `.github/CODEOWNERS` currently has no entry for `mooncake-p2p-store/`, so PRs touching only that directory get no reviewer auto-assigned and can sit unnoticed. Example: #2375 (Go bugfix, only touches `mooncake-p2p-store/`) has been open since Jun 8 with green CI but never had a reviewer requested — every other directory in that PR-batch got auto-assignment via CODEOWNERS. ## Suggestion Add an entry such as: ``` /mooncake-p2p-store <owners> ``` Leaving the owner choice to the maintainers — happy to send the one-line PR once owners are decided.

bsakaguchi commented

2026-10-29 21:19:41 +00:00

Author

Owner

@github-actions[bot] commented on GitHub (Jul 25, 2026):

Thanks for opening this issue, @jfeng18!

Field	Value
Issue	#3115
GitHub user ID	`288662032`
Reporter	@jfeng18

A maintainer will triage this when possible. To help us respond faster, please include:

Mooncake version or commit SHA
Environment (OS, CUDA/driver, RDMA stack if relevant)
Steps to reproduce and expected vs. actual behavior

Useful links: Documentation · Contributing guide

This message was posted automatically by the issue bot.

@github-actions[bot] commented on GitHub (Jul 25, 2026): Thanks for opening this issue, @jfeng18! | Field | Value | |-------|-------| | **Issue** | #3115 | | **GitHub user ID** | `288662032` | | **Reporter** | @jfeng18 | A maintainer will triage this when possible. To help us respond faster, please include: - Mooncake version or commit SHA - Environment (OS, CUDA/driver, RDMA stack if relevant) - Steps to reproduce and expected vs. actual behavior Useful links: [Documentation](https://kvcache-ai.github.io/Mooncake/) · [Contributing guide](https://github.com/kvcache-ai/Mooncake/blob/main/CONTRIBUTING.md) > This message was posted automatically by the issue bot.

bsakaguchi commented

2026-10-29 21:19:42 +00:00

Author

Owner

@jfeng18 commented on GitHub (Jul 28, 2026):

@ykwd since you just merged #2375 (the p2p-store PR that surfaced this gap) — would you or someone you designate be the right CODEOWNERS entry for /mooncake-p2p-store? I'll send the one-line PR once decided.

@jfeng18 commented on GitHub (Jul 28, 2026): @ykwd since you just merged #2375 (the p2p-store PR that surfaced this gap) — would you or someone you designate be the right CODEOWNERS entry for /mooncake-p2p-store? I'll send the one-line PR once decided.

bsakaguchi commented

2026-10-29 21:19:42 +00:00

Author

Owner

@jfeng18 commented on GitHub (Aug 21, 2026):

Adding a second data point: #2319 (monitoring/grafana dashboard expansion, opened Jun 3) sat with zero reviewer assignment for 11 weeks — monitoring/ has no CODEOWNERS entry either — until #2944 independently reimplemented the same dashboard in July. That's now two PRs (#2345→#2942, #2319→#2944) that aged out and got redone because their directories have no owner.

Suggest covering both gaps: /mooncake-p2p-store and /monitoring (the latter is Store-metrics visualization, so the Store owners may be the natural fit).

@jfeng18 commented on GitHub (Aug 21, 2026): Adding a second data point: #2319 (monitoring/grafana dashboard expansion, opened Jun 3) sat with zero reviewer assignment for 11 weeks — `monitoring/` has no CODEOWNERS entry either — until #2944 independently reimplemented the same dashboard in July. That's now two PRs (#2345→#2942, #2319→#2944) that aged out and got redone because their directories have no owner. Suggest covering both gaps: `/mooncake-p2p-store` and `/monitoring` (the latter is Store-metrics visualization, so the Store owners may be the natural fit).

bsakaguchi referenced this issue

2026-10-29 21:30:42 +00:00

[PR #800] [CLOSED] [Store] Zero copy for Mooncake store get_tensor API #1832