mirror of
https://github.com/kvcache-ai/Mooncake.git
synced 2026-11-05 01:17:55 +00:00
[GH-ISSUE #187] The new mooncake pip package do not contains libgrpc++.so.1 #89
Labels
No labels
ascend
auto-closed
bug
bug
CI/Build
Common
documentation
enhancement
feature request
good first issue
help wanted
high priority
MetaX
nightly-failure
pull-request
PyTorch Backend
question
RFC
Roadmap
stale
Store
Tests
Transfer Engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
kvcache-ai/Mooncake#89
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @maobaolong on GitHub (Mar 31, 2025).
Original GitHub issue: https://github.com/kvcache-ai/Mooncake/issues/187
@maobaolong commented on GitHub (Mar 31, 2025):
@xhyf77 Would you like to take a look at this issue?
@ShangmingCai commented on GitHub (Mar 31, 2025):
@maobaolong Yeah, actually we want to remove and replace grpc since it is a bit heavy, which could cause trouble when installing. Since #179 has been merged, I think we don't need grpc anymore. Can you try building from source? We will check whether the pip package has been built correctly tomorrow.
@xhyf77 commented on GitHub (Apr 1, 2025):
Yes, the pip package does not include libgrpc++.so.1. In order to minimize the number of external .so libraries included in the package, we only bundled libetcd-cpp-api.so. The reason for including only libetcd-cpp-api.so is that, based on my tests (on Ubuntu 22.04 LTS), the correct versions of libgrpc.so.x, libgrpc++.so.x, and libprotobuf.so.x can be installed using the provided dependency.sh script. (Reference: https://github.com/kvcache-ai/Mooncake/pull/177#issuecomment-2761236212)
Therefore, we only need to ensure that the compiled libetcd-cpp-api.so correctly locates its dependencies.
One thing I overlooked is that I forgot to add a RUNPATH to mooncake_master, which caused you to have to manually export LD_LIBRARY_PATH. This might need to be fixed, but since we're now planning to remove etcd, it seems there's no longer a need to fix the missing RUNPATH. The newly released packages should no longer depend on libgrpc++.so.1.
@maobaolong commented on GitHub (Apr 1, 2025):
@xhyf77 Thanks for your reply, it is detailed and helped. But the requirement still exist, which is that we have to install
mooncake vllm adapterintovllmcontainer, but i have to copymooncake sourceinto vllm container and it hard to rundependency.shsuccessfully sincevllm container and mooncake dev container are different, I can buildmooncakesuccessfully in themooncake dev container, but cannot build successfully invllm container.So is there a solution to help to make it easy to install
mooncake vllm adapterinto an existing vllm container ?@alogfans commented on GitHub (Apr 10, 2025):
We are preparing to include all referenced dynamic libraries in the whl package. To work around the problem you can install all dependencies by using
bash dependencies.shin prior. See #222 in detail.@alogfans commented on GitHub (Apr 14, 2025):
Our latest distribution of Mooncake Python library has fixed this problem. Close this issue.
@maobaolong commented on GitHub (Apr 14, 2025):
@alogfans Thanks for your help. It make mooncake can be integrated more and more easily.
@maobaolong commented on GitHub (Apr 14, 2025):
Is there something wrong with me? @alogfans
@ShangmingCai commented on GitHub (Apr 14, 2025):
Can you tell me what your os version is? We only support Ubuntu currently.
@maobaolong commented on GitHub (Apr 14, 2025):
I install it within vllm container which is Ubuntu
@ShangmingCai commented on GitHub (Apr 14, 2025):
@xiaguan Can you check whether this is caused by
(requires-python:>=3.10)ormooncake_transfer_engine-0.3.0b3.tar.gz has inconsistent version: expected '0.3.0b3', but metadata has '0.1.0'?@xiaguan commented on GitHub (Apr 14, 2025):
The metadata from the package downloaded and extracted from PyPI just now is as follows:
The metadata appears to be valid and complete.
Could you please share your Python and lib versions?
@maobaolong commented on GitHub (Apr 14, 2025):
@xiaguan Thanks for your help. The following is my env, basically, it is a vllm container, you can verify it from vllm image
@ShangmingCai commented on GitHub (Apr 14, 2025):
Thank you so much. We will test with vllm container tomorrow. We have verified that it fits with the sglang container, but haven't checked it with the vllm container yet. Currently, this is still a beta version for the sglang users, the official 0.3.0 release will definitely work well with both engines.
@xiaguan commented on GitHub (Apr 14, 2025):
After testing, it appears that the issue is related to the Python version—there seem to be some problems with installing version 3.12. The issue will be addressed and resolved tomorrow. Thank you for reporting it.
@maobaolong commented on GitHub (Apr 14, 2025):
@ShangmingCai @xiaguan Admire your efficiency 🫡
@maobaolong commented on GitHub (Apr 16, 2025):
@xiaguan Is there any update?
@xiaguan commented on GitHub (Apr 16, 2025):
fixed this issue in #249 yesterday
We are currently collecting several other patches for the next release. If you need an urgent fix for this issue, you can manually download the available py312 wheel package from: https://github.com/kvcache-ai/Mooncake/actions/runs/14463285244.
@maobaolong commented on GitHub (Apr 16, 2025):
@xiaguan I use ldd to check that all the dependencies are existed.
@xiaguan commented on GitHub (Apr 16, 2025):
@maobaolong https://pypi.org/project/mooncake-transfer-engine/, released new version
@maobaolong commented on GitHub (Apr 16, 2025):
@xiaguan Great job, it works.