From 667030d6e64147c9edf3b78d3cc81ce4d6fe1fc7 Mon Sep 17 00:00:00 2001 From: watamario15 <65015796+watamario15@users.noreply.github.com> Date: Mon, 12 Jan 2026 23:16:19 +0900 Subject: [PATCH] [kt-kernel]: Fix ignored build configurations in `install.sh` and `CMakeLists.txt` (#1789) * Correct variable defaults * Remove CMAKE_BUILD_TYPE setting in CMakeLists --- kt-kernel/CMakeLists.txt | 2 -- kt-kernel/install.sh | 16 ++++++++-------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/kt-kernel/CMakeLists.txt b/kt-kernel/CMakeLists.txt index de0cdb2..c671386 100644 --- a/kt-kernel/CMakeLists.txt +++ b/kt-kernel/CMakeLists.txt @@ -127,10 +127,8 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON) add_compile_definitions(FMT_HEADER_ONLY) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -ffast-math") -set(CMAKE_BUILD_TYPE "Release") # set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -fsanitize=address -fno-omit-frame-pointer") # set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0") -# set(CMAKE_BUILD_TYPE "Debug") set(CMAKE_EXPORT_COMPILE_COMMANDS ON) find_package(OpenMP REQUIRED) message(STATUS "CMAKE_CXX_FLAGS: ${CMAKE_CXX_FLAGS}") diff --git a/kt-kernel/install.sh b/kt-kernel/install.sh index cef4716..2f41b8d 100755 --- a/kt-kernel/install.sh +++ b/kt-kernel/install.sh @@ -384,11 +384,6 @@ build_step() { # Close MANUAL_MODE conditional fi -# Set defaults for optional variables -export CPUINFER_BUILD_TYPE=${CPUINFER_BUILD_TYPE:-Release} -export CPUINFER_PARALLEL=${CPUINFER_PARALLEL:-8} -export CPUINFER_VERBOSE=${CPUINFER_VERBOSE:-1} - echo "==========================================" echo "Building kt-kernel with configuration:" echo "==========================================" @@ -397,11 +392,16 @@ echo " CPUINFER_ENABLE_AMX = $CPUINFER_ENABLE_AMX" echo " CPUINFER_ENABLE_AVX512_VNNI = ${CPUINFER_ENABLE_AVX512_VNNI:-AUTO}" echo " CPUINFER_ENABLE_AVX512_BF16 = ${CPUINFER_ENABLE_AVX512_BF16:-AUTO}" echo " CPUINFER_ENABLE_AVX512_VBMI = ${CPUINFER_ENABLE_AVX512_VBMI:-AUTO}" -echo " CPUINFER_BUILD_TYPE = $CPUINFER_BUILD_TYPE" -echo " CPUINFER_PARALLEL = $CPUINFER_PARALLEL" +echo " CPUINFER_BUILD_TYPE = ${CPUINFER_BUILD_TYPE:-Release}" +echo " CPUINFER_PARALLEL = ${CPUINFER_PARALLEL:-AUTO}" +echo " CPUINFER_VERBOSE = ${CPUINFER_VERBOSE:-1}" echo "" -pip install . -v +if [ ${CPUINFER_VERBOSE:-1} = "0" ]; then + python3 -m pip install . +else + python3 -m pip install . -v +fi } # Subcommand dispatcher: default to "all"