[GH-ISSUE #1939] Leftover cpptrace include? #1203

New issue

Closed

opened 2026-10-29 14:49:53 +00:00 by bsakaguchi · 3 comments

bsakaguchi commented

2026-10-29 14:49:53 +00:00

Owner

Originally created by @DocShotgun on GitHub (Apr 22, 2026).
Original GitHub issue: https://github.com/kvcache-ai/ktransformers/issues/1939

Reminder

I have read the above rules and searched the existing issues.

System Info

9544a8960d

Reproduction

Attempting to build the latest kt-kernel results in:

  /home/docshotgun/ktransformers/kt-kernel/ext_bindings.cpp:15:10: fatal error: cpptrace/cpptrace.hpp: No such file or directory
     15 | #include <cpptrace/cpptrace.hpp>
        |          ^~~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.

A search of the codebase reveals only a single function warmup_cpptrace() in kt-kernel/ext_bindings.cpp that references cpptrace.

The commit description for 9544a8960d mentions a squashed commit with the description * revert CMakeLists.txt to main: remove debug flags and cpptrace dep, so perhaps it's not intended for cpptrace to be required for compilation?

Others

No response

Originally created by @DocShotgun on GitHub (Apr 22, 2026). Original GitHub issue: https://github.com/kvcache-ai/ktransformers/issues/1939 ### Reminder - [x] I have read the above rules and searched the existing issues. ### System Info 9544a8960d4dcc3db6046fc7d2a963b48136f72e ### Reproduction Attempting to build the latest `kt-kernel` results in: ```text /home/docshotgun/ktransformers/kt-kernel/ext_bindings.cpp:15:10: fatal error: cpptrace/cpptrace.hpp: No such file or directory 15 | #include <cpptrace/cpptrace.hpp> | ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. ``` A search of the codebase reveals only a single function `warmup_cpptrace()` in `kt-kernel/ext_bindings.cpp` that references `cpptrace`. The commit description for 9544a8960d4dcc3db6046fc7d2a963b48136f72e mentions a squashed commit with the description `* revert CMakeLists.txt to main: remove debug flags and cpptrace dep`, so perhaps it's not intended for `cpptrace` to be required for compilation? ### Others _No response_

bsakaguchi closed this issue

2026-10-29 14:49:53 +00:00

bsakaguchi commented

2026-10-29 14:49:54 +00:00

Author

Owner

@SchenbergZY commented on GitHub (Apr 23, 2026):

If you don't need LoRA, you can checkout commit before and install

@SchenbergZY commented on GitHub (Apr 23, 2026): If you don't need LoRA, you can checkout commit before and install

bsakaguchi commented

2026-10-29 14:49:54 +00:00

Author

Owner

@DocShotgun commented on GitHub (Apr 23, 2026):

If you don't need LoRA, you can checkout commit before and install

Sure, but I was just pointing out a suspected oversight on the latest commit.

@DocShotgun commented on GitHub (Apr 23, 2026): > If you don't need LoRA, you can checkout commit before and install Sure, but I was just pointing out a suspected oversight on the latest commit.

bsakaguchi commented

2026-10-29 14:49:54 +00:00

Author

Owner

@JimmyPeilinLi commented on GitHub (Apr 25, 2026):

Thanks for pointing this out. We later found the same leftover cpptrace path on our side as well.

The default kt-kernel build should not require cpptrace; this was fixed in commit 85308615b98bf9262f5e90341f51cb7e87a08a4d / #1945, where the cpptrace include and crash-handler code were guarded behind KTRANSFORMERS_ENABLE_CPPTRACE, and the dependency was made opt-in via CMake.

Please update to the latest main or any commit after 85308615 and rebuild. Thanks again for catching this.

@JimmyPeilinLi commented on GitHub (Apr 25, 2026): Thanks for pointing this out. We later found the same leftover `cpptrace` path on our side as well. The default `kt-kernel` build should not require `cpptrace`; this was fixed in commit [`85308615b98bf9262f5e90341f51cb7e87a08a4d`](https://github.com/kvcache-ai/ktransformers/commit/85308615b98bf9262f5e90341f51cb7e87a08a4d) / #1945, where the `cpptrace` include and crash-handler code were guarded behind `KTRANSFORMERS_ENABLE_CPPTRACE`, and the dependency was made opt-in via CMake. Please update to the latest `main` or any commit after `85308615` and rebuild. Thanks again for catching this.