[PR #1116] [MERGED] Add missing references to ik_llama.cpp #1563

New issue

Closed

opened 2026-10-29 14:53:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 14:53:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/ktransformers/pull/1116
Author: @ikawrakow
Created: 4/11/2025
Status: ✅ Merged
Merged: 4/13/2025
Merged by: @KMSorSMS

Base: main ← Head: ik/add_copyright

📝 Commits (2)

c46b0c5 Add missing references to ik_llama.cpp
99a247e Spelling

📊 Changes

1 file changed (+71 additions, -5 deletions)

View changed files

📝 third_party/llamafile/iqk_mul_mat.inc (+71 -5)

📄 Description

The modifications added in PR #754 by @moonshadow-25 were copied from ik_llama.cpp. The file iqk_mul_mat.inc to which the changes were added comes from the llamafile project, which just like KTRansformers itself is Apache-2.0 licensed. But the code copied from without attribution has been published under a MIT License.

I left a comment in PR #754 5 days ago, and also had this exchange with @moonshadow-25 3 days ago, which I think has given @moonshadow-25 enough time to correct the problem themself.

This PR corrects the problem created by @moonshadow-25 by adding links to the original source code in ik_llama.cpp along with MIT copyright notices.

As additional piece of information, user @godrosev, who is the author of the first two commits in PR #754, came to the ik_llama.cpp repository to ask for "1.58-bit" support with this issue. As I already had support for optimized IQ1_S matrix multiplications in row-interleaved format, I wasn't planning to also support plain IQ1_S, but then decided to help @godrosev, and added support in this PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/ktransformers/pull/1116 **Author:** [@ikawrakow](https://github.com/ikawrakow) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/13/2025 **Merged by:** [@KMSorSMS](https://github.com/KMSorSMS) **Base:** `main` ← **Head:** `ik/add_copyright` --- ### 📝 Commits (2) - [`c46b0c5`](https://github.com/kvcache-ai/ktransformers/commit/c46b0c59d0c3a857c3a31fc982272a2d17973e24) Add missing references to ik_llama.cpp - [`99a247e`](https://github.com/kvcache-ai/ktransformers/commit/99a247e167c645de631be4d29cf879cc1281f72e) Spelling ### 📊 Changes **1 file changed** (+71 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `third_party/llamafile/iqk_mul_mat.inc` (+71 -5) </details> ### 📄 Description The modifications added in PR #754 by @moonshadow-25 were copied from [ik_llama.cpp](https://github.com/ikawrakow/ik_llama.cpp). The file [iqk_mul_mat.inc](https://github.com/kvcache-ai/ktransformers/blob/main/third_party/llamafile/iqk_mul_mat.inc) to which the changes were added comes from the [llamafile project](https://github.com/Mozilla-Ocho/llamafile), which just like KTRansformers itself is Apache-2.0 licensed. But the code copied from without attribution has been published under a MIT License. I left [a comment](https://github.com/kvcache-ai/ktransformers/pull/754#issuecomment-2781515478) in PR #754 5 days ago, and also had [this exchange](https://github.com/ikawrakow/ik_llama.cpp/discussions/319) with @moonshadow-25 3 days ago, which I think has given @moonshadow-25 enough time to correct the problem themself. This PR corrects the problem created by @moonshadow-25 by adding links to the original source code in `ik_llama.cpp` along with MIT copyright notices. As additional piece of information, user @godrosev, who is the author of the first two commits in PR #754, came to the [ik_llama.cpp](https://github.com/ikawrakow/ik_llama.cpp) repository to ask for "1.58-bit" support with [this issue](https://github.com/ikawrakow/ik_llama.cpp/issues/209). As I already had support for optimized `IQ1_S` matrix multiplications in row-interleaved format, I wasn't planning to also support plain `IQ1_S`, but then decided to help @godrosev, and added support in [this PR](https://github.com/ikawrakow/ik_llama.cpp/pull/212). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 14:53:32 +00:00