[PR #1159] [MERGED] Fix some build error for ROCM #1574

New issue

Closed

opened 2026-10-29 14:53:36 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-29 14:53:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kvcache-ai/ktransformers/pull/1159
Author: @onepick
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/17/2025
Merged by: @KMSorSMS

Base: main ← Head: fix-rocm-build-error

📝 Commits (2)

97f1995 Fix some build error for ROCM
6a7624f Change the logic to build device since cuda is as default

📊 Changes

3 files changed (+21 additions, -27 deletions)

View changed files

📝 csrc/ktransformers_ext/CMakeLists.txt (+17 -25)
📝 csrc/ktransformers_ext/cuda/custom_gguf/dequant.cu (+2 -2)
📝 csrc/ktransformers_ext/ext_bindings.cpp (+2 -0)

📄 Description

Fix terrible logic in CMakeLists.txt
using the correct typedef for hip

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kvcache-ai/ktransformers/pull/1159 **Author:** [@onepick](https://github.com/onepick) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/17/2025 **Merged by:** [@KMSorSMS](https://github.com/KMSorSMS) **Base:** `main` ← **Head:** `fix-rocm-build-error` --- ### 📝 Commits (2) - [`97f1995`](https://github.com/kvcache-ai/ktransformers/commit/97f199569620537c3d0d8821c3e23d87c81d7bd8) Fix some build error for ROCM - [`6a7624f`](https://github.com/kvcache-ai/ktransformers/commit/6a7624fe4af7d581e4fdc79c9958b19b50230f8d) Change the logic to build device since cuda is as default ### 📊 Changes **3 files changed** (+21 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `csrc/ktransformers_ext/CMakeLists.txt` (+17 -25) 📝 `csrc/ktransformers_ext/cuda/custom_gguf/dequant.cu` (+2 -2) 📝 `csrc/ktransformers_ext/ext_bindings.cpp` (+2 -0) </details> ### 📄 Description 1. Fix terrible logic in CMakeLists.txt 2. using the correct typedef for hip --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-29 14:53:36 +00:00