mirror of
https://github.com/lutris/dgvoodoo2.git
synced 2026-11-05 01:07:36 +00:00
[GH-ISSUE #3] Remove dgVoodoo releases, now #1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dege-diosg on GitHub (Mar 14, 2025).
Original GitHub issue: https://github.com/lutris/dgvoodoo2/issues/3
Please remove those "repackaged" dgVoodoo releases.
I did not give my "blessings" to hosting any gutted dgVoodoo package.
I only did it for having dgVoodoo components in game releases (but I regretted that too).
Even the old redistribution rights said that the original, unmodified package must have been hosted.
@dege-diosg commented on GitHub (Mar 17, 2025):
Any proceed on this complicated task? Or you're just ignoring me?
A little reminder from the old version of "redistribution rights" of dgVoodoo:
@strycore commented on GitHub (Mar 18, 2025):
I fully agree about not redistributing modified versions of DgVoodoo2. I was under the impression that you were ok with our distribution model, my bad.
I'd like to handle this situation gracefully, that is without breaking the dgVoodoo2 feature in Lutris. Here's what I propose:
I can do the 1st 3 steps right now and I can delete this repo once we have resolved this issue.
@strycore commented on GitHub (Mar 18, 2025):
All Github releases are now deleted. I hope you're ok with us distributing our latest modified package so we don't break the dgVoodoo2 feature.
It shouldn't be hard to switch to a new folder structure and we can also provide scripts to let users of older lutris versions have access to dgVoodoo.
I noticed you've recently set your repo as read only, I hope it's still ok to link to your past github releases.
@dege-diosg commented on GitHub (Mar 18, 2025):
Thank you, I appreciate it!
So, if I get it right, the Lutris application downloads dgVoodoo files from the cloud through your API (for example when installing a game)?
If so, then it's ok for me.
You may always host an unmodified dgVoodoo package in the cloud, or even a modified one if it's only accessed indirectly through the Lutris app. Or, you can have links to my github releases but I don't really recommend that because I usually delete old/outdated versions as new ones are released (for forcing using new versions to have regression bugs reported and fixed as much as possible).
Btw, a little explanation why I'm against redistributing modified packages: if a user encounters such a package then he/she won't have the chance to get aware of or check out the missing components, and will think the software package is as is, so it's kind of "distributing misinformation".
@strycore commented on GitHub (Mar 19, 2025):
yes, that's right, the modified dgVoodoo build is only available by querying our API. It's pretty easy to find but you have to be looking for it.
dgVoodoo is one of our runtime components. This means it gets downloaded and updated whenever Lutris starts. We have 2 types of runtime components: versioned and not versioned, versioned lets you pick a version of the component from github releases. not versioned just downloads whatever is the latest version and doesn't offer to switch to another version.
we've had dgVoodoo2 as a versioned component so far. I guess that feature is now broken due to the github releases being gone.
I don't see a lot of value in being able to downgrade versions. I'll likely switch dgVoodoo to a non versioned runtime component, it will always use the latest version and it won't matter if older releases are deleted.
@dege-diosg commented on GitHub (Mar 19, 2025):
Okay, thank you for the information!