diff --git a/include/mscclpp/core.hpp b/include/mscclpp/core.hpp index 7d3f4f66..7357bf05 100644 --- a/include/mscclpp/core.hpp +++ b/include/mscclpp/core.hpp @@ -516,15 +516,6 @@ class Communicator { /// @return RegisteredMemory A handle to the buffer. RegisteredMemory registerMemory(void* ptr, size_t size, TransportFlags transports); - /// Register a region of GPU memory for use in this communicator. - /// - /// @param ptr Base pointer to the memory. - /// @param size Size of the memory region in bytes. - /// @param pitchSize pitch size of the memory region in bytes. (used for 2D communication) - /// @param transports Transport flags. - /// @return RegisteredMemory A handle to the buffer. - RegisteredMemory registerMemory(void* ptr, size_t size, size_t pitchSize, TransportFlags transports); - /// Send information of a registered memory to the remote side on setup. /// /// This function registers a send to a remote process that will happen by a following call of @ref setup(). The send diff --git a/python/proxy_channel_py.cpp b/python/proxy_channel_py.cpp index 5e264acf..4249dd80 100644 --- a/python/proxy_channel_py.cpp +++ b/python/proxy_channel_py.cpp @@ -2,6 +2,7 @@ // Licensed under the MIT license. #include +#include #include #include @@ -22,6 +23,10 @@ void register_proxy_channel(nb::module_& m) { .def("build_and_add_semaphore", nb::overload_cast>(&ProxyService::buildAndAddSemaphore), nb::arg("comm"), nb::arg("connection")) + .def("build_and_add_semaphore", + nb::overload_cast, std::pair>( + &ProxyService::buildAndAddSemaphore), + nb::arg("comm"), nb::arg("connection"), nb::arg("pitch")) .def("add_semaphore", &ProxyService::addSemaphore, nb::arg("semaphore")) .def("add_memory", &ProxyService::addMemory, nb::arg("memory")) .def("semaphore", &ProxyService::semaphore, nb::arg("id"))