mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #3382] [Bug] Electron script frame attribution and identity change after context destruction #1250
Closed
opened 2026-10-16 21:03:21 +00:00 by bsakaguchi
·
2 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#1250
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 14, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/3382
Before submitting
Area
Process capture or runtime observation
Observed behavior
inspect-electron-pageloses a script's already supplied execution-context frame ID when the context is destroyed before collection finishes. The script remains in the result, but itsframe_idbecomesnulland itsscript_keychanges. Identical script observations therefore differ according to whether their context survives until projection.Both public CLI calls in the reproduction exited with code
0. The control returnedframe_id: "main"; the destroyed-context case returnedframe_id: nulland a differentscript_key. The authorized frame remained present in both results. Both captures reported only the expectedscript_sourcespolicy exclusion, with no unavailable section or dropped script event.The same loss was also observed with
--include-script-sources; those runs reportedcomplete_within_window. The primary reproduction omits that option so it does not depend on source retrieval after context destruction. These observations establish behavior with a protocol fixture, not a real Electron producer.Reproduction
sample-observation/sample-repro.mjswith the following contents. The fixture creates every input file, includingindex.htmlcontaining<script src="app.js"></script>andapp.jscontainingglobalThis.marker=1;, and isolates the CLI home directory. It uses a local CDP protocol fixture and ordinary files, requires no Electron installation, and executes no application JavaScript.sample-observation/control.jsonandsample-observation/destroyed-context.json, and closes the endpoint and sockets before exiting.The underlying command is
node scripts/rea.mjs inspect-electron-page ENDPOINT page --observation-ms 100 --json, withENDPOINTsupplied by the fixture and an isolated home directory. Both runs receive the same local page, frame, context, and script metadata. The second run additionally receivesRuntime.executionContextDestroyedafterDebugger.scriptParsed.Expected behavior
docs/electron-observation.md:51-54promises stable script/resource identities and retention of execution-context frame IDs supplied by CDP. The script should retainframe_id: "main"after its context is destroyed because CDP already supplied that relationship while the script was observed. Its identity should remain the same for the same retained script metadata. Script-source filtering should not discard frame attribution.Impact and scope
Impact level: P2. Assessment status: supported. Observed script-to-frame attribution is discarded and its identity changes under a supported context lifecycle event. This affects the usefulness and comparability of passive Electron script Evidence; broader occurrence on real applications was not measured.
Workaround status: unverified. Capturing before context destruction may avoid the triggering sequence, but this depends on target timing and was not established as a practical way to retain the requested observations. Omitting script sources was executed and did not avoid the loss.
REA version
6.4.0 (main at
8dde6370d0)Runtime and platform
Node.js v26.10.0; macOS 27.0.1. Architecture was not recorded for this reproduction.
Target and artifact context
A simulated CDP producer serves one ordinary local file page and one local JavaScript file, a valid main frame, one execution context, and one parsed script. The fixture sends the context-destroyed event only in the second run. Inspection uses the built runtime through the public CLI; no Electron installation or application JavaScript execution is needed. The retained artifacts are the full CLI JSON results for both modes.
Interface
CLI
Earliest failure stage
Transport or result projection
Relevant output or evidence
The following selected fields summarize the observed public CLI results. Evidence provenance: observed. Local verification: reproduced. Reproduction completeness: complete. Exact script-key hashes were not recorded here; the observed comparison established that they differed.
The executed CLI fixture results establish the violation. The source locators below explain the observed boundary.
Typed outcome or recovery expected
Run both fixture modes against the same local files. Each should retain the supplied
frame_id: "main", and their script keys should agree. Keep the control's existing source-filtering behavior. Also preserveframe_id: nullwhen CDP never supplies a usable frame relationship; restoration must not invent attribution for genuinely unknown contexts.Analysis or suspected cause
Source-derived reasoning:
src/browser/CdpElectronScriptEvents.ts:31-35removes the context mapping afterRuntime.executionContextDestroyed.src/browser/CdpElectronScripts.ts:38-53consults that later mapping when projecting the script and hashing its identity. The surviving script consequently loses its previously supplied frame ID, and the changed identity input changes its script key. This source-derived explanation is separate from the observed CLI results.Additional context
Related completed issue #1500 addresses frame attribution changing after context-ID reuse in browser page capture; this report reproduces attribution loss after context destruction in the Electron inspector's separate implementation. The earlier issue was closed as completed, so it does not establish a by-design exception to retained frame attribution.
Related completed issue #2556 concerns malformed Electron child frame IDs being classified as scope exclusions; this report supplies valid identities and loses an already observed relationship after a lifecycle event.
Related issue #3192 concerns false absence states for ambiguous static reconciliation candidates; this report changes captured script metadata before reconciliation.
Related issue #3316 concerns a unique alternate static digest match hiding a mapped-path mismatch; this report loses captured frame attribution and changes script identity.
Related completed issue #2625 concerns parse-gap attribution to unaffected web-bundle scripts; this reproduction does not parse script source and concerns Electron script lifecycle retention.
@kaoru0822-kitauji commented on GitHub (Oct 17, 2026):
This appears fixed on main by
6b991d3aa(fix(electron): snapshot script frame identity at ingestion, 2026-10-16). Script frame identity is now captured whenDebugger.scriptParsedis ingested, instead of being looked up from the live context at projection time.Executed on main
ae029fe2f(macOS arm64):npm run test:local -- src/browser/CdpElectronInspection.test.ts→ 3/3 passed. That includespreserves script records across context teardown and ID reuse, added by that commit. It parses a script in context 7 (frame-old), destroys context 7, reuses the ID forframe-new, and asserts both scripts keep their ownframe_idand distinctscript_keys. Scripts whose context is genuinely unknown still reportframe_id: null.I did not rerun this report's public CLI fixture, and no real Electron producer was used. Leaving closure to a maintainer.
@coygeek commented on GitHub (Oct 18, 2026):
Addressed on main by
github.com/morluto/rea@6b991d3aa7. Parsed scripts now retain their observed frame at ingestion, so destroying or reusing the execution context no longer changes the recorded frame attribution or the script identity derived from it. Unknown and out-of-scope frame mappings remain null. I checked the current source and the included regression coverage; I have not rerun the CLI fixture. Closing as completed.