mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #3937] [Bug] Reconstruction coverage ignores contradictions on required claim surfaces #1543
Closed
opened 2026-10-16 21:06:55 +00:00 by bsakaguchi
·
5 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#1543
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 15, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/3937
Before submitting
Area
Evidence, artifacts, or reconstruction
Observed behavior
The public coverage evaluator returns
readywhen an active contradiction names the only surface of a required claim, unless the caller also lists that surface independently in the boundary or repeats the affected claim ID in the contradiction. The response omits both the contradiction reason and its resolution probe. This can cause a caller to accept reconstruction closure despite a recorded conflict affecting required behavior.I observed the following results from the generated requests. Every command exited zero, and every request passed the coverage parser before CLI invocation.
The affected response also omitted the distinct contradiction Evidence record from its returned citations; both explicit controls retained it. The same active conflict therefore changes the closure outcome solely through redundant association metadata. These observations establish public CLI behavior. MCP registration reaches the same application evaluator according to source inspection; I did not execute an MCP request.
Reproduction
affectedwithexplicitSurfaceandexplicitClaim. All have the same required claim, passing proof and active contradiction. The first requirescli.versionindependently and requiresclaim.help, which namescli.help; its contradiction namescli.helpwith an empty claim list. The second additionally listscli.helpas a required surface. The third keeps the original boundary and addsclaim.helpto the contradiction.resolvedandunrelatedas controls. The first resolves the same contradiction, and the second moves it to a separate inventoried surface that the required claim does not name.Expected behavior
The named boundary must withhold
readywhile an active contradiction affects its required claim. A contradiction naming that claim's only surface must retainactive-contradiction, producefailed, and recommend resolving the contradiction, just as when the affected surface or claim is explicitly repeated. Resolved contradictions and contradictions unrelated to the boundary must continue to allow closure when the other checks pass.The public tool contract promises evidence-backed evaluation against a named boundary and says contradictions fail closed. The input permits a required claim to reference a surface independently of the boundary's explicit surface list, and permits contradictions to identify affected surfaces without naming claims.
Impact and scope
A valid bounded request receives an incorrect ready decision and loses the conflict reason and resolution probe for required behavior. The executed CLI cases demonstrate the failure without establishing harm to a real reconstruction or a broader population frequency.
Workaround: Add the affected required claim ID to the contradiction's claim list. The executed explicitClaim control then returns failed with the expected contradiction reason while preserving the original boundary, all Evidence, and the active conflict.
REA version
rea 6.5.0 at source commit
4692bb3330Runtime and platform
Node 24.18.0; macOS arm64
Target and artifact context
Synthetic authenticated reconstruction Evidence with two fully owned CLI surfaces and a fresh verifier result. An active contradiction names the required claim surface only.
Interface
CLI
Earliest failure stage
Native analysis or reconstruction
Relevant output or evidence
src/contracts/applicationToolContracts.ts:218, the publicevaluate_reconstruction_coveragecontract promises that contradictions fail closed;src/domain/reconstructionCoverage.ts:138permits surface-specific contradiction associations,:160permits independent required surface and claim lists, and:381maps an active contradiction reason tofailed.src/domain/reconstructionCoverageEvaluation.ts:384, where risk evaluation only intersects contradiction surface IDs with explicit required surface IDs, or contradiction claim IDs with explicit required claim IDs. It does not include the surfaces referenced by required claims. The built runtime contains the same predicate indist/domain/reconstructionCoverageEvaluation.js:191.src/cli/applicationCommands.ts:169registers the JSON command and invokes the application evaluator;src/application/ReconstructionCoverageService.ts:17parses the request and calls closure evaluation;src/domain/reconstructionCoverage.ts:267validates references and invokes risk evaluation. No guard requires redundant surface or claim associations.src/server/registerApplicationTools/coverage.ts:16registers the matching MCP tool with the same application evaluator.Typed outcome or recovery expected
Run the same generated requests with fresh verifier proof. The affected request must return
failedwith anactive-contradictionreason forconflict.help, retain its Evidence, and provide a resolution probe. Keep both explicit controls failing for the same active contradiction. Keep the resolved and unrelated controls ready so that restoration preserves boundary scoping. The implementation may choose how it determines that an active contradiction affects a required claim.Analysis or suspected cause
Source-derived explanation and exact locators are in Relevant output or evidence. Provider and transport limits are stated there separately from reproduced results.
Additional context
Related issue #3890 concerns owner checks for claim-only surfaces. This case has complete owners and reaches a separate active-contradiction selection branch; restoring ownership checks alone leaves this failure. Issue #3889 concerns conflicting package proofs. Adding the affected claim ID to the contradiction is a demonstrated workaround. Related issues #3354 and #3357 concern transitive inventory and weak cited Evidence respectively.
Freshness check: the cited source and contract files have no changes between the tested source commit and upstream main at
22ec8bdb2f.@XinwangTao commented on GitHub (Oct 15, 2026):
Confirmed: an active contradiction that names the only surface of a required claim must not yield ready coverage — the affected run returning ready while explicitSurface/explicitClaim fail shows the closure verdict depends on redundant association metadata instead of the contradiction itself. Coverage should treat the contradiction as unresolved on every affected required surface (and surface it in reasons/probes), not only when the caller happens to repeat the surface or claim ID.
@matbrgz commented on GitHub (Oct 20, 2026):
Cross-referencing with canonical issue #3354 and siblings #3889, #3890 regarding contradiction resolution on required claim surfaces in reconstruction coverage. Cataloged under Cluster BR in consolidation tracker #4330.
@XinwangTao commented on GitHub (Oct 21, 2026):
Agree this belongs with #3889/#3890 under the same contradiction-on-required-surface cluster. One thing worth making explicit in whichever fix lands: the affected case (contradiction names the only surface, caller adds no redundant association metadata) is the default way callers construct these requests, so the regression test should assert that plain affected returns failed with the active-contradiction reason and resolve_contradiction probe — matching explicitSurface/explicitClaim rather than only pinning the metadata-dependent divergence described here.
@XinwangTao commented on GitHub (Oct 21, 2026):
Agree this belongs with #3889/#3890 under the same contradiction-on-required-surface cluster. One thing worth making explicit in whichever fix lands: the affected case (contradiction names the only surface, caller adds no redundant association metadata) is the default way callers construct these requests, so the regression test should assert that plain affected returns failed with the active-contradiction reason and resolve_contradiction probe — matching explicitSurface/explicitClaim rather than only pinning the metadata-dependent divergence described here.
@morluto commented on GitHub (Oct 23, 2026):
Resolved on main in a35b9335a. Risk evaluation consumes the same effective scope as required claims and ownership. The executed claim-only active contradiction control returns failed and retains reason/probe/citations. Validation:
src/domain/reconstructionCoverage.test.ts— claim-only active contradiction; recorded execution atb03a15e6d. Thirty coverage tests passed with authenticated synthetic workspaces, including complete control. Public CLI/MCP test is present but not recorded as executed; no external provider involved.