mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #3936] [Bug] Electron action targets use the selection index instead of window identity #1545
Closed
opened 2026-10-16 21:06:55 +00:00 by bsakaguchi
·
4 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#1545
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 15, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/3936
Before submitting
Area
Evidence, artifacts, or reconstruction
Observed behavior
capture_electron_scenarioreturns action targets that do not identify the acted-on window in its window inventory. In an executed MCP reproduction with simulated windows whose IDs are 1 and 3, clicks on those windows returnwindow:0andwindow:1. The first target matches no window, and the second names the other window. This also affects a failed action after a window has been selected.Reproduction
Use the baseline under Runtime or environment with its locked dependencies installed. This reproduction uses the registered MCP tool and real provider action, snapshot and projection logic. It simulates the Electron launch boundary and process supervision; it launches no Electron process and sends no process signals.
src/browser/electronActionIdentityRepro.test.ts.Expected behavior
Each action that selects a window should identify that actual window using its capture-scoped window identity. A click on the window whose inventory identity is
window:3should report that identity rather than the selection index. This applies to action records that complete or fail after selecting a window. The documented correlated window evidence and action targets, together with the repository fixture pairing index 0 with target and window identitywindow:1, establish the existing contract.See
src/contracts/javascript/electronToolContracts.ts:144,docs/electron-observation.md:75,95,107, and the index-0/action-target/window-identity pairing insrc/domain/javascript/electronActiveObservation.fixture.ts:44,52.Impact and scope
P2. Actions that select windows can return an unmatched target or a target naming another window, corrupting action attribution. Click selection itself succeeded in the reproduction, and the window inventory remained available. Real Electron behavior was not tested. A reliable general caller workaround is unverified because consistent ordering across the two enumerations is not established.
REA version
rea 6.5.0 at source commit
4692bb3330Runtime and platform
Node 24.18.0; macOS arm64
Target and artifact context
Two simulated Electron windows with IDs 1 and 3. Production MCP registration, action runner, snapshot callback, projection, and Evidence delivery executed; launch, process observation, and cleanup were simulated. No real Electron process or process signals were used.
Interface
MCP
Earliest failure stage
Capture or observation
Relevant output or evidence
Observed in one executed MCP reproduction: the reply was successful and its window inventory contained
window:1andwindow:3. Recorded click effects were[1,3], but the successful action targets werewindow:0andwindow:1. A subsequent failed click selected the second window and also reportedwindow:1. The untargeted wait correctly reported null. Relevant output fields were:Source-derived conclusion: the action record formats the selected array index as the target, whereas the window snapshot formats the Electron window ID. Both the successful and failed action paths use this index-based target, and result projection preserves it. No real Electron capture was run; the observation establishes behavior through the registered MCP tool with a simulated application at the production launch boundary.
Typed outcome or recovery expected
With the same two-window input, verify that the first completed click reports
window:1, the second reportswindow:3, and the failed click on the second window also reportswindow:3. Confirm that the click effects still identify windows 1 and 3 so a target-only change cannot mask acting on the wrong page. Preserve null for the untargeted wait and preserve the separate action-selection indices. Real Electron verification should also confirm that returned targets correlate with the actual selected windows.Analysis or suspected cause
Source-derived:
src/browser/PlaywrightElectronActiveActions.ts:107,121formats the selected array index as the action target; line 232 uses that index for page selection, while line 288 formats the Electron window ID for inventory identity.src/browser/PlaywrightElectronActiveProjection.ts:155andsrc/application/javascript/ElectronActiveEvidence.ts:19preserve the mismatch.Additional context
The cited failing code is unchanged on current
origin/mainat22ec8bdb2f7d4626587f23b1eed4a207df600386. Related closed #2649 and #2650 concern dropped preload-configuration coverage and limitation wording, rather than action/window identity.@XinwangTao commented on GitHub (Oct 15, 2026):
Confirmed: returning selection indices (0, 1) as window targets when the inventory holds IDs 1 and 3 means the first reported target matches no window at all, and the second aliases the wrong one. Action targets should carry the window identity from the inventory, keeping the separate action-selection index out of the projected result — otherwise target-only change detection can mask acting on the wrong page.
@N0zoM1z0 commented on GitHub (Oct 16, 2026):
Source follow-up at main
42fc6c53ae188978deb3bedfe88287b6b316ba22(no real Electron reproduction yet): the same owner also independently reselects the execution target forrenderer-crash.runElectronActionsselects a Page fromapplication.windows()[window_index], butrunActionthen choosesBrowserWindow.getAllWindows()[action.window_index]again. No common ordering or stable membership between these two reads is established. Thus changing only the reported target string would leave a potential execution/identity mismatch for crash actions.The installed Playwright 1.58.2 declaration provides
ElectronApplication.browserWindow(page)for resolving the BrowserWindow corresponding to the selected Page. A prospective fix should use one selected-object owner for identity and execution, preserve failed-action identity, and dispose any acquired handle with awaited cleanup. Preserve null for untargeted waits/deep links.Verification should assert actual click/crash effects with nonmatching enumeration orders and lifecycle transitions, alongside a real public-app control. These are proposed checks, not completed runtime verification. This is read-ahead only while #4265 awaits an unrelated upstream CI correction; no competing implementation or PR has been started.
@XinwangTao commented on GitHub (Oct 16, 2026):
Good catch on the double reselection — window_index being read once from application.windows() and again from BrowserWindow.getAllWindows() with no shared ordering means fixing only the reported target string would leave the crash path acting on a different window than the one reported. Using ElectronApplication.browserWindow(page) as the single owner for both identity and execution, plus the awaited handle disposal, closes that gap. Agree the verification should exercise mismatched enumeration orders, not just a happy-path two-window run.
@coygeek commented on GitHub (Oct 24, 2026):
Checked the reported fix on
mainatd87e73f2db.runElectronActions selects a Page once, resolves its native BrowserWindow with application.browserWindow(page), records window: before executing, and keeps that target through the catch path. renderer-crash acts through the same handle, not a second BrowserWindow.getAllWindows index read. Handle disposal is awaited and cleanup ownership retained on failure.
Implementation: PlaywrightElectronActiveActions.ts, PlaywrightElectronActiveActions.ts.
The relevant regression checks in PlaywrightElectronActiveActions.test.ts, PlaywrightElectronActiveProvider.test.ts passed in the focused test run on this revision. This closure is based on the current source and those checks; provider fixtures do not establish a real-engine run. Closing as completed on main.