mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #4250] [Bug] Const-asserted inline BrowserWindow objects lose preferences and preload links #1673
Closed
opened 2026-10-16 21:08:52 +00:00 by bsakaguchi
·
1 comment
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#1673
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 15, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/4250
Before submitting
Area
Evidence, artifacts, or reconstruction
Observed behavior
Successful
analyze-javascript-applicationcalls omit explicit window preferences and their preload association whenas constwraps either the inline BrowserWindow options object or its inlinewebPreferencesobject. The same direct Electron import and literal preload work in a plain object. The affected results report partial application coverage and retain a separateproperty:preloadrole, but the window has no preferences, preload declaration or loads edge.This report covers those two inline object positions. An assertion around only the preload string is a passing regression control. Both reproduced object failures report partial application coverage.
Reproduction
Use the source revision under REA version and the pinned toolchain under Runtime and platform, install the locked dependencies if needed, and run
npm run build:cached. Run this script from the repository root. It creates separate extracted directories, writes an existing absolute preload file for each, isolates user configuration, and calls the public CLI. The dynamic expressions are inert analysis controls and are never executed.The script was executed as written on a fresh current-source build. Each case has one window and one explicit preload property, apart from the dynamic object with no visible preference object and the two override controls with an additional syntax item.
countslists windows, explicit preference items and per-window preload declarations in that order.rolescounts merged preload role nodes, which is a separate quantity.Expected behavior
Recover the explicit preference and preload association from both const-asserted inline object forms just as from the plain control. All four positive cases should preserve the exact literal preload declaration with filesystem-expression context, counts
[1,1,1]and one window-to-preload loads edge. These are static source facts and inferences, not evidence that Electron executed or loaded the file.The reconstruction guide promises recovery of explicit BrowserWindow options and preferences from supported TypeScript sources. These two inputs contain the entire object literal at the constructor call, with no option variable, runtime computation, dynamic key, spread, accessor or mutation. The assertion affects type checking and leaves that literal's expression identity intact. Recovering it requires no additional binding or value-flow inference. Existing inline-option tests and their type-erased-key controls at lines 122–174 retain explicit fields and final-property ownership, and the shared expression contract explicitly describes type-only wrappers as erased identity. The expectation therefore rests on the explicit inline recovery contract and these concrete values, rather than on parser acceptance alone.
The guide's unknowns rule still applies to unresolved values. The dynamic object/value and later override controls must keep their effective preload unknown. Omitted preferences must not become guessed Electron defaults.
Impact and scope
P2, supported: the two inline object forms lose useful machine-readable explicit preferences and their window/preload association in successful analysis. The demonstrated failure is bounded, retains source evidence and the standalone preload role, and warns of incomplete analysis through partial application coverage. Severe downstream harm, whole-workflow failure, and real-application frequency were not established.
Workaround status is unverified. No public workflow preserving the original artifact and restoring the missing window projections was demonstrated. Removing assertions or analyzing emitted JavaScript changes the selected bytes and Evidence identity; manual inspection does not correct the returned graph.
Only
as constat the two executed inline object positions is claimed. Other assertion forms and platforms, installed-release behavior, real Electron execution, full-suite coverage, and post-fix restoration were not tested.REA version
Freshly rebuilt source checkout from fetched upstream main
0e1f0bf2d06943e59253b8a66923a1ae6005e81e. The CLI reports 6.5.0; this is source-checkout behavior and does not establish behavior of the published 6.5.0 package.Runtime and platform
Repository-pinned Node.js v24.18.0 and npm 11.16.0 on macOS arm64, with locked dependencies and TypeScript 7.0.2. Forced
npm run buildcompleted all three tasks with zero cache hits. No native analysis engine or Electron installation was used.Target and artifact context
Separate local extracted application directories, each containing inert
main.tsand an existing absolutepreload.cjsfile. REA reads these inputs as text. The absolute preload is a valid authored declaration; its artifact lookup remainsnot-foundeven in passing controls. The report concerns declaration and window-association recovery, not runtime loading or successful artifact mapping.Interface
CLI and MCP (stdio)
Earliest failure stage
Native analysis or reconstruction
Relevant output or evidence
All eight calls returned exit code 0,
ok: true, one BrowserWindow and zero parse failures. The observed fields were:Both failing windows have an empty
web_preferenceslist and nullpreload_pathandpreload_resolution_context. Their surviving role has only the standaloneproperty:preloadobservation. The plain and literal-regression roles also haveBrowserWindow:webPreferences.preload, and each window has its loads relationship. The earlier literal remains visible as preference syntax in the later-override controls, but it does not become an effective window preload.Application coverage is partial and untruncated for both failures, with
omitted_count: null. Separate semantic graph coverage is unknown in every case. The reported partial state warns of incomplete analysis; it does not recover the missing inline preferences or window association. No claim of total preload-discovery loss or global semantic completeness is made.The existing absolute preload file makes the authored constructor input concrete, but the returned role's artifact lookup reports
resolution_status: "not-found"and nullresolved_patheven in the passing controls. This comparison concerns preservation of the declaration and window association, not successful mapping of a host absolute path to an artifact-relative asset.Six separate stdio MCP calls for the four positive forms and both dynamic controls returned graphs and summaries exactly equal to their CLI counterparts. All four positive fixtures passed strict TypeScript compilation against a minimal local Electron constructor declaration. Their emitted JavaScript each called a harmless constructor stub once with the exact original preload string. That check establishes assertion transparency for these authored inputs, not actual Electron behavior. The current options, computed-preference, constructor-identity and static-path source suites passed all 123 tests across four files.
Typed outcome or recovery expected
Analyze the unchanged two const-asserted inline object fixtures through the public workflow. Each must preserve its explicit preference, exact preload declaration and window loads association, matching the plain and fixed-literal controls with counts
[1,1,1]. Check graph observations and relationships as well as summary values; adjusting a count or coverage label alone does not recover the evidence. Preserve exact source provenance and the distinction between declarations, artifact mapping and runtime execution. The implementation and regression-test design remain open.Keep the dynamic object/value and later spread/computed-key controls unresolved with no effective window preload. Preserve final-property ownership, direct Electron constructor identity, merged-role behavior and the current passing literal assertion. The requested restoration does not require general evaluation of option variables or popup override configurations.
Analysis or suspected cause
Source-derived explanation: the BrowserWindow option collector uses raw object-node checks at both positions, and the effective-property reader classifies the whole asserted options object as dynamic before reading properties. The nested assertion fails the collector's raw preference-object check. The current static path reader already unwraps path values, so the literal assertion passes once those object guards are satisfied.
Window preload projection creates the associated role observation and loads relationship only when the window declaration survives. The summary owner counts explicit preference items and nonnull per-window preload declarations, not merged preload role nodes. These locators explain the observed loss and do not prescribe a repair design. The guide's explicit-observation and unknowns rules at lines 336–339 still prohibit guessing omitted defaults or unresolved option values.
Additional context
The exact CLI recipe above was replayed on the freshly fetched and rebuilt upstream revision. A separate retained-input replay confirmed unchanged fixture bytes, all eight CLI cases, all four strict compiler/stub controls, and six stdio MCP comparisons. Each MCP graph and summary exactly matched its corresponding CLI result. The cited contract, projection owners, relevant public adapters, and pinned dependencies were unchanged from the independently verified source baseline; subsequent drift changed a symlink diagnostic and its test, followed by lifecycle/cleanup handling. The public success workflow was rebuilt and replayed after that drift.
Merged PR #3998 restored static path values through TypeScript wrappers. Its literal-preload result passes here. Its body and six changed files cover path values, call targets, receiver classification, and aliases; the inline object guards remain unchanged. A read-only closing-issue query returned zero linked closing issues. This report excludes the already-handled path-value case.
The same-scope constant-options proposal #3536 requires following option bindings and recognizing popup override records. These failing inputs put both objects inline and require neither capability. #3962 concerns unrelated join/resolve semantics; #3883 and #4229 concern overwritten constructor identities; closed #2650 concerns dropped active-capture limitation text. Their restoration signals can pass while these inline object projections still fail. The later-override controls preserve the effective-property rule from closed #1237; computed literal key recovery in closed #2521 is also a distinct trigger.
NOT_ENOUGH_INFO: the first affected revision, last known good revision, published-package applicability, and real-application frequency were not established. No source fix or same-contract restoration run was performed. The strict compiler and harmless constructor stub establish type-assertion transparency only, not real Electron behavior.
Triage assessment
@morluto commented on GitHub (Oct 16, 2026):
Fixed on
mainin b67baede2. BrowserWindow options and webPreferences use the shared transparent-expression owner, retaining asserted inline preferences and preload links without treating dynamic overrides as known.Analyzer and CLI/MCP regressions cover asserted literals, spreads and overwrites; no Electron engine execution is claimed.
Hosted main CI is still pending; this closure is based on the implemented fix and the scoped regression evidence.