mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #4381] [Bug] Cancelling a managed source hash leaves its resource scope stuck in failed cleanup #1738
Closed
opened 2026-10-16 21:09:41 +00:00 by bsakaguchi
·
3 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#1738
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 16, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/4381
Before submitting
Area
Evidence, artifacts, or reconstruction
Observed behavior
Cancelling
hashManagedSourceafter the first file-stream data event rejects withProviderAdapterErrorandcleanupIncomplete: true. The sharedArtifactResourceScoperetains a failed owner, and bothretryCleanup()andclose()reject. The focused production-boundary probe reproduced this in three of three attempts on each tested source revision. Uninterrupted hashing and pre-aborted cancellation controls passed.Reproduction
Prepare separate source checkouts at the tested main and release revisions below using the pinned Node/npm toolchain and locked dependencies (
npm ci). Main supplies the lockedtsxv4.23.15 runner; release does not include it. SetREA_TSXto the absolute path of main'snode_modules/.bin/tsxand use that runner for either checkout. Save this complete script outside the checkouts asrepro.mts, then run it from the chosen checkout root:This executed probe forwards the production file stream unchanged and schedules cancellation after its first real data event. It substitutes no bytes, errors, descriptors, or cleanup operations. It restores the prototype and removes the owned fixture. The script's assertions describe the failing baseline; after restoration, adapt them to require typed cancellation and successful scope cleanup instead.
Expected behavior
Supported cancellation should retain its typed cancellation outcome and complete owner-managed cleanup. The same helper returns
AnalysisCancelledErrorwhen already aborted. The repository's lifecycle contract requires cancellation through awaited cleanup, exact descriptor ownership, and truthful retry state. Ordinary stream cancellation should not leave the scope permanently unable to confirm release.Impact and scope
The observed defect is failed cleanup accounting and blocked scope recovery after cancellation at a bounded local hashing boundary. It does not establish an actual descriptor leak. Source inspection shows
ManagedStaticClient.executeuses this hash branch after caching a PE snapshot, passing its resource scope and request signal; subsequent work retries retained cleanup before admission. No public CLI/MCP session or live provider was executed, and ordinary-use frequency and other platforms remain unmeasured.REA version
Tested main source
8ab5024397ddbd3b37ab68a13cabedc2eb7ce7dd; latest published rea-agents 6.5.0 source3b79af28e80785afce9f5998d8f03289402a1847. Both reproduced. Current main2c7583599b9ac1c847bd77b1940930fd8d4594c7has byte-identical relevant hash, provider, regular-file, owner, resource-scope, error-classification and lifecycle-contract files by API source comparison; the runtime script was executed at the tested revisions.Runtime and platform
Node v24.18.0; npm 11.16.0; Darwin 27.0.0 arm64. Source helpers were imported with the main checkout's locked
tsx; no compiled CLI or provider run.Target and artifact context
Owned synthetic regular file, 32 MiB of zero bytes; no target execution or external provider.
Interface
Other
Earliest failure stage
Cleanup, cancellation, or lifecycle
Relevant output or evidence
Both source revisions printed:
Each attempt also asserted the nested message
File handle was invalidated before this owner confirmed its close.Typed outcome or recovery expected
Repeat the same mid-stream cancellation with real file I/O: require
AnalysisCancelledErrorafter confirmed cleanup, no pending owner, and successful scope retry and close. Preserve exact uninterrupted SHA-256, pre-abort cancellation, and truthful retained ownership when a close really fails; skipping ownership checks or cleanup would not restore the contract.Analysis or suspected cause
Source-derived: the hash stream receives the request signal with
autoClose: false. After abort, the close owner observes an invalidated handle and retains a sticky failure. The normalization atManagedSnapshot.ts:198-211checks filesystem classification before cancellation; the cleanup wrapper retains that primary failure. The provider branch establishes supported reachability after the first successful snapshot read. The local synthetic bytes exercise hashing, not managed PE parsing.Additional context
Related closed #4266 and merged #4274 concern retained ownership after an injected close failure in
hashStableFileand lifecycle consumers. This report concerns a real stream abort inhashManagedSourcethat invalidates the handle before its close owner confirms release; it still reproduces on the tested main after that merge. Open #3977 concerns successful DOS verification after cancellation during Ghidra snapshot cleanup, with successful descriptor close, rather than this failed hash-scope recovery. No last-known-good revision was established.Triage assessment
@xu91102 commented on GitHub (Oct 16, 2026):
Reproduced on current main
d72d856f58d4747c5eb4307426e80d20934e017c, Node 24.18.0 / macOS arm64. A real 32 MiB sparse-file hash passed the exact SHA-256 control and both pre-aborted controls. All 3 mid-stream cancellations then producedProviderAdapterErrorwithcleanupIncomplete: true; the retained scope rejected both retry and close. Only cancellation timing was scheduled at the first actual stream data event; file bytes, errors and cleanup operations were not substituted. This establishes the production hashing/ownership failure, not an actual descriptor leak or a public CLI/MCP run.I am preparing a focused fix that leaves descriptor close authority with its existing owner, with cancellation/recovery and genuine close-failure controls. No covering PR was found in the current issue/function-specific searches.
Update: reproduced again on main
781d5751ad18b25a1fe1ffa8c6035388be8c3283. Proposed two-file fix uses bounded reads through the existing FileHandle owner; it does not relax invalid-handle checks. The real-provider cancellation/recovery and denied-close controls pass (2/2). A deduplicated 37-file owner/consumer/CLI/MCP selection has 518 passing cases across the first run and two isolated whole-file reruns; the original three MCP timeouts are retained with unknown cause. Actual normal CLI and same-client stdio MCP paths, static checks, docs and discovery passed. Public CLI/MCP signal cancellation itself was not run; the cancellation oracle is the real provider/file boundary. Independent Standards/Spec review passed.The patch is committed and pushed, but an ordinary fork-to-upstream Draft creation returned
CreatePullRequestpermission denied. There is no upstream PR or upstream CI for this patch yet; the reason for the creation denial is unknown. Human readiness remains pending.@xu91102 commented on GitHub (Oct 16, 2026):
Could a repository owner/admin check why @xu91102 cannot open a pull request here?
A normal
gh pr create --draftfromxu91102/rea:codex/managed-hash-cancellationtomorluto/rea:mainreturns GraphQLFORBIDDENatcreatePullRequest, with only “does not have the correct permissions to execute CreatePullRequest”. Request ID:5A1A:21990F:A2BB7E:F25BD9:6AD1F534(2026-10-16 09:58 UTC).Read-only checks show PRs enabled, creation policy
ALL, no returned general interaction restriction, a valid fork/branch, and available API quota. There are currently three open PRs from this account: #3263, #3972, #3973. The creation-cap configuration is admin-only and returns HTTP 403 to this account, so I cannot confirm whether a cap or another restriction applies.Could you confirm the applicable restriction and your preferred submission sequence for #4381 and #4393? Both focused fixes are already pushed to the fork; no new upstream PR has been created. I have not changed accounts, tried another creation API, or closed existing PRs to work around the refusal.
@N0zoM1z0 commented on GitHub (Oct 16, 2026):
Independently reproduced on Linux / Node 24.18.0 at latest main
c884864876c2568d8567235737b32e3f5893751d: uninterrupted SHA-256 and pre-abort controls passed; the original real-stream probe reproduced failed cleanup in 3/3 trials. This establishes failed ownership accounting, not a physical descriptor leak.I am integrating @xu91102's published
ebeec580c839f2f72144282a44f4e11ea5759843with original commit authorship preserved, taking independent responsibility for the submission and Linux verification under the current human owner. No upstream covering PR was found. This does not change or resolve the original contributor's reported GitHub permission restriction.Initial 482 related tests passed. On an unchanged official Microsoft.Extensions.Primitives 8.0.0 assembly, the compiled real managed provider passed seven cached-hash cancellation/denied-close/final-close recovery scenarios, including same-client reuse and blocked admission before cleanup. Additional tests exposed a related classification defect when the exact caller cancellation reason carries
code: EACCES; the boundary correction preserves that cancellation while retaining independent read errors. Final checks and normal public CLI/MCP measurements are running; public managed requests are one-shot, so I do not claim they exercise retained-client hash cancellation.