morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #87] [MERGED] fix(contracts)!: return structured workflow failures #1825

New issue

Closed

opened 2026-10-16 21:11:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:11:30 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/87
Author: @morluto
Created: 7/13/2026
Status: ✅ Merged
Merged: 7/13/2026
Merged by: @morluto

Base: main ← Head: codex/rea-low-mid-batch

📝 Commits (3)

4c54ff6 fix(contracts)!: return structured workflow failures
dfd598f fix(native): classify pre-aborted analysis first
ac8cc66 fix(contracts): keep error schema internal

📊 Changes

11 files changed (+361 additions, -112 deletions)

View changed files

📝 scripts/verify-package.mjs (+14 -0)
📝 scripts/verify-real-hopper.mjs (+8 -2)
📝 src/application/EnhancedTools.ts (+58 -40)
📝 src/contracts/toolContracts.ts (+3 -3)
📝 src/contracts/toolOutputSchemas.ts (+50 -10)
📝 src/domain/errors.ts (+33 -25)
📝 src/domain/hopperValues.ts (+4 -0)
📝 src/native/NativeMacOSProvider.ts (+2 -0)
📝 tests/enhancedTools.test.ts (+101 -9)
📝 tests/errors.test.ts (+59 -23)
📝 tests/nativeProvider.test.ts (+29 -0)

📄 Description

Description

Enhanced workflows currently encode partial failures in prose, forcing callers to parse strings and making normal name-resolution misses indistinguishable from provider errors. This change returns exact discriminated results and makes native cancellation classification deterministic.

batch_decompile returns ordered ok/error items plus total, succeeded, and failed counts. Empty input returns zero counts.
get_call_graph gives every node an explicit status and projects failures as { tag, message, details }.
find_xrefs_to_name resolves exact names through the exhaustively paged Hopper name inventory and returns resolved or unresolved with the stable name_not_found reason.
Error projection coverage is compile-time exhaustive across all 23 AnalysisErrorTag variants and excludes causes and local paths.
Pre-aborted native requests return AnalysisCancelledError before operation dispatch or subprocess work.

The MCP inventory remains 68 tools.

Type of Change

Bug fix
New feature
Documentation update
Performance improvement
Refactoring (no functional change)
Tool contract change (MCP schema modification)

Review Order

src/contracts/toolOutputSchemas.ts and src/domain/errors.ts for the public variants and exhaustive error projection.
src/application/EnhancedTools.ts and src/domain/hopperValues.ts for workflow behavior and exact-name resolution.
src/native/NativeMacOSProvider.ts for cancellation-first classification.
Tests and package/real-Hopper verifier updates.

Testing Performed

Unit tests added or updated
TypeScript typecheck passes (npm run typecheck)
Linting passes (npm run lint)
Full test suite passes (npm test) — 54 files, 345 tests; coverage thresholds passed
Real Hopper verification performed (npm run verify:hopper) — unavailable because this host has no Hopper installation
Linux real Hopper verification performed (npm run verify:hopper:linux) — unavailable because this host has no Hopper installation or desktop runtime
Package verification performed (npm run verify:package) — packaged CLI and 68-tool target-free MCP smoke passed
npm pack --dry-run — 135 package files
Autoreview against origin/main — clean after fixing exact-name resolution and not-found classification

Tool Contract Impact

This is an intentional breaking output-shape change for batch_decompile, get_call_graph, and find_xrefs_to_name. No tools are added or removed. Callers must consume the new discriminants instead of parsing error strings.

Related Issues

Closes #23.
Closes #53.

Breaking Change

batch_decompile, get_call_graph, and find_xrefs_to_name now return structured discriminated output shapes; their previous prose-encoded shapes are not retained.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/87 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/13/2026 **Status:** ✅ Merged **Merged:** 7/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/rea-low-mid-batch` --- ### 📝 Commits (3) - [`4c54ff6`](https://github.com/morluto/rea/commit/4c54ff6bcaac02f39c6620a54ac29690a121f33d) fix(contracts)!: return structured workflow failures - [`dfd598f`](https://github.com/morluto/rea/commit/dfd598f76505af978f2d11afffb5e1f362d3a769) fix(native): classify pre-aborted analysis first - [`ac8cc66`](https://github.com/morluto/rea/commit/ac8cc668fb6b9305d2dc9014f7a6006d96b18ba6) fix(contracts): keep error schema internal ### 📊 Changes **11 files changed** (+361 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `scripts/verify-package.mjs` (+14 -0) 📝 `scripts/verify-real-hopper.mjs` (+8 -2) 📝 `src/application/EnhancedTools.ts` (+58 -40) 📝 `src/contracts/toolContracts.ts` (+3 -3) 📝 `src/contracts/toolOutputSchemas.ts` (+50 -10) 📝 `src/domain/errors.ts` (+33 -25) 📝 `src/domain/hopperValues.ts` (+4 -0) 📝 `src/native/NativeMacOSProvider.ts` (+2 -0) 📝 `tests/enhancedTools.test.ts` (+101 -9) 📝 `tests/errors.test.ts` (+59 -23) 📝 `tests/nativeProvider.test.ts` (+29 -0) </details> ### 📄 Description ## Description Enhanced workflows currently encode partial failures in prose, forcing callers to parse strings and making normal name-resolution misses indistinguishable from provider errors. This change returns exact discriminated results and makes native cancellation classification deterministic. - `batch_decompile` returns ordered `ok`/`error` items plus `total`, `succeeded`, and `failed` counts. Empty input returns zero counts. - `get_call_graph` gives every node an explicit status and projects failures as `{ tag, message, details }`. - `find_xrefs_to_name` resolves exact names through the exhaustively paged Hopper name inventory and returns `resolved` or `unresolved` with the stable `name_not_found` reason. - Error projection coverage is compile-time exhaustive across all 23 `AnalysisErrorTag` variants and excludes causes and local paths. - Pre-aborted native requests return `AnalysisCancelledError` before operation dispatch or subprocess work. The MCP inventory remains 68 tools. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Documentation update - [ ] Performance improvement - [ ] Refactoring (no functional change) - [x] Tool contract change (MCP schema modification) ## Review Order 1. `src/contracts/toolOutputSchemas.ts` and `src/domain/errors.ts` for the public variants and exhaustive error projection. 2. `src/application/EnhancedTools.ts` and `src/domain/hopperValues.ts` for workflow behavior and exact-name resolution. 3. `src/native/NativeMacOSProvider.ts` for cancellation-first classification. 4. Tests and package/real-Hopper verifier updates. ## Testing Performed - [x] Unit tests added or updated - [x] TypeScript typecheck passes (`npm run typecheck`) - [x] Linting passes (`npm run lint`) - [x] Full test suite passes (`npm test`) — 54 files, 345 tests; coverage thresholds passed - [ ] Real Hopper verification performed (`npm run verify:hopper`) — unavailable because this host has no Hopper installation - [ ] Linux real Hopper verification performed (`npm run verify:hopper:linux`) — unavailable because this host has no Hopper installation or desktop runtime - [x] Package verification performed (`npm run verify:package`) — packaged CLI and 68-tool target-free MCP smoke passed - [x] `npm pack --dry-run` — 135 package files - [x] Autoreview against `origin/main` — clean after fixing exact-name resolution and not-found classification ## Tool Contract Impact This is an intentional breaking output-shape change for `batch_decompile`, `get_call_graph`, and `find_xrefs_to_name`. No tools are added or removed. Callers must consume the new discriminants instead of parsing error strings. ## Related Issues Closes #23. Closes #53. ## Breaking Change `batch_decompile`, `get_call_graph`, and `find_xrefs_to_name` now return structured discriminated output shapes; their previous prose-encoded shapes are not retained. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:11:30 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-17 21:01:31 +00:00

[GH-ISSUE #2383] [Tracker] Audit analysis and debugging coverage for the TIOBE top 100 languages (October 2026) #794

bsakaguchi referenced this issue

2026-10-31 00:55:52 +00:00

[PR #1825] [CLOSED] fix(managed): surface exported (forwarded) types in member inspection #4843

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#1825

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns