[PR #92] [MERGED] fix: preserve requested evidence paths on macOS #1830

New issue

Closed

opened 2026-10-16 21:11:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:11:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/92
Author: @morluto
Created: 7/13/2026
Status: ✅ Merged
Merged: 7/13/2026
Merged by: @morluto

Base: main ← Head: fix/macos-evidence-paths

📝 Commits (1)

3d0ad79 fix: preserve requested evidence paths on macOS

📊 Changes

2 files changed (+17 additions, -10 deletions)

View changed files

📝 src/application/EvidenceBundleFiles.ts (+4 -3)
📝 tests/sessionMcp.test.ts (+13 -7)

📄 Description

Summary

keep canonical paths for evidence-root containment and filesystem writes
return the absolute path requested by the caller instead of leaking macOS /private/var canonicalization
make the process-residual MCP test capability-aware and use the source-owned process fixture

Verification

npx vitest run tests/evidenceBundleFiles.test.ts tests/sessionMcp.test.ts --coverage.enabled=false --no-file-parallelism — 5 tests passed
npm run typecheck
full suite on this commit before extraction — 56 files and 348 tests passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/92 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/13/2026 **Status:** ✅ Merged **Merged:** 7/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/macos-evidence-paths` --- ### 📝 Commits (1) - [`3d0ad79`](https://github.com/morluto/rea/commit/3d0ad799c4deb1d3627d8721c31bc76be3f3abd2) fix: preserve requested evidence paths on macOS ### 📊 Changes **2 files changed** (+17 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/application/EvidenceBundleFiles.ts` (+4 -3) 📝 `tests/sessionMcp.test.ts` (+13 -7) </details> ### 📄 Description ## Summary - keep canonical paths for evidence-root containment and filesystem writes - return the absolute path requested by the caller instead of leaking macOS `/private/var` canonicalization - make the process-residual MCP test capability-aware and use the source-owned process fixture ## Verification - `npx vitest run tests/evidenceBundleFiles.test.ts tests/sessionMcp.test.ts --coverage.enabled=false --no-file-parallelism` — 5 tests passed - `npm run typecheck` - full suite on this commit before extraction — 56 files and 348 tests passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:11:33 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:55:58 +00:00

[PR #1834] [MERGED] test(web): cover nullable HTTP captures through CDP and CLI #4848

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#1830

No description provided.

Rows
Columns