morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #107] [MERGED] fix(errors): return actionable caller-safe failures #1838

New issue

Closed

opened 2026-10-16 21:11:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:11:38 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/107
Author: @morluto
Created: 7/13/2026
Status: ✅ Merged
Merged: 7/13/2026
Merged by: @morluto

Base: main ← Head: morl/roadmap_implementation

📝 Commits (6)

3be439c feat(errors): add caller-safe typed error projections
eb38e4c feat(mcp): return structured typed tool results
af8c4ef fix(cli): render actionable analysis errors
77454dc fix(errors): improve recovery guidance
12060f6 fix(copy): use agent terminology
a93a198 Merge branch 'main' into morl/roadmap_implementation

📊 Changes

61 files changed (+1953 additions, -346 deletions)

View changed files

📝 README.md (+12 -12)
📝 docs/api/functions/application_Setup.detectClients.html (+1 -1)
📝 docs/installation.md (+2 -2)
📝 docs/roadmap.md (+1 -1)
➕ docs/user-visible-errors.csv (+103 -0)
📝 install.sh (+11 -11)
📝 package.json (+2 -2)
📝 scripts/rea.mjs (+6 -3)
📝 skills/rea-analysis/SKILL.md (+1 -1)
📝 src/application/DirectAnalysis.ts (+11 -8)
📝 src/application/ProcessCaptureAuthority.ts (+5 -3)
📝 src/application/ProcessCaptureError.ts (+24 -0)
📝 src/application/ProcessCaptureLifecycle.ts (+26 -1)
📝 src/application/ProcessCli.ts (+127 -32)
📝 src/application/ProcessHarness.ts (+5 -3)
📝 src/application/ReferenceSourceImportEntries.ts (+21 -3)
📝 src/application/ReferenceSourceImportTypes.ts (+42 -2)
📝 src/application/Setup.ts (+6 -24)
➕ src/application/SetupClients.ts (+39 -0)
📝 src/application/Uninstall.ts (+69 -21)

...and 41 more files

📄 Description

Description

REA currently forwards provider diagnostics, parser details, local paths, and other implementation-specific text through several CLI and MCP failure paths. Callers cannot reliably decide whether to retry, correct input, request permission, or choose another provider.

This change gives expected failures a provider-neutral category and actionable message, then applies that projection consistently across MCP tools, one-shot commands, setup, uninstall, upgrade, reference-source import, process capture, the installer, and MCP startup/shutdown. It also inventories 102 user-visible error paths in docs/user-visible-errors.csv.

CLI validation output is sanitized in both normal and --full-output formats. Process command failures retain a nonzero exit code, so redirected output cannot be mistaken for valid Evidence. MCP mode now enters through the same safe startup wrapper whether invoked through dist/main.js or the packaged dispatcher.

Suggested review order

src/domain/errors.ts and src/contracts/toolOutputSchemas.ts for the caller-visible projection contract.
src/server/ registrations and src/main.ts for MCP translation and lifecycle behavior.
src/cliOutput.ts, src/application/ProcessCli.ts, and src/cliProcessCommands.ts for CLI safety and exit semantics.
Setup, uninstall, installer, and reference-source adapters.
Regression tests and docs/user-visible-errors.csv.

AI-assisted implementation and review.

Type of Change

Bug fix
New feature
Documentation update
Performance improvement
Refactoring (no functional change)
Tool contract change (MCP schema modification)

Testing Performed

Unit tests added or updated
TypeScript typecheck passes (npm run typecheck)
Linting passes (npm run lint)
Full test suite passes (npm test) — 60 files, 393 tests
Real Hopper verification performed (npm run verify:hopper)
Linux real Hopper verification performed (npm run verify:hopper:linux) or unavailability explained
Package verification performed (npm run verify:package)

Additional checks:

npm run check
npm run knip (only existing configuration hints)
npm run jscpd (0.99% duplicated TypeScript lines; no threshold failure)
npm run scan:todos
npm pack --dry-run
autoreview against origin/main — no accepted or actionable findings

Real Hopper verification was not run because this environment does not provide an activated Hopper installation and two distinct target binaries. The change does not modify Hopper bridge behavior; package and fake-launcher integration tests cover the changed caller boundaries.

Tool Contract Impact

The 68-tool inventory is unchanged. Expected MCP failures now expose a structured provider-neutral object with category and message; provider identifiers, bridge diagnostics, local paths, validator internals, and raw causes are omitted. Output schemas now require JSON objects instead of accepting unconstrained values where the registered tools return object results.

Related Issues

No linked issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/107 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/13/2026 **Status:** ✅ Merged **Merged:** 7/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `morl/roadmap_implementation` --- ### 📝 Commits (6) - [`3be439c`](https://github.com/morluto/rea/commit/3be439cbf3db2c53c766bf93a4e247fdfb8242ae) feat(errors): add caller-safe typed error projections - [`eb38e4c`](https://github.com/morluto/rea/commit/eb38e4c4024a7d66001b3e69f8309c85492f05c0) feat(mcp): return structured typed tool results - [`af8c4ef`](https://github.com/morluto/rea/commit/af8c4efb4a415e4bdeae0151a8d29cd71af61916) fix(cli): render actionable analysis errors - [`77454dc`](https://github.com/morluto/rea/commit/77454dc8f412e8431bbceff1a4c90ee8f636c9c7) fix(errors): improve recovery guidance - [`12060f6`](https://github.com/morluto/rea/commit/12060f6d8dd3ed61fbd1d07fa604652c6b0a93e2) fix(copy): use agent terminology - [`a93a198`](https://github.com/morluto/rea/commit/a93a198da77d8b4afa54db01d980fe4fc39f5bca) Merge branch 'main' into morl/roadmap_implementation ### 📊 Changes **61 files changed** (+1953 additions, -346 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+12 -12) 📝 `docs/api/functions/application_Setup.detectClients.html` (+1 -1) 📝 `docs/installation.md` (+2 -2) 📝 `docs/roadmap.md` (+1 -1) ➕ `docs/user-visible-errors.csv` (+103 -0) 📝 `install.sh` (+11 -11) 📝 `package.json` (+2 -2) 📝 `scripts/rea.mjs` (+6 -3) 📝 `skills/rea-analysis/SKILL.md` (+1 -1) 📝 `src/application/DirectAnalysis.ts` (+11 -8) 📝 `src/application/ProcessCaptureAuthority.ts` (+5 -3) 📝 `src/application/ProcessCaptureError.ts` (+24 -0) 📝 `src/application/ProcessCaptureLifecycle.ts` (+26 -1) 📝 `src/application/ProcessCli.ts` (+127 -32) 📝 `src/application/ProcessHarness.ts` (+5 -3) 📝 `src/application/ReferenceSourceImportEntries.ts` (+21 -3) 📝 `src/application/ReferenceSourceImportTypes.ts` (+42 -2) 📝 `src/application/Setup.ts` (+6 -24) ➕ `src/application/SetupClients.ts` (+39 -0) 📝 `src/application/Uninstall.ts` (+69 -21) _...and 41 more files_ </details> ### 📄 Description ## Description REA currently forwards provider diagnostics, parser details, local paths, and other implementation-specific text through several CLI and MCP failure paths. Callers cannot reliably decide whether to retry, correct input, request permission, or choose another provider. This change gives expected failures a provider-neutral `category` and actionable `message`, then applies that projection consistently across MCP tools, one-shot commands, setup, uninstall, upgrade, reference-source import, process capture, the installer, and MCP startup/shutdown. It also inventories 102 user-visible error paths in `docs/user-visible-errors.csv`. CLI validation output is sanitized in both normal and `--full-output` formats. Process command failures retain a nonzero exit code, so redirected output cannot be mistaken for valid Evidence. MCP mode now enters through the same safe startup wrapper whether invoked through `dist/main.js` or the packaged dispatcher. ### Suggested review order 1. `src/domain/errors.ts` and `src/contracts/toolOutputSchemas.ts` for the caller-visible projection contract. 2. `src/server/` registrations and `src/main.ts` for MCP translation and lifecycle behavior. 3. `src/cliOutput.ts`, `src/application/ProcessCli.ts`, and `src/cliProcessCommands.ts` for CLI safety and exit semantics. 4. Setup, uninstall, installer, and reference-source adapters. 5. Regression tests and `docs/user-visible-errors.csv`. AI-assisted implementation and review. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Documentation update - [ ] Performance improvement - [ ] Refactoring (no functional change) - [x] Tool contract change (MCP schema modification) ## Testing Performed - [x] Unit tests added or updated - [x] TypeScript typecheck passes (`npm run typecheck`) - [x] Linting passes (`npm run lint`) - [x] Full test suite passes (`npm test`) — 60 files, 393 tests - [ ] Real Hopper verification performed (`npm run verify:hopper`) - [ ] Linux real Hopper verification performed (`npm run verify:hopper:linux`) or unavailability explained - [x] Package verification performed (`npm run verify:package`) Additional checks: - `npm run check` - `npm run knip` (only existing configuration hints) - `npm run jscpd` (0.99% duplicated TypeScript lines; no threshold failure) - `npm run scan:todos` - `npm pack --dry-run` - autoreview against `origin/main` — no accepted or actionable findings Real Hopper verification was not run because this environment does not provide an activated Hopper installation and two distinct target binaries. The change does not modify Hopper bridge behavior; package and fake-launcher integration tests cover the changed caller boundaries. ## Tool Contract Impact The 68-tool inventory is unchanged. Expected MCP failures now expose a structured provider-neutral object with `category` and `message`; provider identifiers, bridge diagnostics, local paths, validator internals, and raw causes are omitted. Output schemas now require JSON objects instead of accepting unconstrained values where the registered tools return object results. ## Related Issues No linked issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:11:38 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:56:06 +00:00

[PR #1862] [MERGED] feat(javascript): resolve exact package import aliases #4858

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#1838

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns