[PR #210] [MERGED] fix: preserve setup diagnostics and clean Knip config #1860

New issue

Closed

opened 2026-10-16 21:11:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:11:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/210
Author: @N0zoM1z0
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @N0zoM1z0

Base: main ← Head: agent/fix-setup-diagnostics

📝 Commits (1)

5a7ccef fix: preserve setup diagnostics and clean Knip config

📊 Changes

5 files changed (+58 additions, -17 deletions)

View changed files

📝 knip.json (+2 -13)
📝 src/application/SetupInstallFailure.ts (+33 -1)
📝 src/config.ts (+6 -3)
📝 tests/config.test.ts (+13 -0)
📝 tests/setupInstallFailure.test.ts (+4 -0)

📄 Description

Summary

preserve distinct setup failure codes and actionable remediation for existing destinations, mount failures, invalid bundles, and copy failures
report the 128-item configuration array limit explicitly
remove all seven redundant Knip configuration patterns

Impact

Setup and configuration failures now retain the information operators need to recover, while Knip runs without configuration-hint noise.

Closes #165
Closes #146
Closes #173

Verification

npx vitest run tests/config.test.ts tests/setupInstallFailure.test.ts --coverage.enabled=false
npm run knip
npm run check after rebasing onto 5231e95 (100 files, 659 tests)

Real Hopper verification was not performed; these changes do not alter Hopper launch or analysis behavior.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/210 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `agent/fix-setup-diagnostics` --- ### 📝 Commits (1) - [`5a7ccef`](https://github.com/morluto/rea/commit/5a7ccefc68e3d7359bfd9a6262701641da380d37) fix: preserve setup diagnostics and clean Knip config ### 📊 Changes **5 files changed** (+58 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `knip.json` (+2 -13) 📝 `src/application/SetupInstallFailure.ts` (+33 -1) 📝 `src/config.ts` (+6 -3) 📝 `tests/config.test.ts` (+13 -0) 📝 `tests/setupInstallFailure.test.ts` (+4 -0) </details> ### 📄 Description ## Summary - preserve distinct setup failure codes and actionable remediation for existing destinations, mount failures, invalid bundles, and copy failures - report the 128-item configuration array limit explicitly - remove all seven redundant Knip configuration patterns ## Impact Setup and configuration failures now retain the information operators need to recover, while Knip runs without configuration-hint noise. Closes #165 Closes #146 Closes #173 ## Verification - `npx vitest run tests/config.test.ts tests/setupInstallFailure.test.ts --coverage.enabled=false` - `npm run knip` - `npm run check` after rebasing onto `5231e95` (100 files, 659 tests) Real Hopper verification was not performed; these changes do not alter Hopper launch or analysis behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:11:53 +00:00