[PR #214] [MERGED] fix(cli): confirm project grant revocation #1867

New issue

Closed

opened 2026-10-16 21:11:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:11:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/214
Author: @N0zoM1z0
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @morluto

Base: main ← Head: agent/policy-revoke-confirmation

📝 Commits (2)

7a4cfb4 fix(cli): confirm project grant revocation
3d71737 test(cli): verify packaged policy revocation

📊 Changes

3 files changed (+215 additions, -2 deletions)

View changed files

📝 docs/mcp-contracts.md (+2 -0)
📝 src/cliPolicyCommands.ts (+58 -2)
➕ tests/cliPolicyCommands.test.ts (+155 -0)

📄 Description

Summary

require an affirmative interactive confirmation before rea policy revoke mutates the project grant store
add --yes / -y as the explicit automation path
fail closed with actionable output for structured and non-interactive invocations
show the exact grant ID in the prompt and document the contract

The root cause was that revocation called the atomic store mutation directly, without an approval boundary in the CLI adapter.

Closes #185

Verification

npm run typecheck
npx oxlint src/cliPolicyCommands.ts tests/cliPolicyCommands.test.ts
npx prettier --check src/cliPolicyCommands.ts tests/cliPolicyCommands.test.ts docs/mcp-contracts.md
npx vitest run tests/cliPolicyCommands.test.ts --coverage.enabled=false (4 tests)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/214 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/policy-revoke-confirmation` --- ### 📝 Commits (2) - [`7a4cfb4`](https://github.com/morluto/rea/commit/7a4cfb4fbd96df34f5502adbf70f5bfb12bbc56c) fix(cli): confirm project grant revocation - [`3d71737`](https://github.com/morluto/rea/commit/3d71737dc9ba8b449c0d174da90c3f1df54789d2) test(cli): verify packaged policy revocation ### 📊 Changes **3 files changed** (+215 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/mcp-contracts.md` (+2 -0) 📝 `src/cliPolicyCommands.ts` (+58 -2) ➕ `tests/cliPolicyCommands.test.ts` (+155 -0) </details> ### 📄 Description ## Summary - require an affirmative interactive confirmation before `rea policy revoke` mutates the project grant store - add `--yes` / `-y` as the explicit automation path - fail closed with actionable output for structured and non-interactive invocations - show the exact grant ID in the prompt and document the contract The root cause was that revocation called the atomic store mutation directly, without an approval boundary in the CLI adapter. Closes #185 ## Verification - `npm run typecheck` - `npx oxlint src/cliPolicyCommands.ts tests/cliPolicyCommands.test.ts` - `npx prettier --check src/cliPolicyCommands.ts tests/cliPolicyCommands.test.ts docs/mcp-contracts.md` - `npx vitest run tests/cliPolicyCommands.test.ts --coverage.enabled=false` (4 tests) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:11:57 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:56:09 +00:00

[PR #1867] [MERGED] fix: order remaining outputs independently of host locale #4863

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#1867

No description provided.

Rows
Columns