[PR #217] [MERGED] fix(reference): preserve distinct parse failures #1869

New issue

Closed

opened 2026-10-16 21:11:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:11:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/217
Author: @N0zoM1z0
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @morluto

Base: main ← Head: agent/reference-failure-dedupe

📝 Commits (2)

543510f fix(reference): preserve distinct parse failures
3d5041f test(reference): cover failure normalization

📊 Changes

4 files changed (+78 additions, -14 deletions)

View changed files

📝 src/application/ReferenceSourceImport.ts (+23 -12)
📝 src/domain/referenceSourceGraph.ts (+6 -1)
📝 tests/referenceSourceGraph.test.ts (+24 -0)
📝 tests/referenceSourceImport.test.ts (+25 -1)

📄 Description

Summary

define one stable parse-failure identity from path, parser, and reason
use that identity consistently for import sorting/deduplication and graph invariants
retain distinct failure reasons for the same source file and parser

The root cause was deduplicating on only (path, parser), which silently discarded diagnostically distinct failures.

Closes #148

Verification

npm run typecheck
npm run lint (existing warnings only)
npm run format:check
affected setup/runtime/reference suite: 34 tests passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/217 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/reference-failure-dedupe` --- ### 📝 Commits (2) - [`543510f`](https://github.com/morluto/rea/commit/543510f62fd257b42e6a7dfc876112dda0e0ea01) fix(reference): preserve distinct parse failures - [`3d5041f`](https://github.com/morluto/rea/commit/3d5041fb2f8964c30f0273615b4f039620eef0bf) test(reference): cover failure normalization ### 📊 Changes **4 files changed** (+78 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/application/ReferenceSourceImport.ts` (+23 -12) 📝 `src/domain/referenceSourceGraph.ts` (+6 -1) 📝 `tests/referenceSourceGraph.test.ts` (+24 -0) 📝 `tests/referenceSourceImport.test.ts` (+25 -1) </details> ### 📄 Description ## Summary - define one stable parse-failure identity from path, parser, and reason - use that identity consistently for import sorting/deduplication and graph invariants - retain distinct failure reasons for the same source file and parser The root cause was deduplicating on only `(path, parser)`, which silently discarded diagnostically distinct failures. Closes #148 ## Verification - `npm run typecheck` - `npm run lint` (existing warnings only) - `npm run format:check` - affected setup/runtime/reference suite: 34 tests passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:11:59 +00:00