[PR #222] [MERGED] fix(evidence): enforce the combined record limit #1873

New issue

Closed

opened 2026-10-16 21:12:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:12:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/222
Author: @N0zoM1z0
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @morluto

Base: main ← Head: agent/evidence-combined-limit

📝 Commits (1)

834c70c fix(evidence): enforce the combined record limit

📊 Changes

2 files changed (+52 additions, -2 deletions)

View changed files

📝 src/application/EvidenceLedger.ts (+11 -2)
📝 tests/evidence.test.ts (+41 -0)

📄 Description

Summary

enforce maxRecords against evidence records plus residual-unknown revisions for direct writes
use the same combined-count predicate as atomic/import validation
preserve duplicate idempotence while rejecting true over-limit additions

The root cause was a separate direct-record check that counted only evidence records, bypassing the ledger’s combined cardinality invariant.

Verification

tests/evidence.test.ts: 13/13 passed
npm run typecheck
touched-file oxlint
touched-file Prettier check

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/222 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/evidence-combined-limit` --- ### 📝 Commits (1) - [`834c70c`](https://github.com/morluto/rea/commit/834c70cf4b9c8dca000c7a20491215d1acc0db89) fix(evidence): enforce the combined record limit ### 📊 Changes **2 files changed** (+52 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/application/EvidenceLedger.ts` (+11 -2) 📝 `tests/evidence.test.ts` (+41 -0) </details> ### 📄 Description ## Summary - enforce `maxRecords` against evidence records plus residual-unknown revisions for direct writes - use the same combined-count predicate as atomic/import validation - preserve duplicate idempotence while rejecting true over-limit additions The root cause was a separate direct-record check that counted only evidence records, bypassing the ledger’s combined cardinality invariant. ## Verification - `tests/evidence.test.ts`: 13/13 passed - `npm run typecheck` - touched-file oxlint - touched-file Prettier check --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:12:01 +00:00