[PR #223] [MERGED] fix(doctor): honor explicit Hopper launcher #1874

New issue

Closed

opened 2026-10-16 21:12:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:12:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/223
Author: @N0zoM1z0
Created: 7/14/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @morluto

Base: main ← Head: agent/doctor-explicit-launcher

📝 Commits (1)

9208592 fix(doctor): honor explicit Hopper launcher

📊 Changes

2 files changed (+44 additions, -13 deletions)

View changed files

📝 src/application/Doctor.ts (+25 -13)
📝 tests/doctor.test.ts (+19 -0)

📄 Description

Summary

treat an explicit HOPPER_LAUNCHER_PATH as authoritative during diagnostics
stop searching defaults after that configured path fails validation
report the actual configured path as config_drift with exact remediation

The root cause was mixing an explicit runtime override into a fallback candidate list. Doctor could bless a different executable even though runtime would continue using the broken override.

Verification

Doctor/upgrade focused suites: 27/27 passed
npm run typecheck
touched-file oxlint
touched-file Prettier check

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/223 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/doctor-explicit-launcher` --- ### 📝 Commits (1) - [`9208592`](https://github.com/morluto/rea/commit/9208592f41ed920c32206c78fcf43c8d7db77f22) fix(doctor): honor explicit Hopper launcher ### 📊 Changes **2 files changed** (+44 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/application/Doctor.ts` (+25 -13) 📝 `tests/doctor.test.ts` (+19 -0) </details> ### 📄 Description ## Summary - treat an explicit `HOPPER_LAUNCHER_PATH` as authoritative during diagnostics - stop searching defaults after that configured path fails validation - report the actual configured path as `config_drift` with exact remediation The root cause was mixing an explicit runtime override into a fallback candidate list. Doctor could bless a different executable even though runtime would continue using the broken override. ## Verification - Doctor/upgrade focused suites: 27/27 passed - `npm run typecheck` - touched-file oxlint - touched-file Prettier check --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:12:03 +00:00