[PR #285] [MERGED] feat: add managed characterization and reconstruction coverage #1927

Closed
opened 2026-10-16 21:12:34 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/285
Author: @morluto
Created: 7/16/2026
Status: ✅ Merged
Merged: 7/16/2026
Merged by: @morluto

Base: main ← Head: feat/runtime-characterization-coverage


📝 Commits (2)

  • 1943496 feat: add managed characterization and coverage closure
  • b15a9ec fix: satisfy dead-code and generated-doc checks

📊 Changes

158 files changed (+7544 additions, -245 deletions)

View changed files

📝 README.md (+1 -1)
📝 README_ar.md (+1 -1)
📝 README_ja.md (+1 -1)
📝 README_ko.md (+1 -1)
📝 README_zh.md (+1 -1)
📝 docs/api/assets/hierarchy.js (+1 -1)
📝 docs/api/assets/navigation.js (+1 -1)
📝 docs/api/assets/search.js (+1 -1)
📝 docs/api/classes/application_BinarySession.BinarySession.html (+76 -28)
➕ docs/api/classes/application_InstrumentedJavaScriptReplayHost.InstrumentedJavaScriptReplayHost.html (+176 -0)
📝 docs/api/classes/application_PermissionAuthority.PermissionPathError.html (+1 -1)
📝 docs/api/classes/application_ProcessCaptureError.ProcessCaptureError.html (+1 -1)
📝 docs/api/classes/application_ProjectPermissionStore.ProjectPermissionStoreError.html (+1 -1)
➕ docs/api/classes/browser_BrowserProcessStartup.BrowserStartupError.html (+123 -0)
📝 docs/api/classes/domain_permissionPolicy.PermissionGrantError.html (+1 -1)
📝 docs/api/classes/ghidra_GhidraLauncher.GhidraLaunchError.html (+1 -1)
📝 docs/api/classes/ghidra_GhidraSessionError.GhidraSessionError.html (+1 -1)
📝 docs/api/classes/ghidra_protocol.GhidraRemoteError.html (+1 -1)
📝 docs/api/functions/application_CapabilityInventory.buildCapabilityInventory.html (+2 -2)
📝 docs/api/functions/application_Doctor.runDoctor.html (+3 -3)

...and 80 more files

📄 Description

Description

Chrome startup failures previously collapsed CDP discovery into a generic timeout, Node runtime selection could not distinguish broken from ambiguous installations, and managed characterization/reconstruction coverage lacked committed, approval-separated workflows.

This change:

  • reports Chrome process exit, DevToolsActivePort state, bounded stderr, executable metadata, and startup timing when CDP discovery fails;
  • makes doctor classify missing, broken, shadowed, and ambiguous Node/npm/npx installations with actionable path and version evidence;
  • adds preparation and execution approvals for exact-digest Node characterization, with deterministic non-mutating export instrumentation and Evidence v2 linkage;
  • adds content-addressed reconstruction coverage workspaces, closure evaluation, next-probe reporting, revision resources, and optional exact workspace binding in verify_reconstruction.

Provider-specific runtime mechanics remain in adapters and application services; the characterization and coverage models stay provider-neutral.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Tool contract change

Testing Performed

  • npm run typecheck
  • npm run build
  • npm run lint
  • npm run format:check
  • npm run docs:check
  • npm run verify:package
  • npm pack --dry-run
  • Focused Vitest suites for browser startup, doctor/runtime diagnostics, characterization, reconstruction coverage, MCP workflows, contracts, catalog, and server identity
  • Full npm run check: parallel runtime and browser CLI suites hit resource-sensitive timeouts; the affected focused suites pass.
  • Real Chrome verification: no Chrome-family executable was available locally; the CI real-browser lane remains the end-to-end proof.
  • Real Hopper/Ghidra verification: provider behavior is unchanged and these verifiers were not run.

Tool Contract Impact

Adds four application tools:

  • prepare_node_characterization
  • execute_node_characterization
  • commit_reconstruction_coverage
  • query_reconstruction_coverage

Adds rea://reconstruction-coverage/{workspaceId}/revision/{revision} and an optional reconstruction-coverage binding on verify_reconstruction. The generated catalog records 95 MCP tools, 55 CLI commands, and 8 resource templates.

Suggested Review Order

  1. Provider-neutral characterization, JavaScript instrumentation, and reconstruction coverage domain models.
  2. Node characterization, coverage persistence/services, and runtime diagnostics.
  3. CLI/MCP contracts, approval effects, Evidence resources, and verification binding.
  4. Regression and workflow tests.
  5. Generated catalog and API documentation.

Closes #279
Closes #268
Closes #267
Closes #262


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/285 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/16/2026 **Status:** ✅ Merged **Merged:** 7/16/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `feat/runtime-characterization-coverage` --- ### 📝 Commits (2) - [`1943496`](https://github.com/morluto/rea/commit/194349683a19ee8b35c1bd9b124d032e83e6867a) feat: add managed characterization and coverage closure - [`b15a9ec`](https://github.com/morluto/rea/commit/b15a9ecfef55dec00b92babf92883f6dedaa2209) fix: satisfy dead-code and generated-doc checks ### 📊 Changes **158 files changed** (+7544 additions, -245 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `README_ar.md` (+1 -1) 📝 `README_ja.md` (+1 -1) 📝 `README_ko.md` (+1 -1) 📝 `README_zh.md` (+1 -1) 📝 `docs/api/assets/hierarchy.js` (+1 -1) 📝 `docs/api/assets/navigation.js` (+1 -1) 📝 `docs/api/assets/search.js` (+1 -1) 📝 `docs/api/classes/application_BinarySession.BinarySession.html` (+76 -28) ➕ `docs/api/classes/application_InstrumentedJavaScriptReplayHost.InstrumentedJavaScriptReplayHost.html` (+176 -0) 📝 `docs/api/classes/application_PermissionAuthority.PermissionPathError.html` (+1 -1) 📝 `docs/api/classes/application_ProcessCaptureError.ProcessCaptureError.html` (+1 -1) 📝 `docs/api/classes/application_ProjectPermissionStore.ProjectPermissionStoreError.html` (+1 -1) ➕ `docs/api/classes/browser_BrowserProcessStartup.BrowserStartupError.html` (+123 -0) 📝 `docs/api/classes/domain_permissionPolicy.PermissionGrantError.html` (+1 -1) 📝 `docs/api/classes/ghidra_GhidraLauncher.GhidraLaunchError.html` (+1 -1) 📝 `docs/api/classes/ghidra_GhidraSessionError.GhidraSessionError.html` (+1 -1) 📝 `docs/api/classes/ghidra_protocol.GhidraRemoteError.html` (+1 -1) 📝 `docs/api/functions/application_CapabilityInventory.buildCapabilityInventory.html` (+2 -2) 📝 `docs/api/functions/application_Doctor.runDoctor.html` (+3 -3) _...and 80 more files_ </details> ### 📄 Description ## Description Chrome startup failures previously collapsed CDP discovery into a generic timeout, Node runtime selection could not distinguish broken from ambiguous installations, and managed characterization/reconstruction coverage lacked committed, approval-separated workflows. This change: - reports Chrome process exit, DevToolsActivePort state, bounded stderr, executable metadata, and startup timing when CDP discovery fails; - makes doctor classify missing, broken, shadowed, and ambiguous Node/npm/npx installations with actionable path and version evidence; - adds preparation and execution approvals for exact-digest Node characterization, with deterministic non-mutating export instrumentation and Evidence v2 linkage; - adds content-addressed reconstruction coverage workspaces, closure evaluation, next-probe reporting, revision resources, and optional exact workspace binding in verify_reconstruction. Provider-specific runtime mechanics remain in adapters and application services; the characterization and coverage models stay provider-neutral. ## Type of Change - [x] Bug fix - [x] New feature - [x] Documentation update - [x] Tool contract change ## Testing Performed - [x] npm run typecheck - [x] npm run build - [x] npm run lint - [x] npm run format:check - [x] npm run docs:check - [x] npm run verify:package - [x] npm pack --dry-run - [x] Focused Vitest suites for browser startup, doctor/runtime diagnostics, characterization, reconstruction coverage, MCP workflows, contracts, catalog, and server identity - [ ] Full npm run check: parallel runtime and browser CLI suites hit resource-sensitive timeouts; the affected focused suites pass. - [ ] Real Chrome verification: no Chrome-family executable was available locally; the CI real-browser lane remains the end-to-end proof. - [ ] Real Hopper/Ghidra verification: provider behavior is unchanged and these verifiers were not run. ## Tool Contract Impact Adds four application tools: - prepare_node_characterization - execute_node_characterization - commit_reconstruction_coverage - query_reconstruction_coverage Adds rea://reconstruction-coverage/{workspaceId}/revision/{revision} and an optional reconstruction-coverage binding on verify_reconstruction. The generated catalog records 95 MCP tools, 55 CLI commands, and 8 resource templates. ## Suggested Review Order 1. Provider-neutral characterization, JavaScript instrumentation, and reconstruction coverage domain models. 2. Node characterization, coverage persistence/services, and runtime diagnostics. 3. CLI/MCP contracts, approval effects, Evidence resources, and verification binding. 4. Regression and workflow tests. 5. Generated catalog and API documentation. ## Related Issues Closes #279 Closes #268 Closes #267 Closes #262 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-16 21:12:34 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#1927
No description provided.