[PR #292] [MERGED] fix(npm): use latest entry points, remove install scripts, and rename skill #1928

Closed
opened 2026-10-16 21:12:35 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/292
Author: @morluto
Created: 7/17/2026
Status: ✅ Merged
Merged: 7/17/2026
Merged by: @morluto

Base: main ← Head: fix/npm-entry-points


📝 Commits (4)

  • 34252f5 fix(npm): use latest entry points without install scripts
  • 9356634 feat(skill): rename skill to reverse-engineer-anything
  • 2d22731 fix(ci): remove retired native rebuild steps
  • 4c69e61 fix(skill): disclose retired skill cleanup

📊 Changes

45 files changed (+573 additions, -230 deletions)

View changed files

📝 .github/workflows/ci.yml (+0 -2)
📝 .github/workflows/real-hopper-linux.yml (+1 -2)
📝 .github/workflows/real-hopper.yml (+1 -2)
📝 CONTRIBUTING.md (+4 -5)
📝 README.md (+25 -20)
📝 README_ar.md (+6 -6)
📝 README_ja.md (+5 -5)
📝 README_ko.md (+5 -5)
📝 README_zh.md (+5 -5)
📝 docs/api/functions/application_ProcessCaptureCapability.probeProcessCaptureCapability.html (+1 -1)
📝 docs/api/functions/application_ProcessHarness.captureProcessScenario.html (+1 -1)
📝 docs/api/functions/application_SetupPlan.setupPlan.html (+1 -1)
📝 docs/api/functions/application_SetupSkill.canonicalSkillNeedsInstall.html (+1 -1)
📝 docs/api/functions/application_SetupSkill.installCanonicalSkill.html (+1 -1)
📝 docs/api/types/application_ProcessCaptureCapability.ProcessCaptureCapability.html (+1 -1)
📝 docs/installation.md (+5 -0)
📝 docs/product-catalog.json (+1 -1)
📝 package-lock.json (+93 -18)
📝 package.json (+2 -9)
📝 scripts/generate-package-metadata.mjs (+2 -2)

...and 25 more files

📄 Description

Description

Bare npx rea-agents entry points could resolve a stale project-local REA version, including after setup persisted that command in client configuration. The package also relied on a root postinstall script to prepare node-pty, so clients that block lifecycle scripts could install REA without a usable process-capture backend.

This change:

  • makes rea-agents@latest canonical for npx CLI and MCP registrations, reports bare legacy registrations as stale, migrates them through the existing backup-preserving setup transaction, and retains uninstall compatibility;
  • replaces the lifecycle-dependent PTY package with prebuilt optional platform packages and lazy-loads the backend so the rest of the CLI still starts when the platform binary is unavailable;
  • renames the bundled skill from rea-analysis to reverse-engineer-anything and increments its version to 21;
  • makes setup disclose the retired-skill cleanup before approval, install and verify the new skill first, back up the retired SKILL.md, reject a symlinked retired directory, and remove the retired entry; uninstall recognizes both names;
  • extends package verification to install with lifecycle scripts disabled, probe the packaged PTY, verify graceful degradation without the optional platform package, and exercise the skill-name migration end to end;
  • removes stale rebuild:native steps from coverage and package E2E workflows, and makes real-Hopper installed-package lanes use --ignore-scripts;
  • updates installation guidance, localized command examples, and generated API documentation.

Suggested review order: npm identity and setup registration, PTY dependency/runtime loading, skill migration and uninstall, package/workflow verification, then documentation and generated output.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Performance improvement
  • Refactoring (no functional change)
  • Tool contract change (MCP schema modification)

Testing Performed

  • Unit tests added or updated
  • TypeScript typecheck passes (npm run typecheck)
  • Linting passes (npm run lint)
  • Full test suite passes (npm test)
  • Real Hopper verification performed (npm run verify:hopper)
  • Linux real Hopper verification performed (npm run verify:hopper:linux) or unavailability explained
  • Real browser verification performed (npm run verify:browser) or unavailability explained
  • Package verification performed (npm run verify:package)

Validation commands run:

  • npm run check
  • npm run verify:package
  • npx vitest run --coverage.enabled=false tests/packageInstallWorkflow.test.ts tests/analysisSnapshot.test.ts
  • npx vitest run --coverage.enabled=false tests/setup.test.ts tests/setupSkill.test.ts

Real Hopper and Ghidra verification were not run locally because this change does not modify either provider. The repository workflows retain their installed-package provider lanes.

Tool Contract Impact

None. MCP tool schemas and the canonical tool inventory are unchanged.

Closes #291


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/292 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/17/2026 **Status:** ✅ Merged **Merged:** 7/17/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/npm-entry-points` --- ### 📝 Commits (4) - [`34252f5`](https://github.com/morluto/rea/commit/34252f55e963fcd63c0fd127dc249ba2c8398082) fix(npm): use latest entry points without install scripts - [`9356634`](https://github.com/morluto/rea/commit/9356634ccba8d913a376798dae47bb3c4a86c07a) feat(skill): rename skill to reverse-engineer-anything - [`2d22731`](https://github.com/morluto/rea/commit/2d22731ebb3f81483ec8a561ed8b1cb313b4eac1) fix(ci): remove retired native rebuild steps - [`4c69e61`](https://github.com/morluto/rea/commit/4c69e6120a2c0a630272e845cda2112724c4be7b) fix(skill): disclose retired skill cleanup ### 📊 Changes **45 files changed** (+573 additions, -230 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+0 -2) 📝 `.github/workflows/real-hopper-linux.yml` (+1 -2) 📝 `.github/workflows/real-hopper.yml` (+1 -2) 📝 `CONTRIBUTING.md` (+4 -5) 📝 `README.md` (+25 -20) 📝 `README_ar.md` (+6 -6) 📝 `README_ja.md` (+5 -5) 📝 `README_ko.md` (+5 -5) 📝 `README_zh.md` (+5 -5) 📝 `docs/api/functions/application_ProcessCaptureCapability.probeProcessCaptureCapability.html` (+1 -1) 📝 `docs/api/functions/application_ProcessHarness.captureProcessScenario.html` (+1 -1) 📝 `docs/api/functions/application_SetupPlan.setupPlan.html` (+1 -1) 📝 `docs/api/functions/application_SetupSkill.canonicalSkillNeedsInstall.html` (+1 -1) 📝 `docs/api/functions/application_SetupSkill.installCanonicalSkill.html` (+1 -1) 📝 `docs/api/types/application_ProcessCaptureCapability.ProcessCaptureCapability.html` (+1 -1) 📝 `docs/installation.md` (+5 -0) 📝 `docs/product-catalog.json` (+1 -1) 📝 `package-lock.json` (+93 -18) 📝 `package.json` (+2 -9) 📝 `scripts/generate-package-metadata.mjs` (+2 -2) _...and 25 more files_ </details> ### 📄 Description ## Description Bare `npx rea-agents` entry points could resolve a stale project-local REA version, including after setup persisted that command in client configuration. The package also relied on a root `postinstall` script to prepare `node-pty`, so clients that block lifecycle scripts could install REA without a usable process-capture backend. This change: - makes `rea-agents@latest` canonical for npx CLI and MCP registrations, reports bare legacy registrations as stale, migrates them through the existing backup-preserving setup transaction, and retains uninstall compatibility; - replaces the lifecycle-dependent PTY package with prebuilt optional platform packages and lazy-loads the backend so the rest of the CLI still starts when the platform binary is unavailable; - renames the bundled skill from `rea-analysis` to `reverse-engineer-anything` and increments its version to 21; - makes setup disclose the retired-skill cleanup before approval, install and verify the new skill first, back up the retired `SKILL.md`, reject a symlinked retired directory, and remove the retired entry; uninstall recognizes both names; - extends package verification to install with lifecycle scripts disabled, probe the packaged PTY, verify graceful degradation without the optional platform package, and exercise the skill-name migration end to end; - removes stale `rebuild:native` steps from coverage and package E2E workflows, and makes real-Hopper installed-package lanes use `--ignore-scripts`; - updates installation guidance, localized command examples, and generated API documentation. Suggested review order: npm identity and setup registration, PTY dependency/runtime loading, skill migration and uninstall, package/workflow verification, then documentation and generated output. ## Type of Change - [x] Bug fix - [x] New feature - [ ] Documentation update - [ ] Performance improvement - [ ] Refactoring (no functional change) - [ ] Tool contract change (MCP schema modification) ## Testing Performed - [x] Unit tests added or updated - [x] TypeScript typecheck passes (`npm run typecheck`) - [x] Linting passes (`npm run lint`) - [x] Full test suite passes (`npm test`) - [ ] Real Hopper verification performed (`npm run verify:hopper`) - [ ] Linux real Hopper verification performed (`npm run verify:hopper:linux`) or unavailability explained - [ ] Real browser verification performed (`npm run verify:browser`) or unavailability explained - [x] Package verification performed (`npm run verify:package`) Validation commands run: - `npm run check` - `npm run verify:package` - `npx vitest run --coverage.enabled=false tests/packageInstallWorkflow.test.ts tests/analysisSnapshot.test.ts` - `npx vitest run --coverage.enabled=false tests/setup.test.ts tests/setupSkill.test.ts` Real Hopper and Ghidra verification were not run locally because this change does not modify either provider. The repository workflows retain their installed-package provider lanes. ## Tool Contract Impact None. MCP tool schemas and the canonical tool inventory are unchanged. ## Related Issues Closes #291 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-16 21:12:35 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#1928
No description provided.