[PR #293] [MERGED] refactor(skill): keep only the canonical skill identity #1929

New issue

Closed

opened 2026-10-16 21:12:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:12:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/293
Author: @morluto
Created: 7/17/2026
Status: ✅ Merged
Merged: 7/17/2026
Merged by: @morluto

Base: main ← Head: fix/npm-entry-points

📝 Commits (2)

8cf0dd2 refactor(skill): remove legacy skill compatibility
1341c24 Merge branch 'main' into fix/npm-entry-points

📊 Changes

9 files changed (+17 additions, -153 deletions)

View changed files

📝 docs/api/functions/application_SetupSkill.installCanonicalSkill.html (+1 -1)
📝 scripts/verify-package.mjs (+5 -20)
📝 src/application/SetupPlan.ts (+1 -1)
📝 src/application/SetupSkill.ts (+3 -43)
📝 src/application/Uninstall.ts (+6 -26)
📝 src/identity.ts (+0 -1)
📝 tests/setup.test.ts (+0 -4)
📝 tests/setupLifecycle.test.ts (+0 -4)
📝 tests/setupSkill.test.ts (+1 -53)

📄 Description

Description

The bundled skill is now named reverse-engineer-anything, but setup and uninstall still carried compatibility references for its retired name.

This follow-up:

removes the retired skill name from product identity metadata;
makes setup install and inspect only reverse-engineer-anything;
makes uninstall remove only the canonical managed skill path;
removes the retired-name migration fixtures and package assertions.

Existing installations under the retired directory are intentionally left untouched. The canonical skill is installed independently on the next rea setup run.

Testing Performed

npm run check
npm run verify:package
npx vitest run --coverage.enabled=false tests/setup.test.ts tests/setupSkill.test.ts tests/setupLifecycle.test.ts tests/identity.test.ts tests/packageInstallWorkflow.test.ts

Tool Contract Impact

None. MCP schemas and the canonical tool inventory are unchanged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/293 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/17/2026 **Status:** ✅ Merged **Merged:** 7/17/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/npm-entry-points` --- ### 📝 Commits (2) - [`8cf0dd2`](https://github.com/morluto/rea/commit/8cf0dd2bf645d18afe6a9c8493178bdd905c0647) refactor(skill): remove legacy skill compatibility - [`1341c24`](https://github.com/morluto/rea/commit/1341c244119302ed579d3b5c7e46afb7c8d5dd10) Merge branch 'main' into fix/npm-entry-points ### 📊 Changes **9 files changed** (+17 additions, -153 deletions) <details> <summary>View changed files</summary> 📝 `docs/api/functions/application_SetupSkill.installCanonicalSkill.html` (+1 -1) 📝 `scripts/verify-package.mjs` (+5 -20) 📝 `src/application/SetupPlan.ts` (+1 -1) 📝 `src/application/SetupSkill.ts` (+3 -43) 📝 `src/application/Uninstall.ts` (+6 -26) 📝 `src/identity.ts` (+0 -1) 📝 `tests/setup.test.ts` (+0 -4) 📝 `tests/setupLifecycle.test.ts` (+0 -4) 📝 `tests/setupSkill.test.ts` (+1 -53) </details> ### 📄 Description ## Description The bundled skill is now named `reverse-engineer-anything`, but setup and uninstall still carried compatibility references for its retired name. This follow-up: - removes the retired skill name from product identity metadata; - makes setup install and inspect only `reverse-engineer-anything`; - makes uninstall remove only the canonical managed skill path; - removes the retired-name migration fixtures and package assertions. Existing installations under the retired directory are intentionally left untouched. The canonical skill is installed independently on the next `rea setup` run. ## Testing Performed - `npm run check` - `npm run verify:package` - `npx vitest run --coverage.enabled=false tests/setup.test.ts tests/setupSkill.test.ts tests/setupLifecycle.test.ts tests/identity.test.ts tests/packageInstallWorkflow.test.ts` ## Tool Contract Impact None. MCP schemas and the canonical tool inventory are unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:12:35 +00:00