[PR #298] fix(managed): preserve page incompleteness in graph and comparison #1934

New issue

Closed

opened 2026-10-16 21:12:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:12:37 +00:00

Owner

Original Pull Request: https://github.com/morluto/rea/pull/298

State: closed
Merged: Yes

What

Add a shared fail-closed assessment for known-total collection pages.
Derive managed graph omissions from source totals and downstream projection limits.
Propagate source coverage onto projected nodes, observations, and containment edges.
Classify unmatched methods and fields as unknown when the opposite page is incomplete.
Regenerate TypeDoc for the new coverage helpers.

Why

Managed graph projection previously counted only returned array elements, so source pagination could disappear from aggregate and per-fact coverage. Member comparison also treated an item missing from an incomplete opposite page as definitively added or removed. Both behaviors turned unobserved data into false certainty.

Impact

Known source omissions are now reported exactly. Parser-level unknown coverage still dominates rather than inventing an exact omission count. Comparisons only report additions and removals when absence was actually observable; otherwise they emit an actionable unknown-within-unobserved-page limitation.

Checks

npm run check
REA_ILSPY_CMD_PATH=/home/pentester/.dotnet/tools/ilspycmd npm run verify:managed
npm run knip
npm run jscpd
npm run scan:todos
targeted managed graph and comparison Vitest suites

**Original Pull Request:** https://github.com/morluto/rea/pull/298 **State:** closed **Merged:** Yes --- ## What - Add a shared fail-closed assessment for known-total collection pages. - Derive managed graph omissions from source totals and downstream projection limits. - Propagate source coverage onto projected nodes, observations, and containment edges. - Classify unmatched methods and fields as unknown when the opposite page is incomplete. - Regenerate TypeDoc for the new coverage helpers. ## Why Managed graph projection previously counted only returned array elements, so source pagination could disappear from aggregate and per-fact coverage. Member comparison also treated an item missing from an incomplete opposite page as definitively added or removed. Both behaviors turned unobserved data into false certainty. ## Impact Known source omissions are now reported exactly. Parser-level unknown coverage still dominates rather than inventing an exact omission count. Comparisons only report additions and removals when absence was actually observable; otherwise they emit an actionable unknown-within-unobserved-page limitation. ## Checks - npm run check - REA_ILSPY_CMD_PATH=/home/pentester/.dotnet/tools/ilspycmd npm run verify:managed - npm run knip - npm run jscpd - npm run scan:todos - targeted managed graph and comparison Vitest suites

bsakaguchi

2026-10-16 21:12:37 +00:00