[PR #300] [MERGED] docs(managed): align normalized CIL claims with shipped v1 semantics #1936

New issue

Closed

opened 2026-10-16 21:12:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:12:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/300
Author: @N0zoM1z0
Created: 7/17/2026
Status: ✅ Merged
Merged: 7/17/2026
Merged by: @N0zoM1z0

Base: main ← Head: agent/docs-managed-normalized-cil-v1

📝 Commits (1)

3f788e9 docs(managed): align normalized CIL claims with shipped v1 semantics

📊 Changes

19 files changed (+183 additions, -48 deletions)

View changed files

📝 README.md (+1 -1)
📝 docs/adr/0003-managed-code-evidence-and-provider-boundary.md (+49 -17)
📝 docs/api/types/domain_managedArtifact.ManagedArtifactInspection.html (+1 -1)
📝 docs/api/types/domain_managedArtifact.ManagedMemberInspection.html (+1 -1)
📝 docs/api/types/domain_managedArtifact.ManagedNativeBoundaryInspection.html (+1 -1)
📝 docs/api/types/domain_managedArtifact.ManagedParseIssue.html (+1 -1)
📝 docs/api/variables/contracts_managedToolContracts.MANAGED_TOOL_CONTRACTS.html (+1 -1)
📝 docs/api/variables/contracts_managedWorkflowToolContracts.MANAGED_WORKFLOW_TOOL_CONTRACTS.html (+1 -1)
📝 docs/api/variables/contracts_toolContracts.TOOL_CONTRACTS.html (+1 -1)
📝 docs/api/variables/domain_managedArtifact.managedArtifactInspectionSchema.html (+1 -1)
📝 docs/api/variables/domain_managedArtifact.managedMemberInspectionSchema.html (+1 -1)
📝 docs/api/variables/domain_managedArtifact.managedNativeBoundaryInspectionSchema.html (+1 -1)
📝 docs/managed-code-analysis.md (+59 -11)
📝 docs/product-catalog.json (+2 -2)
📝 skills/reverse-engineer-anything/SKILL.md (+1 -1)
📝 src/contracts/managedToolContracts.ts (+1 -1)
📝 src/contracts/managedWorkflowToolContracts.ts (+3 -3)
📝 src/domain/managedArtifact.ts (+10 -2)
📝 tests/managedArtifactProvider.test.ts (+47 -0)

📄 Description

What

define the exact shipped v1 byte boundaries for il_sha256 and normalized_il_sha256
document the tuple serialization, operand projections, unavailable states, known collisions, and the required normalized-CIL v2 boundary
correct README, ADR, MCP tool descriptions, output-schema descriptions, packaged skill metadata, product catalog digests, and generated API docs
add a reproducible nop; ret golden vector and verify that tiny and fat headers with identical CIL keep the same two hashes while header observations remain distinct

Why

The accepted ADR overclaimed the current implementation. It said the exact body hash included headers and extra sections and that normalized CIL resolved tokens, retained complete switch targets, and committed exception semantics. The shipped parser actually hashes only raw CIL bytes for il_sha256, while normalized_il_sha256 hashes UTF-8 JSON instruction tuples, retains build-local tokens, and stores only the switch case count. Leaving those claims in caller-visible documentation could make agents treat a structural fingerprint as semantic equivalence evidence.

Impact

This is an additive documentation and schema-description correction. Existing field names, wire values, parsing behavior, and tool inventory remain compatible. Callers now receive accurate descriptions and can distinguish exact raw CIL identity from the limited member-result-v1 decoded-tuple fingerprint. Full token canonicalization, complete control-flow operands, locals and exception commitments, and an independent algorithm version remain explicit v2 work.

Checks

npm run check — 156 test files, 1053 tests; 81.94% statements, 70.04% branches, 85.59% functions, 84.11% lines
npm run verify:managed — 12 conformance slices passed
npm run verify:package — packaged CLI, skill, 95-tool MCP catalog, and lifecycle checks passed
npm run knip
npm run jscpd — 157 baseline clones
npm run scan:todos
post-commit npm run docs:check

No operator-local managed manifest or BYO ILSpy command was configured, so no operator-local application or real ILSpy oracle claim is made.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/300 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/17/2026 **Status:** ✅ Merged **Merged:** 7/17/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `agent/docs-managed-normalized-cil-v1` --- ### 📝 Commits (1) - [`3f788e9`](https://github.com/morluto/rea/commit/3f788e9065d5ce457ba174c13bc8e4e0b74d5156) docs(managed): align normalized CIL claims with shipped v1 semantics ### 📊 Changes **19 files changed** (+183 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `docs/adr/0003-managed-code-evidence-and-provider-boundary.md` (+49 -17) 📝 `docs/api/types/domain_managedArtifact.ManagedArtifactInspection.html` (+1 -1) 📝 `docs/api/types/domain_managedArtifact.ManagedMemberInspection.html` (+1 -1) 📝 `docs/api/types/domain_managedArtifact.ManagedNativeBoundaryInspection.html` (+1 -1) 📝 `docs/api/types/domain_managedArtifact.ManagedParseIssue.html` (+1 -1) 📝 `docs/api/variables/contracts_managedToolContracts.MANAGED_TOOL_CONTRACTS.html` (+1 -1) 📝 `docs/api/variables/contracts_managedWorkflowToolContracts.MANAGED_WORKFLOW_TOOL_CONTRACTS.html` (+1 -1) 📝 `docs/api/variables/contracts_toolContracts.TOOL_CONTRACTS.html` (+1 -1) 📝 `docs/api/variables/domain_managedArtifact.managedArtifactInspectionSchema.html` (+1 -1) 📝 `docs/api/variables/domain_managedArtifact.managedMemberInspectionSchema.html` (+1 -1) 📝 `docs/api/variables/domain_managedArtifact.managedNativeBoundaryInspectionSchema.html` (+1 -1) 📝 `docs/managed-code-analysis.md` (+59 -11) 📝 `docs/product-catalog.json` (+2 -2) 📝 `skills/reverse-engineer-anything/SKILL.md` (+1 -1) 📝 `src/contracts/managedToolContracts.ts` (+1 -1) 📝 `src/contracts/managedWorkflowToolContracts.ts` (+3 -3) 📝 `src/domain/managedArtifact.ts` (+10 -2) 📝 `tests/managedArtifactProvider.test.ts` (+47 -0) </details> ### 📄 Description ## What - define the exact shipped v1 byte boundaries for `il_sha256` and `normalized_il_sha256` - document the tuple serialization, operand projections, unavailable states, known collisions, and the required normalized-CIL v2 boundary - correct README, ADR, MCP tool descriptions, output-schema descriptions, packaged skill metadata, product catalog digests, and generated API docs - add a reproducible `nop; ret` golden vector and verify that tiny and fat headers with identical CIL keep the same two hashes while header observations remain distinct ## Why The accepted ADR overclaimed the current implementation. It said the exact body hash included headers and extra sections and that normalized CIL resolved tokens, retained complete switch targets, and committed exception semantics. The shipped parser actually hashes only raw CIL bytes for `il_sha256`, while `normalized_il_sha256` hashes UTF-8 JSON instruction tuples, retains build-local tokens, and stores only the switch case count. Leaving those claims in caller-visible documentation could make agents treat a structural fingerprint as semantic equivalence evidence. ## Impact This is an additive documentation and schema-description correction. Existing field names, wire values, parsing behavior, and tool inventory remain compatible. Callers now receive accurate descriptions and can distinguish exact raw CIL identity from the limited member-result-v1 decoded-tuple fingerprint. Full token canonicalization, complete control-flow operands, locals and exception commitments, and an independent algorithm version remain explicit v2 work. ## Checks - `npm run check` — 156 test files, 1053 tests; 81.94% statements, 70.04% branches, 85.59% functions, 84.11% lines - `npm run verify:managed` — 12 conformance slices passed - `npm run verify:package` — packaged CLI, skill, 95-tool MCP catalog, and lifecycle checks passed - `npm run knip` - `npm run jscpd` — 157 baseline clones - `npm run scan:todos` - post-commit `npm run docs:check` No operator-local managed manifest or BYO ILSpy command was configured, so no operator-local application or real ILSpy oracle claim is made. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:12:39 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:56:48 +00:00

[PR #1936] [MERGED] test(clients): verify native Gemini CLI integration on Windows #4921

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#1936

No description provided.

Rows
Columns