[PR #312] [MERGED] test: stabilize subprocess-heavy integration suites #1947

New issue

Closed

opened 2026-10-16 21:12:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:12:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/312
Author: @morluto
Created: 7/20/2026
Status: ✅ Merged
Merged: 7/20/2026
Merged by: @morluto

Base: main ← Head: codex/fix-flaky-integration-tests

📝 Commits (5)

c2e134b test: isolate slow filesystem and CLI suites
8d3587b test: budget CLI output variant subprocesses
bc80359 test: cap workers across all hosts
168100e test: inherit root options in Vitest projects
2d2cad2 Merge branch 'main' into codex/fix-flaky-integration-tests

📊 Changes

3 files changed (+30 additions, -25 deletions)

View changed files

📝 tests/cliOutput.test.ts (+2 -1)
📝 tests/javascriptArtifactReconstruction.test.ts (+1 -1)
📝 vitest.config.ts (+27 -23)

📄 Description

Description

Vitest only created its serial integration project on exactly two-core hosts. On larger hosts, subprocess- and filesystem-heavy suites fell back into the unrestricted parallel pool, where CLI startup tests repeatedly exhausted fixed 20s and 60s budgets.

This change always creates the two-worker project layout, assigns the CLI and repeated-file reconstruction suites to the serial project, and gives the nine-process CLI variant test a timeout proportional to its workload. The 70-file reconstruction regression also gets an explicit local budget instead of relying on Vitest's 5s unit-test default.

Type of Change

Bug fix
Refactoring (no functional change)

Testing Performed

TypeScript typecheck passes (commit hook)
npx vitest run tests/applicationWorkflowCli.test.ts tests/javascriptArtifactReconstruction.test.ts --coverage.enabled=false — 15 tests passed in the serial integration project
npx vitest run tests/cliOutput.test.ts --coverage.enabled=false — 5 tests passed, including all nine output-control subprocess variants

Tool Contract Impact

None.

Relates to #172.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/312 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/20/2026 **Status:** ✅ Merged **Merged:** 7/20/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/fix-flaky-integration-tests` --- ### 📝 Commits (5) - [`c2e134b`](https://github.com/morluto/rea/commit/c2e134b8e46d780b61faab1021772704380e6a37) test: isolate slow filesystem and CLI suites - [`8d3587b`](https://github.com/morluto/rea/commit/8d3587bbcac18e90652cc95e5853158a4f9aef18) test: budget CLI output variant subprocesses - [`bc80359`](https://github.com/morluto/rea/commit/bc8035918b1d6a3eac7fc2307867d4dc2787d3b5) test: cap workers across all hosts - [`168100e`](https://github.com/morluto/rea/commit/168100e5326958fc89431a26a1f3cca762516133) test: inherit root options in Vitest projects - [`2d2cad2`](https://github.com/morluto/rea/commit/2d2cad297e28bcbeabf1920c159da4941b0eba08) Merge branch 'main' into codex/fix-flaky-integration-tests ### 📊 Changes **3 files changed** (+30 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `tests/cliOutput.test.ts` (+2 -1) 📝 `tests/javascriptArtifactReconstruction.test.ts` (+1 -1) 📝 `vitest.config.ts` (+27 -23) </details> ### 📄 Description ## Description Vitest only created its serial integration project on exactly two-core hosts. On larger hosts, subprocess- and filesystem-heavy suites fell back into the unrestricted parallel pool, where CLI startup tests repeatedly exhausted fixed 20s and 60s budgets. This change always creates the two-worker project layout, assigns the CLI and repeated-file reconstruction suites to the serial project, and gives the nine-process CLI variant test a timeout proportional to its workload. The 70-file reconstruction regression also gets an explicit local budget instead of relying on Vitest's 5s unit-test default. ## Type of Change - [x] Bug fix - [x] Refactoring (no functional change) ## Testing Performed - [x] TypeScript typecheck passes (commit hook) - [x] `npx vitest run tests/applicationWorkflowCli.test.ts tests/javascriptArtifactReconstruction.test.ts --coverage.enabled=false` — 15 tests passed in the serial integration project - [x] `npx vitest run tests/cliOutput.test.ts --coverage.enabled=false` — 5 tests passed, including all nine output-control subprocess variants ## Tool Contract Impact None. ## Related Issues Relates to #172.  --- <a href="https://app.devin.ai/review/morluto/rea/pull/312" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open in Devin Review"> </picture> </a>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:12:46 +00:00