[PR #311] [CLOSED] feat: expand cross-platform investigation workflows #1948

Closed
opened 2026-10-16 21:12:46 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/311
Author: @morluto
Created: 7/20/2026
Status: ❌ Closed

Base: main ← Head: codex/address-open-issues-2026-07-20


📝 Commits (3)

  • dffc81c feat: expand cross-platform investigation workflows
  • c06eb46 test: isolate slow filesystem and CLI suites
  • f823486 test: budget CLI output variant subprocesses

📊 Changes

674 files changed (+13017 additions, -2302 deletions)

View changed files

📝 .github/workflows/real-hopper-linux.yml (+25 -12)
📝 README.md (+8 -1)
📝 README_ar.md (+3 -0)
📝 README_ja.md (+14 -11)
📝 README_ko.md (+14 -11)
📝 README_zh.md (+3 -0)
📝 bridge/hopper_bridge.py (+10 -0)
📝 docs/api/assets/hierarchy.js (+1 -1)
📝 docs/api/assets/navigation.js (+1 -1)
📝 docs/api/assets/search.js (+1 -1)
📝 docs/api/classes/application_AnalysisSnapshotCache.AnalysisSnapshotCache.html (+10 -10)
📝 docs/api/classes/application_BinarySession.BinarySession.html (+56 -56)
📝 docs/api/classes/application_EvidenceLedger.EvidenceLedger.html (+17 -17)
📝 docs/api/classes/application_JavaScriptArtifactGraphAccumulator.JavaScriptArtifactGraphAccumulator.html (+8 -8)
📝 docs/api/classes/application_PermissionAuthority.PermissionAuthority.html (+7 -7)
📝 docs/api/classes/application_PermissionAuthority.PermissionPathError.html (+1 -1)
📝 docs/api/classes/application_ProcessCaptureError.ProcessCaptureError.html (+1 -1)
📝 docs/api/classes/application_ProcessCheckpoints.ProcessCheckpoints.html (+2 -2)
📝 docs/api/classes/application_ProjectPermissionStore.ProjectPermissionStoreError.html (+1 -1)
📝 docs/api/classes/application_WindowsNativeAuthority.WindowsNativeAuthority.html (+8 -8)

...and 80 more files

📄 Description

Description

This integrates the issue-sweep work that depends on the same canonical tool catalog and generated documentation. It adds provider-neutral Android and Apple application projections, runtime identification, process lifecycle and paired-experiment evidence, replay state tracking, CLI/MCP parity, stricter authority and comparison boundaries, and expanded real-Hopper semantic checks.

The change also fixes test instability found while validating the final tree. Subprocess- and filesystem-heavy suites now run in the serial integration project, while tests that intentionally perform multiple CLI startups or scan 70 files use workload-specific time budgets.

Type of Change

  • Bug fix
  • New feature
  • Refactoring (no functional change)
  • Tool contract change (MCP schema modification)

Testing Performed

  • Unit tests added or updated
  • TypeScript typecheck passes (npm run typecheck)
  • Linting passes (npm run lint; existing warning-only complexity and size diagnostics remain)
  • Generated documentation and catalog checks pass (npm run docs:check)
  • Focused flaky-test regressions pass:
    • npx vitest run tests/applicationWorkflowCli.test.ts
    • npx vitest run tests/cliOutput.test.ts --coverage.enabled=false
    • npx vitest run tests/applicationWorkflowCli.test.ts tests/electronCli.test.ts tests/javascriptArtifactReconstruction.test.ts (all target tests passed; the focused run's global coverage threshold is not meaningful in isolation)
  • Real Hopper verification performed
  • Linux real Hopper verification performed
  • Real browser verification performed
  • Package verification performed

The complete suite was run while preparing the branch. It exposed the CLI and filesystem timeout flakes fixed by the final two commits; the affected tests were then rerun successfully. CI remains the final complete-suite run for the exact pushed tree.

Tool Contract Impact

Adds the Android application, Apple application, and runtime-identification tool families and keeps CLI, MCP, examples, output schemas, product catalog, and generated API documentation synchronized.

Suggested review order

  1. Domain models and evidence invariants under src/domain/.
  2. Application services and authority/lifecycle changes under src/application/.
  3. Contract, server, and CLI registration.
  4. Provider and real-Hopper verification changes.
  5. Tests, catalog generation, and generated docs/api/ output.

Relates to #19, #55, #59, #62, #151, and #172.


Open in Devin Review

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/311 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/20/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/address-open-issues-2026-07-20` --- ### 📝 Commits (3) - [`dffc81c`](https://github.com/morluto/rea/commit/dffc81c865bb2e8f4ebb47526e720ec5e870c40b) feat: expand cross-platform investigation workflows - [`c06eb46`](https://github.com/morluto/rea/commit/c06eb46d1aaaad22fb03c5dfb36943ff03a9e80d) test: isolate slow filesystem and CLI suites - [`f823486`](https://github.com/morluto/rea/commit/f823486862c6cd0c947eef0f1730e34fc0a8b286) test: budget CLI output variant subprocesses ### 📊 Changes **674 files changed** (+13017 additions, -2302 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/real-hopper-linux.yml` (+25 -12) 📝 `README.md` (+8 -1) 📝 `README_ar.md` (+3 -0) 📝 `README_ja.md` (+14 -11) 📝 `README_ko.md` (+14 -11) 📝 `README_zh.md` (+3 -0) 📝 `bridge/hopper_bridge.py` (+10 -0) 📝 `docs/api/assets/hierarchy.js` (+1 -1) 📝 `docs/api/assets/navigation.js` (+1 -1) 📝 `docs/api/assets/search.js` (+1 -1) 📝 `docs/api/classes/application_AnalysisSnapshotCache.AnalysisSnapshotCache.html` (+10 -10) 📝 `docs/api/classes/application_BinarySession.BinarySession.html` (+56 -56) 📝 `docs/api/classes/application_EvidenceLedger.EvidenceLedger.html` (+17 -17) 📝 `docs/api/classes/application_JavaScriptArtifactGraphAccumulator.JavaScriptArtifactGraphAccumulator.html` (+8 -8) 📝 `docs/api/classes/application_PermissionAuthority.PermissionAuthority.html` (+7 -7) 📝 `docs/api/classes/application_PermissionAuthority.PermissionPathError.html` (+1 -1) 📝 `docs/api/classes/application_ProcessCaptureError.ProcessCaptureError.html` (+1 -1) 📝 `docs/api/classes/application_ProcessCheckpoints.ProcessCheckpoints.html` (+2 -2) 📝 `docs/api/classes/application_ProjectPermissionStore.ProjectPermissionStoreError.html` (+1 -1) 📝 `docs/api/classes/application_WindowsNativeAuthority.WindowsNativeAuthority.html` (+8 -8) _...and 80 more files_ </details> ### 📄 Description ## Description This integrates the issue-sweep work that depends on the same canonical tool catalog and generated documentation. It adds provider-neutral Android and Apple application projections, runtime identification, process lifecycle and paired-experiment evidence, replay state tracking, CLI/MCP parity, stricter authority and comparison boundaries, and expanded real-Hopper semantic checks. The change also fixes test instability found while validating the final tree. Subprocess- and filesystem-heavy suites now run in the serial integration project, while tests that intentionally perform multiple CLI startups or scan 70 files use workload-specific time budgets. ## Type of Change - [x] Bug fix - [x] New feature - [x] Refactoring (no functional change) - [x] Tool contract change (MCP schema modification) ## Testing Performed - [x] Unit tests added or updated - [x] TypeScript typecheck passes (`npm run typecheck`) - [x] Linting passes (`npm run lint`; existing warning-only complexity and size diagnostics remain) - [x] Generated documentation and catalog checks pass (`npm run docs:check`) - [x] Focused flaky-test regressions pass: - `npx vitest run tests/applicationWorkflowCli.test.ts` - `npx vitest run tests/cliOutput.test.ts --coverage.enabled=false` - `npx vitest run tests/applicationWorkflowCli.test.ts tests/electronCli.test.ts tests/javascriptArtifactReconstruction.test.ts` (all target tests passed; the focused run's global coverage threshold is not meaningful in isolation) - [ ] Real Hopper verification performed - [ ] Linux real Hopper verification performed - [ ] Real browser verification performed - [ ] Package verification performed The complete suite was run while preparing the branch. It exposed the CLI and filesystem timeout flakes fixed by the final two commits; the affected tests were then rerun successfully. CI remains the final complete-suite run for the exact pushed tree. ## Tool Contract Impact Adds the Android application, Apple application, and runtime-identification tool families and keeps CLI, MCP, examples, output schemas, product catalog, and generated API documentation synchronized. ## Suggested review order 1. Domain models and evidence invariants under `src/domain/`. 2. Application services and authority/lifecycle changes under `src/application/`. 3. Contract, server, and CLI registration. 4. Provider and real-Hopper verification changes. 5. Tests, catalog generation, and generated `docs/api/` output. ## Related Issues Relates to #19, #55, #59, #62, #151, and #172. <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/morluto/rea/pull/311" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open in Devin Review"> </picture> </a> <!-- devin-review-badge-end --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-16 21:12:46 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#1948
No description provided.