[PR #407] [MERGED] feat: complete REA remediation program

bsakaguchi commented

2026-10-16 21:12:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/407
Author: @N0zoM1z0
Created: 7/22/2026
Status: ✅ Merged
Merged: 7/22/2026
Merged by: @N0zoM1z0

Base: main ← Head: feat/rea-remediation-2026-07-22

📝 Commits (3)

ddc97f3 feat: complete REA remediation program
03de451 fix(browser): redact transitional target titles
2bce4eb test(browser): stabilize real shape capture

📊 Changes

466 files changed (+14087 additions, -1920 deletions)

View changed files

📝 .github/workflows/real-hopper-linux.yml (+2 -12)
📝 .github/workflows/real-hopper.yml (+0 -2)
📝 CONTRIBUTING.md (+15 -5)
📝 README.md (+2 -2)
📝 README_ar.md (+1 -1)
📝 README_ja.md (+1 -1)
📝 README_ko.md (+1 -1)
📝 README_zh.md (+1 -1)
📝 docs/api/assets/hierarchy.js (+1 -1)
📝 docs/api/assets/navigation.js (+1 -1)
📝 docs/api/assets/search.js (+1 -1)
📝 docs/api/classes/application_BinarySession.BinarySession.html (+1 -1)
📝 docs/api/classes/application_BinarySessionRecords.BinarySessionRecords.html (+1 -1)
📝 docs/api/classes/application_PermissionAuthority.PermissionPathError.html (+1 -1)
📝 docs/api/classes/application_ProcessCaptureError.ProcessCaptureError.html (+1 -1)
📝 docs/api/classes/application_ProjectPermissionStore.ProjectPermissionStoreError.html (+1 -1)
📝 docs/api/classes/browser_BrowserProcessStartup.BrowserStartupError.html (+1 -1)
📝 docs/api/classes/domain_errors.AnalysisCancelledError.html (+8 -8)
📝 docs/api/classes/domain_errors.AnalysisCapabilityUnavailableError.html (+10 -10)
📝 docs/api/classes/domain_errors.AnalysisError.html (+6 -6)

...and 80 more files

📄 Description

Summary

compose JavaScript application workflows from session-owned Evidence IDs while preserving full-Evidence domain validation and CLI bundle parity
separate artifact/output formats, reject structured token slicing, scope doctor/setup readiness, diagnose the production MCP server, and add compact status projections
build platform-native Hopper fixtures, probe Linux private displays truthfully, and use an unprivileged X11 mount namespace fallback when required
add bounded static JavaScript export return-shape comparison with exact Evidence-backed /depth: 1 reporting
isolate Vitest projects and enforce exact per-test temporary-directory ownership

Root causes addressed

The hands-on evaluation found invalid structured CLI windows, an unreachable artifact-format option, an MCP doctor that inspected the CLI catalog, unscoped setup health, non-composable Evidence results, duplicate Vitest collection, leaking temporary fixtures, Linux Hopper fixture gaps, and a WSL2 private-X11 false positive. This change repairs those boundaries without weakening canonical MCP schemas, Evidence integrity, or provider isolation.

During real verification, two stale verifier assumptions were also fixed: package discovery now distinguishes compact/full doctor projections, and the real-Hopper verifier cross-checks compact MCP results against complete session Evidence resources.

User and agent impact

REA now exposes 56 CLI commands and 96 MCP tools. Agents can pass summary Evidence IDs directly into downstream workflows, inspect purpose-specific status without receiving the full catalog, and compare exact static JavaScript export shapes without source reads or implicit execution. Linux Hopper reports the actual private-display strategy and preserves the host X11 mount.

Verification

npm run check: 181/181 test files, 1223/1223 tests
coverage: 82.48% statements, 70.56% branches, 85.38% functions, 84.61% lines
npm run verify:package
npm run verify:test-temp-hygiene
npm run verify:application-workflows
npm run verify:hopper:linux against real Hopper on WSL2; clean shutdown and unchanged host X11 mount
focused Codex 0.144.6 scenario: analyze -> analyze -> compare shapes, 0 repeated calls, 0 input-validation failures, exact /depth literal 1, Evidence cited
npm run knip
npm run jscpd
npm run scan:todos

Real macOS Hopper was not available on this host. The clean-runner Linux setup verifier was not run because this machine already has Hopper installed. Ghidra was not configured; no Ghidra provider behavior changed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/407 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 7/22/2026 **Status:** ✅ Merged **Merged:** 7/22/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `feat/rea-remediation-2026-07-22` --- ### 📝 Commits (3) - [`ddc97f3`](https://github.com/morluto/rea/commit/ddc97f32e3e4c95d4d4286d205dc9335f8a81298) feat: complete REA remediation program - [`03de451`](https://github.com/morluto/rea/commit/03de45181172f44dfce76101e70597b77e8cd163) fix(browser): redact transitional target titles - [`2bce4eb`](https://github.com/morluto/rea/commit/2bce4ebbd43059c3afe78998d9919fb1d72362ca) test(browser): stabilize real shape capture ### 📊 Changes **466 files changed** (+14087 additions, -1920 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/real-hopper-linux.yml` (+2 -12) 📝 `.github/workflows/real-hopper.yml` (+0 -2) 📝 `CONTRIBUTING.md` (+15 -5) 📝 `README.md` (+2 -2) 📝 `README_ar.md` (+1 -1) 📝 `README_ja.md` (+1 -1) 📝 `README_ko.md` (+1 -1) 📝 `README_zh.md` (+1 -1) 📝 `docs/api/assets/hierarchy.js` (+1 -1) 📝 `docs/api/assets/navigation.js` (+1 -1) 📝 `docs/api/assets/search.js` (+1 -1) 📝 `docs/api/classes/application_BinarySession.BinarySession.html` (+1 -1) 📝 `docs/api/classes/application_BinarySessionRecords.BinarySessionRecords.html` (+1 -1) 📝 `docs/api/classes/application_PermissionAuthority.PermissionPathError.html` (+1 -1) 📝 `docs/api/classes/application_ProcessCaptureError.ProcessCaptureError.html` (+1 -1) 📝 `docs/api/classes/application_ProjectPermissionStore.ProjectPermissionStoreError.html` (+1 -1) 📝 `docs/api/classes/browser_BrowserProcessStartup.BrowserStartupError.html` (+1 -1) 📝 `docs/api/classes/domain_errors.AnalysisCancelledError.html` (+8 -8) 📝 `docs/api/classes/domain_errors.AnalysisCapabilityUnavailableError.html` (+10 -10) 📝 `docs/api/classes/domain_errors.AnalysisError.html` (+6 -6) _...and 80 more files_ </details> ### 📄 Description ## Summary - compose JavaScript application workflows from session-owned Evidence IDs while preserving full-Evidence domain validation and CLI bundle parity - separate artifact/output formats, reject structured token slicing, scope doctor/setup readiness, diagnose the production MCP server, and add compact status projections - build platform-native Hopper fixtures, probe Linux private displays truthfully, and use an unprivileged X11 mount namespace fallback when required - add bounded static JavaScript export return-shape comparison with exact Evidence-backed `/depth: 1` reporting - isolate Vitest projects and enforce exact per-test temporary-directory ownership ## Root causes addressed The hands-on evaluation found invalid structured CLI windows, an unreachable artifact-format option, an MCP doctor that inspected the CLI catalog, unscoped setup health, non-composable Evidence results, duplicate Vitest collection, leaking temporary fixtures, Linux Hopper fixture gaps, and a WSL2 private-X11 false positive. This change repairs those boundaries without weakening canonical MCP schemas, Evidence integrity, or provider isolation. During real verification, two stale verifier assumptions were also fixed: package discovery now distinguishes compact/full doctor projections, and the real-Hopper verifier cross-checks compact MCP results against complete session Evidence resources. ## User and agent impact REA now exposes 56 CLI commands and 96 MCP tools. Agents can pass summary Evidence IDs directly into downstream workflows, inspect purpose-specific status without receiving the full catalog, and compare exact static JavaScript export shapes without source reads or implicit execution. Linux Hopper reports the actual private-display strategy and preserves the host X11 mount. ## Verification - `npm run check`: 181/181 test files, 1223/1223 tests - coverage: 82.48% statements, 70.56% branches, 85.38% functions, 84.61% lines - `npm run verify:package` - `npm run verify:test-temp-hygiene` - `npm run verify:application-workflows` - `npm run verify:hopper:linux` against real Hopper on WSL2; clean shutdown and unchanged host X11 mount - focused Codex 0.144.6 scenario: analyze -> analyze -> compare shapes, 0 repeated calls, 0 input-validation failures, exact `/depth` literal `1`, Evidence cited - `npm run knip` - `npm run jscpd` - `npm run scan:todos` Real macOS Hopper was not available on this host. The clean-runner Linux setup verifier was not run because this machine already has Hopper installed. Ghidra was not configured; no Ghidra provider behavior changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi