morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #432] [MERGED] perf(test): speed up local and CI validation #1980

New issue

Closed

opened 2026-10-16 21:13:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:03 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/432
Author: @morluto
Created: 7/24/2026
Status: ✅ Merged
Merged: 7/24/2026
Merged by: @morluto

Base: main ← Head: codex/test-suite-performance-main

📝 Commits (4)

42fbbb2 perf(test): speed up local and CI validation
13f3372 fix(test): use direct Node launcher on macOS
9c3aec8 fix(process): normalize macOS launcher identity
62ac73c fix(process): expose launcher identity mismatch

📊 Changes

19 files changed (+248 additions, -39 deletions)

View changed files

📝 .github/workflows/ci.yml (+26 -2)
📝 .gitignore (+1 -0)
📝 AGENTS.md (+3 -2)
📝 CONTRIBUTING.md (+5 -3)
📝 package.json (+6 -3)
➕ scripts/verify-package-environment.d.mts (+26 -0)
📝 scripts/verify-package-environment.mjs (+2 -2)
➕ src/process/ProcessCommandIdentity.ts (+24 -0)
📝 src/process/ProcessOwnership.ts (+6 -11)
📝 tests/cdpBrowserProvider.test.ts (+3 -1)
📝 tests/packageInstallWorkflow.test.ts (+28 -0)
📝 tests/processCapture.test.ts (+5 -3)
📝 tests/processCaptureElicitation.test.ts (+1 -1)
📝 tests/processOwnership.test.ts (+27 -1)
📝 tests/vitestConfiguration.test.ts (+9 -4)
📝 tsconfig.build.json (+2 -0)
📝 tsconfig.json (+2 -0)
📝 turbo.json (+29 -4)
📝 vitest.config.ts (+43 -2)

📄 Description

Description

Reduce test-runner contention and repeated build work by making execution lanes explicit and sharing one CI build artifact.

Pure/in-memory tests run in the faster threads pool.
Tests that launch child processes or production runtimes run in isolated forks.
Filesystem/process/CLI integration remains serial and explicit.
Local test:fast, test:changed, and watch commands use the non-serial lanes.
CI keeps two balanced coverage shards, consuming one shared dist artifact instead of rebuilding per shard.
TypeScript incremental state is persisted through Turbo; lint/knip inputs are narrowed to relevant files.
A configuration test enforces an exact, disjoint partition so tests cannot silently fall out of a lane or run twice.

The change also fixes three test-harness timing/tampering issues exposed by the mixed lane: a CDP cancellation response race, a target-loss deadline that was too tight under worker load, and a request-state mutation that could alter only base64url padding bits.

Type of Change

Performance improvement
Tests and test infrastructure
Bug fix
New feature
Refactoring
Documentation update

Testing Performed

npm run check:pr — 9 tasks passed; 196 files / 1,388 tests passed. TypeDoc emitted existing warnings but no errors.
npm run check:ci — 7 tasks passed.
npm run verify:package — passed.
npm pack --dry-run — passed; 621 files packaged.
git diff --check
Real Hopper/Ghidra/browser verification — not applicable; provider behavior is unchanged.

Tool Contract Impact

None. MCP tool inventory, schemas, and provider contracts are unchanged.

Review Order

vitest.config.ts and package.json for lane and command behavior.
.github/workflows/ci.yml and turbo.json for CI/build caching.
Regression tests and documentation updates.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/432 **Author:** [@morluto](https://github.com/morluto) **Created:** 7/24/2026 **Status:** ✅ Merged **Merged:** 7/24/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/test-suite-performance-main` --- ### 📝 Commits (4) - [`42fbbb2`](https://github.com/morluto/rea/commit/42fbbb297b8f40bcfbbfa219a1de098f3d0780ad) perf(test): speed up local and CI validation - [`13f3372`](https://github.com/morluto/rea/commit/13f3372a8beaa165473bd7ecaccaa2997dcbf2ab) fix(test): use direct Node launcher on macOS - [`9c3aec8`](https://github.com/morluto/rea/commit/9c3aec81317cd6caf627f13ebb0c6dc0f6735516) fix(process): normalize macOS launcher identity - [`62ac73c`](https://github.com/morluto/rea/commit/62ac73cdd79bee708d50b17a2dde8c23e0b66f1e) fix(process): expose launcher identity mismatch ### 📊 Changes **19 files changed** (+248 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+26 -2) 📝 `.gitignore` (+1 -0) 📝 `AGENTS.md` (+3 -2) 📝 `CONTRIBUTING.md` (+5 -3) 📝 `package.json` (+6 -3) ➕ `scripts/verify-package-environment.d.mts` (+26 -0) 📝 `scripts/verify-package-environment.mjs` (+2 -2) ➕ `src/process/ProcessCommandIdentity.ts` (+24 -0) 📝 `src/process/ProcessOwnership.ts` (+6 -11) 📝 `tests/cdpBrowserProvider.test.ts` (+3 -1) 📝 `tests/packageInstallWorkflow.test.ts` (+28 -0) 📝 `tests/processCapture.test.ts` (+5 -3) 📝 `tests/processCaptureElicitation.test.ts` (+1 -1) 📝 `tests/processOwnership.test.ts` (+27 -1) 📝 `tests/vitestConfiguration.test.ts` (+9 -4) 📝 `tsconfig.build.json` (+2 -0) 📝 `tsconfig.json` (+2 -0) 📝 `turbo.json` (+29 -4) 📝 `vitest.config.ts` (+43 -2) </details> ### 📄 Description ## Description Reduce test-runner contention and repeated build work by making execution lanes explicit and sharing one CI build artifact. - Pure/in-memory tests run in the faster threads pool. - Tests that launch child processes or production runtimes run in isolated forks. - Filesystem/process/CLI integration remains serial and explicit. - Local `test:fast`, `test:changed`, and watch commands use the non-serial lanes. - CI keeps two balanced coverage shards, consuming one shared `dist` artifact instead of rebuilding per shard. - TypeScript incremental state is persisted through Turbo; lint/knip inputs are narrowed to relevant files. - A configuration test enforces an exact, disjoint partition so tests cannot silently fall out of a lane or run twice. The change also fixes three test-harness timing/tampering issues exposed by the mixed lane: a CDP cancellation response race, a target-loss deadline that was too tight under worker load, and a request-state mutation that could alter only base64url padding bits. ## Type of Change - [x] Performance improvement - [x] Tests and test infrastructure - [ ] Bug fix - [ ] New feature - [ ] Refactoring - [ ] Documentation update ## Testing Performed - [x] `npm run check:pr` — 9 tasks passed; 196 files / 1,388 tests passed. TypeDoc emitted existing warnings but no errors. - [x] `npm run check:ci` — 7 tasks passed. - [x] `npm run verify:package` — passed. - [x] `npm pack --dry-run` — passed; 621 files packaged. - [x] `git diff --check` - [ ] Real Hopper/Ghidra/browser verification — not applicable; provider behavior is unchanged. ## Tool Contract Impact None. MCP tool inventory, schemas, and provider contracts are unchanged. ## Review Order 1. `vitest.config.ts` and `package.json` for lane and command behavior. 2. `.github/workflows/ci.yml` and `turbo.json` for CI/build caching. 3. Regression tests and documentation updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:03 +00:00

closed this issue
added the
pull-request
label

~~bsakaguchi referenced this issue 2026-10-17 21:01:59 +00:00~~

[GH-ISSUE #3796] [Tracker] Open feature requests by area (October 2026) #1471

bsakaguchi referenced this issue

2026-10-31 00:29:25 +00:00

[GH-ISSUE #1980] [Design] #658

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#1980

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns