morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #462] [MERGED] fix(ci): guard Release Please PR branch parsing #2009

New issue

Closed

opened 2026-10-16 21:13:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/462
Author: @morluto
Created: 8/3/2026
Status: ✅ Merged
Merged: 8/3/2026
Merged by: @morluto

Base: main ← Head: agent/fix-release-please-output

📝 Commits (1)

6838b6b fix(ci): guard release PR branch parsing

📊 Changes

1 file changed (+14 additions, -2 deletions)

View changed files

📝 .github/workflows/release.yml (+14 -2)

📄 Description

Description

Release Please successfully creates a GitHub release, but its pr output is empty on the release-created path after the release PR is merged. The workflow then evaluates fromJSON(steps.release.outputs.pr).headBranchName in the catalog commit step and fails before the publish job can run.

This change passes the raw PR JSON into the already guarded shell step and extracts headBranchName there. Release PR normalization keeps its existing behavior, while the release-created path no longer evaluates empty JSON.

Type of Change

Bug fix

Testing Performed

Valid PR JSON extracts the expected release branch.
Empty PR JSON is rejected by the shell validation instead of being evaluated by a GitHub Actions expression.
git diff --check passes.

A GitHub Actions run is still required to validate the workflow on the hosted runner.

Tool Contract Impact

None.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/462 **Author:** [@morluto](https://github.com/morluto) **Created:** 8/3/2026 **Status:** ✅ Merged **Merged:** 8/3/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/fix-release-please-output` --- ### 📝 Commits (1) - [`6838b6b`](https://github.com/morluto/rea/commit/6838b6bff9ab5c400432caefd8c8737b86c41f07) fix(ci): guard release PR branch parsing ### 📊 Changes **1 file changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+14 -2) </details> ### 📄 Description ## Description Release Please successfully creates a GitHub release, but its `pr` output is empty on the release-created path after the release PR is merged. The workflow then evaluates `fromJSON(steps.release.outputs.pr).headBranchName` in the catalog commit step and fails before the publish job can run. This change passes the raw PR JSON into the already guarded shell step and extracts `headBranchName` there. Release PR normalization keeps its existing behavior, while the release-created path no longer evaluates empty JSON. ## Type of Change - [x] Bug fix ## Testing Performed - [x] Valid PR JSON extracts the expected release branch. - [x] Empty PR JSON is rejected by the shell validation instead of being evaluated by a GitHub Actions expression. - [x] `git diff --check` passes. A GitHub Actions run is still required to validate the workflow on the hosted runner. ## Tool Contract Impact None. ## Related Issues None. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:19 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:57:29 +00:00

[PR #2013] [MERGED] fix(session): attribute selected-provider capabilities to the resolved identity #4966

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2009

No description provided.

Rows
Columns