morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #468] [MERGED] refactor(mcp): make analysis states unrepresentable #2014

New issue

Closed

opened 2026-10-16 21:13:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:22 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/468
Author: @morluto
Created: 8/9/2026
Status: ✅ Merged
Merged: 8/9/2026
Merged by: @morluto

Base: main ← Head: agent/make-invalid-states-unrepresentable

📝 Commits (10+)

79cc9df refactor(config): parse capability settings into exact states
63b0b1c refactor(runtime): encode replay and process outcomes exactly
2150109 refactor: make analysis states unrepresentable
ade56a6 refactor(mcp): register canonical schemas with SDK
04c198e fix: preserve capability and catalog invariants
ba7327d fix(build): remove stale compiled modules
20dba84 fix(replay): update real verifier policy dependency
85d27fb fix(package): verify the complete MCP catalog
7b00579 fix(test): supply complete replay reload policy
33a0f62 refactor(contracts): centralize output schema lookup

📊 Changes

271 files changed (+5946 additions, -5675 deletions)

View changed files

📝 docs/product-catalog.json (+2 -2)
📝 docs/verification/managed-conformance-manifest.json (+2 -2)
📝 package.json (+1 -1)
➕ scripts/clean-build-output.mjs (+10 -0)
📝 scripts/generate-mcp-tool-catalog.mjs (+35 -14)
📝 scripts/lib/verify-package-core.mjs (+4 -7)
📝 scripts/verify-managed-conformance.mjs (+3 -3)
📝 scripts/verify-package-mcp.mjs (+21 -13)
📝 scripts/verify-real-browser.mjs (+1 -0)
📝 scripts/verify-real-javascript-replay.mjs (+24 -10)
📝 scripts/verify-windows-package.mjs (+2 -2)
📝 skills/reverse-engineer-anything/SKILL.md (+1 -1)
📝 src/application/ApplicationWorkflowEvidenceResolver.ts (+33 -28)
➕ src/application/ArtifactInventory/policy.ts (+41 -0)
📝 src/application/ArtifactInventory/reader.ts (+2 -10)
📝 src/application/ArtifactInventory/scanCanonical.ts (+0 -8)
📝 src/application/ArtifactInventory/scanReader.ts (+12 -12)
📝 src/application/ArtifactInventory/types.ts (+12 -17)
📝 src/application/BinarySession.ts (+16 -20)
📝 src/application/BinarySessionStatus.ts (+13 -7)

...and 80 more files

📄 Description

Description

Replace permissive intermediate states with boundary-parsed, discriminated values across configuration, provider selection, binary targets, replay/process outcomes, managed workflows, browser capture, and native API evidence. Contradictory states are rejected as inputs instead of surviving into application logic.

MCP registration now gives the canonical Zod input and output contracts directly to the 2.0 SDK. The SDK owns request parsing, output validation, registered-tool advertisement, per-request client metadata, connection lifetime, and list-change behavior. The generated catalog is captured through a real SDK client/server connection, so it cannot drift from tools/list. This removes the parallel input parser, manual JSON Schema override layer, server-global metadata fallbacks, and transport-level live-server bookkeeping.

The contract cleanup also closes three concrete invalid states found while reviewing the SDK projection:

web capture comparison is an exact passive-or-scenario union;
browser script-source capture requires a separate explicit approval and records that approval in Evidence;
Node characterization plans and native ABI return/parameter records use field-specific effect and role variants.

No tool names or provider authorities are added or removed. Setup behavior and provider mutation boundaries are unchanged.

Suggested review order:

Configuration and runtime state parsing (79cc9df3, 63b0b1c1).
Provider, target, workflow, and integrity unions (21501091).
SDK-owned MCP registration and deleted parallel catalog machinery (ade56a6e, 04c198e7, 410569f0).
Exact build and package verification (ba7327d9, 20dba840, 85d27fb7, 7b00579e).
Centralized contract drift boundary (33a0f627).

Type of Change

Bug fix
New feature
Documentation update
Performance improvement
Refactoring (no functional change)
Tool contract change (MCP schema modification)

Testing Performed

Unit tests added or updated
TypeScript typecheck passes (npm run typecheck)
Linting passes (npm run lint)
Full test suite passes (npm test)
Real Hopper verification performed (npm run verify:hopper)
Linux real Hopper verification performed (npm run verify:hopper:linux) or unavailability explained
Real browser verification performed (npm run verify:browser) or unavailability explained
Package verification performed (npm run verify:package)

Validation performed on the final local tree:

npm run check:pr — 329 test files and 1,697 tests passed; typecheck, lint, formatting, Knip, metadata, SDK-derived catalog, generated docs, documentation facts, and error-schema checks passed.
Focused MCP/browser/native regression suites — 21 tests passed, covering SDK output validation, catalog identity, modern request metadata, incomplete browser comparisons, explicit source approval, Evidence provenance, Node effect narrowing, and native ABI roles.

Real Hopper, Linux Hopper, Ghidra, browser, and package verification were not run locally. Provider execution and bridge semantics are unchanged; the PR workflows remain the source of cross-platform and real-provider evidence.

Tool Contract Impact

The canonical 116-tool inventory remains complete and stable. Tool schemas now come from the same registered SDK contracts that parse calls and validate successful structured output. The caller-visible changes reject incomplete browser comparison pairs, unapproved browser source capture, invalid Node characterization effects, and mismatched native ABI roles.

Generated product, skill, Evidence manifest, and MCP catalog metadata were regenerated and verified.

Related Issues

No linked issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/468 **Author:** [@morluto](https://github.com/morluto) **Created:** 8/9/2026 **Status:** ✅ Merged **Merged:** 8/9/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/make-invalid-states-unrepresentable` --- ### 📝 Commits (10+) - [`79cc9df`](https://github.com/morluto/rea/commit/79cc9df3700d7ab33e66ce3273c475d01cfbdc96) refactor(config): parse capability settings into exact states - [`63b0b1c`](https://github.com/morluto/rea/commit/63b0b1c12bf4ff88907a3833426c403c0d699202) refactor(runtime): encode replay and process outcomes exactly - [`2150109`](https://github.com/morluto/rea/commit/21501091cfc817ab2ab91396f5bdfdc6384c381b) refactor: make analysis states unrepresentable - [`ade56a6`](https://github.com/morluto/rea/commit/ade56a6e01d0a61c5a247e7314f1a6dbe72709f0) refactor(mcp): register canonical schemas with SDK - [`04c198e`](https://github.com/morluto/rea/commit/04c198e76f4fb2165dc2f547b9473dc445ff4ea2) fix: preserve capability and catalog invariants - [`ba7327d`](https://github.com/morluto/rea/commit/ba7327d926368e25733f7ad8c6f2ad00076c61b7) fix(build): remove stale compiled modules - [`20dba84`](https://github.com/morluto/rea/commit/20dba84056ab49a0058297d26765d2b0889c92b8) fix(replay): update real verifier policy dependency - [`85d27fb`](https://github.com/morluto/rea/commit/85d27fb72407876c926805a91f0ce2bd21d41755) fix(package): verify the complete MCP catalog - [`7b00579`](https://github.com/morluto/rea/commit/7b00579e9851138dee380b7c9e5436c10ac29706) fix(test): supply complete replay reload policy - [`33a0f62`](https://github.com/morluto/rea/commit/33a0f627056e6e9a0f6a5d4325e2fe65c31a545e) refactor(contracts): centralize output schema lookup ### 📊 Changes **271 files changed** (+5946 additions, -5675 deletions) <details> <summary>View changed files</summary> 📝 `docs/product-catalog.json` (+2 -2) 📝 `docs/verification/managed-conformance-manifest.json` (+2 -2) 📝 `package.json` (+1 -1) ➕ `scripts/clean-build-output.mjs` (+10 -0) 📝 `scripts/generate-mcp-tool-catalog.mjs` (+35 -14) 📝 `scripts/lib/verify-package-core.mjs` (+4 -7) 📝 `scripts/verify-managed-conformance.mjs` (+3 -3) 📝 `scripts/verify-package-mcp.mjs` (+21 -13) 📝 `scripts/verify-real-browser.mjs` (+1 -0) 📝 `scripts/verify-real-javascript-replay.mjs` (+24 -10) 📝 `scripts/verify-windows-package.mjs` (+2 -2) 📝 `skills/reverse-engineer-anything/SKILL.md` (+1 -1) 📝 `src/application/ApplicationWorkflowEvidenceResolver.ts` (+33 -28) ➕ `src/application/ArtifactInventory/policy.ts` (+41 -0) 📝 `src/application/ArtifactInventory/reader.ts` (+2 -10) 📝 `src/application/ArtifactInventory/scanCanonical.ts` (+0 -8) 📝 `src/application/ArtifactInventory/scanReader.ts` (+12 -12) 📝 `src/application/ArtifactInventory/types.ts` (+12 -17) 📝 `src/application/BinarySession.ts` (+16 -20) 📝 `src/application/BinarySessionStatus.ts` (+13 -7) _...and 80 more files_ </details> ### 📄 Description ## Description Replace permissive intermediate states with boundary-parsed, discriminated values across configuration, provider selection, binary targets, replay/process outcomes, managed workflows, browser capture, and native API evidence. Contradictory states are rejected as inputs instead of surviving into application logic. MCP registration now gives the canonical Zod input and output contracts directly to the 2.0 SDK. The SDK owns request parsing, output validation, registered-tool advertisement, per-request client metadata, connection lifetime, and list-change behavior. The generated catalog is captured through a real SDK client/server connection, so it cannot drift from `tools/list`. This removes the parallel input parser, manual JSON Schema override layer, server-global metadata fallbacks, and transport-level live-server bookkeeping. The contract cleanup also closes three concrete invalid states found while reviewing the SDK projection: - web capture comparison is an exact passive-or-scenario union; - browser script-source capture requires a separate explicit approval and records that approval in Evidence; - Node characterization plans and native ABI return/parameter records use field-specific effect and role variants. No tool names or provider authorities are added or removed. Setup behavior and provider mutation boundaries are unchanged. Suggested review order: 1. Configuration and runtime state parsing (`79cc9df3`, `63b0b1c1`). 2. Provider, target, workflow, and integrity unions (`21501091`). 3. SDK-owned MCP registration and deleted parallel catalog machinery (`ade56a6e`, `04c198e7`, `410569f0`). 4. Exact build and package verification (`ba7327d9`, `20dba840`, `85d27fb7`, `7b00579e`). 5. Centralized contract drift boundary (`33a0f627`). ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Documentation update - [ ] Performance improvement - [x] Refactoring (no functional change) - [x] Tool contract change (MCP schema modification) ## Testing Performed - [x] Unit tests added or updated - [x] TypeScript typecheck passes (`npm run typecheck`) - [x] Linting passes (`npm run lint`) - [x] Full test suite passes (`npm test`) - [ ] Real Hopper verification performed (`npm run verify:hopper`) - [ ] Linux real Hopper verification performed (`npm run verify:hopper:linux`) or unavailability explained - [ ] Real browser verification performed (`npm run verify:browser`) or unavailability explained - [ ] Package verification performed (`npm run verify:package`) Validation performed on the final local tree: - `npm run check:pr` — 329 test files and 1,697 tests passed; typecheck, lint, formatting, Knip, metadata, SDK-derived catalog, generated docs, documentation facts, and error-schema checks passed. - Focused MCP/browser/native regression suites — 21 tests passed, covering SDK output validation, catalog identity, modern request metadata, incomplete browser comparisons, explicit source approval, Evidence provenance, Node effect narrowing, and native ABI roles. Real Hopper, Linux Hopper, Ghidra, browser, and package verification were not run locally. Provider execution and bridge semantics are unchanged; the PR workflows remain the source of cross-platform and real-provider evidence. ## Tool Contract Impact The canonical 116-tool inventory remains complete and stable. Tool schemas now come from the same registered SDK contracts that parse calls and validate successful structured output. The caller-visible changes reject incomplete browser comparison pairs, unapproved browser source capture, invalid Node characterization effects, and mismatched native ABI roles. Generated product, skill, Evidence manifest, and MCP catalog metadata were regenerated and verified. ## Related Issues No linked issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:22 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:57:29 +00:00

[PR #2014] [MERGED] fix(ghidra): recover stale clients on same-target reopen #4967

bsakaguchi referenced this issue

2026-10-31 01:07:11 +00:00

[PR #2945] [CLOSED] fix(ghidra): tell callers to reopen after the provider exits #5507

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2014

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns