[PR #471] [MERGED] refactor(test): colocate pure-domain tests and reduce test debt #2017

New issue

Closed

opened 2026-10-16 21:13:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-16 21:13:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/471
Author: @morluto
Created: 8/10/2026
Status: ✅ Merged
Merged: 8/10/2026
Merged by: @morluto

Base: main ← Head: agent/reduce-test-debt

📝 Commits (4)

8acf59d refactor(test): colocate pure-domain tests and reduce test debt
04dc7e7 docs: remove test migration ledger
5813385 docs: clean up stale migration artifacts
765a0cd fix: repair CI failures from schema, knip, and stale generated artifacts

📊 Changes

302 files changed (+6791 additions, -5750 deletions)

View changed files

📝 .oxlintrc.json (+22 -2)
📝 AGENTS.md (+1 -1)
📝 docs/product-catalog.json (+2 -2)
➖ docs/test-migration-ledger.md (+0 -73)
📝 docs/testing.md (+11 -3)
📝 docs/verification/managed-conformance-manifest.json (+2 -2)
📝 scripts/lib/catalog-schemas.mjs (+2 -0)
📝 skills/reverse-engineer-anything/SKILL.md (+1 -1)
📝 src/application/AnalysisContextQueries.test.ts (+4 -4)
➕ src/application/AnalysisSnapshotCache.test.ts (+82 -0)
📝 src/application/ArtifactInventoryPolicy.test.ts (+1 -1)
📝 src/application/BinarySession.ts (+2 -20)
📝 src/application/BinarySessionComposition.ts (+1 -45)
➕ src/application/BrowserObservationService.test.ts (+48 -0)
➕ src/application/CapabilityInventory.contract.test.ts (+30 -0)
📝 src/application/CapabilityInventory.test.ts (+1 -1)
📝 src/application/ClientRegistrationStatus.ts (+53 -17)
📝 src/application/Doctor.ts (+7 -5)
📝 src/application/DoctorScope.ts (+8 -4)
📝 src/application/ElectronBoundaryAnalysis.ts (+10 -9)

...and 80 more files

📄 Description

Summary

Colocate focused immutable domain/contracts/adapter tests beside their production owners under src/** as *.test.ts/*.fixture.ts, and move persistence-shaped composition tests under tests/boundary/filesystem/**.
Update import paths and the Vitest project topology so the pure domain/contracts and recording-port service projects share one worker module context (no mutable runtime resources), while adapter/composition/boundary projects retain per-file isolation.
Refresh docs/test-migration-ledger.md, docs/testing.md, AGENTS.md, and .oxlintrc.json to reflect the new ownership boundaries.

Test plan

npm run check:fast (cached typecheck + lint) passes
npm run check:pr (full test gate + generated-document validation)
npm test green

Generated with Devin

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/471 **Author:** [@morluto](https://github.com/morluto) **Created:** 8/10/2026 **Status:** ✅ Merged **Merged:** 8/10/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `agent/reduce-test-debt` --- ### 📝 Commits (4) - [`8acf59d`](https://github.com/morluto/rea/commit/8acf59dd1ed4c00c30b0673df0626fc1ed10be61) refactor(test): colocate pure-domain tests and reduce test debt - [`04dc7e7`](https://github.com/morluto/rea/commit/04dc7e72fdf2c8c4f3c9b9ecbef6882bf1cc022e) docs: remove test migration ledger - [`5813385`](https://github.com/morluto/rea/commit/5813385105f71f54d345dac21ea00e1d4af3b77e) docs: clean up stale migration artifacts - [`765a0cd`](https://github.com/morluto/rea/commit/765a0cda00b1accf9869307eeed47952a6760617) fix: repair CI failures from schema, knip, and stale generated artifacts ### 📊 Changes **302 files changed** (+6791 additions, -5750 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+22 -2) 📝 `AGENTS.md` (+1 -1) 📝 `docs/product-catalog.json` (+2 -2) ➖ `docs/test-migration-ledger.md` (+0 -73) 📝 `docs/testing.md` (+11 -3) 📝 `docs/verification/managed-conformance-manifest.json` (+2 -2) 📝 `scripts/lib/catalog-schemas.mjs` (+2 -0) 📝 `skills/reverse-engineer-anything/SKILL.md` (+1 -1) 📝 `src/application/AnalysisContextQueries.test.ts` (+4 -4) ➕ `src/application/AnalysisSnapshotCache.test.ts` (+82 -0) 📝 `src/application/ArtifactInventoryPolicy.test.ts` (+1 -1) 📝 `src/application/BinarySession.ts` (+2 -20) 📝 `src/application/BinarySessionComposition.ts` (+1 -45) ➕ `src/application/BrowserObservationService.test.ts` (+48 -0) ➕ `src/application/CapabilityInventory.contract.test.ts` (+30 -0) 📝 `src/application/CapabilityInventory.test.ts` (+1 -1) 📝 `src/application/ClientRegistrationStatus.ts` (+53 -17) 📝 `src/application/Doctor.ts` (+7 -5) 📝 `src/application/DoctorScope.ts` (+8 -4) 📝 `src/application/ElectronBoundaryAnalysis.ts` (+10 -9) _...and 80 more files_ </details> ### 📄 Description ## Summary - Colocate focused immutable domain/contracts/adapter tests beside their production owners under `src/**` as `*.test.ts`/`*.fixture.ts`, and move persistence-shaped composition tests under `tests/boundary/filesystem/**`. - Update import paths and the Vitest project topology so the pure domain/contracts and recording-port service projects share one worker module context (no mutable runtime resources), while adapter/composition/boundary projects retain per-file isolation. - Refresh `docs/test-migration-ledger.md`, `docs/testing.md`, `AGENTS.md`, and `.oxlintrc.json` to reflect the new ownership boundaries. #### Test plan - [x] `npm run check:fast` (cached typecheck + lint) passes - [ ] `npm run check:pr` (full test gate + generated-document validation) - [ ] `npm test` green Generated with [Devin](https://devin.ai) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-16 21:13:24 +00:00